Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix: keep unconfirmed Loom imports held while their worker may still run
Richie McIlroy82e1a2b93053
diff --git a/apps/web/__tests__/unit/loom-importer-redrive.test.ts b/apps/web/__tests__/unit/loom-importer-redrive.test.tsindex df93902dc..200e38f67 100644--- a/apps/web/__tests__/unit/loom-importer-redrive.test.ts+++ b/apps/web/__tests__/unit/loom-importer-redrive.test.ts@@ -225,21 +225,16 @@ describe("redriveLoomImport", () => {});});- it("restarts an unconfirmed import left processing once its worker can no longer be running", async () => {+ it("leaves an unconfirmed import processing because its worker may still be running", async () => {mocks.runState.mockResolvedValue("unconfirmed");mocks.rows = [- failedImport({ phase: "processing", uploadUpdatedAt: hoursAgo(0.5) }),+ failedImport({ phase: "processing", uploadUpdatedAt: hoursAgo(3) }),];await expect(redriveLoomImport("video", now)).resolves.toMatchObject({status: "skipped",reason: "phase processing",});- mocks.rows = [- failedImport({ phase: "processing", uploadUpdatedAt: hoursAgo(2) }),- ];- await expect(redriveLoomImport("video", now)).resolves.toMatchObject({- status: "restarted",- });+ expect(mocks.start).not.toHaveBeenCalled();});it("does not start a workflow when another restart claimed the row", async () => {diff --git a/apps/web/lib/loom-import-redrive.ts b/apps/web/lib/loom-import-redrive.tsindex 00ceb5e58..1653c2029 100644--- a/apps/web/lib/loom-import-redrive.ts+++ b/apps/web/lib/loom-import-redrive.ts@@ -62,8 +62,8 @@ export async function redriveLoomImport(const runState = await getLoomImportRunState(row.metadata?.loomImportRun);const abandoned =row.phase === "processing" &&- ((runState === "inactive" && age > ABANDONED_PROCESSING_AGE_MS) ||- (runState === "unconfirmed" && age >= FINISHED_WORKER_AGE_MS));+ runState === "inactive" &&+ age > ABANDONED_PROCESSING_AGE_MS;if (row.phase !== "error" && !stalled && !abandoned)return { videoId, status: "skipped", reason: `phase ${row.phase}` };if (runState === "pending" || runState === "active")