Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(chrome-extension): show hours in recording timers
Paddy8f53b0e406e4
diff --git a/apps/chrome-extension/src/shared/format-duration.test.ts b/apps/chrome-extension/src/shared/format-duration.test.tsnew file mode 100644index 000000000..c449375da--- /dev/null+++ b/apps/chrome-extension/src/shared/format-duration.test.ts@@ -0,0 +1,19 @@+import { describe, expect, it } from "vitest";+import { formatDuration, formatRecordedDuration } from "./format-duration";++describe("recording durations", () => {+ it("keeps M:SS under an hour", () => {+ expect(formatDuration(0)).toBe("0:00");+ expect(formatDuration(95_700)).toBe("1:35");+ expect(formatDuration(3_599_999)).toBe("59:59");+ expect(formatRecordedDuration(400)).toBe("0:01");+ expect(formatRecordedDuration(95_500)).toBe("1:36");+ });++ it("shows hours from an hour on instead of counting minutes past 59", () => {+ expect(formatDuration(3_600_000)).toBe("1:00:00");+ expect(formatDuration(3_905_900)).toBe("1:05:05");+ expect(formatRecordedDuration(3_599_600)).toBe("1:00:00");+ expect(formatRecordedDuration(3_905_000)).toBe("1:05:05");+ });+});diff --git a/apps/chrome-extension/src/shared/format-duration.ts b/apps/chrome-extension/src/shared/format-duration.tsindex 8ec62b380..07ed159c2 100644--- a/apps/chrome-extension/src/shared/format-duration.ts+++ b/apps/chrome-extension/src/shared/format-duration.ts@@ -1,17 +1,18 @@+const formatClock = (totalSeconds: number) => {+ const hours = Math.floor(totalSeconds / 3600);+ const minutes = Math.floor(totalSeconds / 60) % 60;+ const seconds = (totalSeconds % 60).toString().padStart(2, "0");+ return hours > 0+ ? `${hours}:${minutes.toString().padStart(2, "0")}:${seconds}`+ : `${minutes}:${seconds}`;+};+// Live timers (recording bars) count up from 0:00 and truncate so the// display never runs ahead of the actual elapsed time.-export const formatDuration = (durationMs: number) => {- const totalSeconds = Math.max(0, Math.floor(durationMs / 1000));- const minutes = Math.floor(totalSeconds / 60);- const seconds = totalSeconds % 60;- return `${minutes}:${seconds.toString().padStart(2, "0")}`;-};+export const formatDuration = (durationMs: number) =>+ formatClock(Math.max(0, Math.floor(durationMs / 1000)));// Finished recordings round to the nearest second and never show 0:00 — a// sub-second capture still represents real data.-export const formatRecordedDuration = (durationMs: number) => {- const totalSeconds = Math.max(1, Math.round(durationMs / 1000));- const minutes = Math.floor(totalSeconds / 60);- const seconds = totalSeconds % 60;- return `${minutes}:${seconds.toString().padStart(2, "0")}`;-};+export const formatRecordedDuration = (durationMs: number) =>+ formatClock(Math.max(1, Math.round(durationMs / 1000)));