Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(sdk-recorder): preserve the default upload URL
Akshar Patel94b7dd099011
diff --git a/packages/sdk-recorder/__tests__/duration-limit.test.ts b/packages/sdk-recorder/__tests__/duration-limit.test.tsdeleted file mode 100644index f793953ba..000000000--- a/packages/sdk-recorder/__tests__/duration-limit.test.ts+++ /dev/null@@ -1,89 +0,0 @@-import { afterEach, expect, mock, test } from "bun:test";-import { CapRecorder } from "../src/index";--class Track {- readonly kind = "video";- readyState = "live";- onended: (() => void) | null = null;- stop() {- this.readyState = "ended";- }-}--class Stream {- constructor(private tracks: Track[]) {}- getTracks() {- return this.tracks;- }- getVideoTracks() {- return this.tracks;- }- getAudioTracks() {- return [];- }-}--class Encoder {- state = "inactive";- static isTypeSupported() {- return true;- }- start() {- this.state = "recording";- }- stop() {- this.state = "inactive";- }-}--const originals = new Map(- [- "navigator",- "MediaStream",- "MediaRecorder",- "setTimeout",- "clearTimeout",- ].map((key) => [key, Object.getOwnPropertyDescriptor(globalThis, key)]),-);--afterEach(() => {- for (const [key, descriptor] of originals) {- if (descriptor) Object.defineProperty(globalThis, key, descriptor);- else Reflect.deleteProperty(globalThis, key);- }-});--test.each([- { constructorLimit: undefined, startLimit: undefined, expected: 14_400_000 },- { constructorLimit: 1500, startLimit: undefined, expected: 1500 },- { constructorLimit: 1500, startLimit: 700, expected: 700 },- { constructorLimit: 1500, startLimit: 0, expected: 0 },-])("schedules $expected ms for the recording", async (scenario) => {- const stream = new Stream([new Track()]);- const schedule = mock((_callback: () => void, _delay?: number) => 1);- const globals = {- navigator: { mediaDevices: { getUserMedia: async () => stream } },- MediaStream: Stream,- MediaRecorder: Encoder,- setTimeout: schedule,- clearTimeout: mock(() => {}),- };- for (const [key, value] of Object.entries(globals)) {- Object.defineProperty(globalThis, key, { configurable: true, value });- }- const recorder = new CapRecorder({- publicKey: "test-only",- mode: "camera",- microphone: { enabled: false },- maxDurationMs: scenario.constructorLimit,- });- try {- await recorder.start({ maxDurationMs: scenario.startLimit });- expect(recorder.phase).toBe("recording");- expect(schedule.mock.calls).toEqual([- [expect.any(Function), scenario.expected],- ]);- } finally {- recorder.destroy();- }-});diff --git a/packages/sdk-recorder/__tests__/recorder-options.test.ts b/packages/sdk-recorder/__tests__/recorder-options.test.tsnew file mode 100644index 000000000..0c2ec588e--- /dev/null+++ b/packages/sdk-recorder/__tests__/recorder-options.test.ts@@ -0,0 +1,160 @@+import { afterEach, beforeEach, expect, mock, test } from "bun:test";+import { CapRecorder } from "../src/index";++class Track {+ readonly kind = "video";+ readyState = "live";+ onended: (() => void) | null = null;+ stop() {+ this.readyState = "ended";+ }+}++class Stream {+ constructor(private tracks: Track[]) {}+ getTracks() {+ return this.tracks;+ }+ getVideoTracks() {+ return this.tracks;+ }+ getAudioTracks() {+ return [];+ }+}++class Encoder {+ state = "inactive";+ ondataavailable: ((event: { data: Blob }) => void) | null = null;+ onstop: (() => void) | null = null;+ static isTypeSupported() {+ return true;+ }+ start() {+ this.state = "recording";+ }+ stop() {+ this.state = "inactive";+ if (!this.onstop) return;+ this.ondataavailable?.({ data: new Blob(["recording"]) });+ queueMicrotask(this.onstop);+ }+}++const originals = new Map(+ [+ "navigator",+ "MediaStream",+ "MediaRecorder",+ "setTimeout",+ "clearTimeout",+ "fetch",+ ].map((key) => [key, Object.getOwnPropertyDescriptor(globalThis, key)]),+);++beforeEach(() => {+ const stream = new Stream([new Track()]);+ const globals = {+ navigator: {+ mediaDevices: {+ getUserMedia: async () => stream,+ getDisplayMedia: async () => stream,+ },+ },+ MediaStream: Stream,+ MediaRecorder: Encoder,+ };+ for (const [key, value] of Object.entries(globals)) {+ Object.defineProperty(globalThis, key, { configurable: true, value });+ }+});++afterEach(() => {+ for (const [key, descriptor] of originals) {+ if (descriptor) Object.defineProperty(globalThis, key, descriptor);+ else Reflect.deleteProperty(globalThis, key);+ }+});++test.each([+ { constructorLimit: undefined, startLimit: undefined, expected: 14_400_000 },+ { constructorLimit: 1500, startLimit: undefined, expected: 1500 },+ { constructorLimit: 1500, startLimit: 700, expected: 700 },+ { constructorLimit: 1500, startLimit: 0, expected: 0 },+])("schedules $expected ms for the recording", async (scenario) => {+ const schedule = mock((_callback: () => void, _delay?: number) => 1);+ const globals = {+ setTimeout: schedule,+ clearTimeout: mock(() => {}),+ };+ for (const [key, value] of Object.entries(globals)) {+ Object.defineProperty(globalThis, key, { configurable: true, value });+ }+ const recorder = new CapRecorder({+ publicKey: "test-only",+ mode: "camera",+ microphone: { enabled: false },+ maxDurationMs: scenario.constructorLimit,+ });+ try {+ await recorder.start({ maxDurationMs: scenario.startLimit });+ expect(recorder.phase).toBe("recording");+ expect(schedule.mock.calls).toEqual([+ [expect.any(Function), scenario.expected],+ ]);+ } finally {+ recorder.destroy();+ }+});++test.each([+ { options: {}, expectedBase: "https://cap.so" },+ {+ options: { apiBase: undefined, mode: undefined },+ expectedBase: "https://cap.so",+ },+ {+ options: { apiBase: "https://custom.invalid" },+ expectedBase: "https://custom.invalid",+ },+ { options: { apiBase: "" }, expectedBase: "" },+])("uploads to '$expectedBase' with options $options", async (scenario) => {+ const requests: string[] = [];+ const fetch = mock(async (input: string) => {+ requests.push(input);+ if (input.endsWith("/videos/create"))+ return Response.json({ videoId: "test-video" });+ if (input.endsWith("/initiate"))+ return Response.json({ uploadId: "test-upload" });+ if (input.endsWith("/presign-part"))+ return Response.json({ presignedUrl: "https://upload.invalid/part" });+ if (input === "https://upload.invalid/part")+ return new Response(null, { headers: { ETag: "test-etag" } });+ if (input.endsWith("/complete")) return Response.json({ success: true });+ throw new Error(`Unexpected request: ${input}`);+ });+ Object.defineProperty(globalThis, "fetch", {+ configurable: true,+ value: fetch,+ });+ const recorder = new CapRecorder({+ publicKey: "test-only",+ microphone: { enabled: false },+ ...scenario.options,+ });+ try {+ await recorder.start();+ await recorder.stop();+ expect(recorder.phase).toBe("complete");+ const base = `${scenario.expectedBase}/api/developer/sdk/v1`;+ expect(requests).toEqual([+ `${base}/videos/create`,+ `${base}/upload/multipart/initiate`,+ `${base}/upload/multipart/presign-part`,+ "https://upload.invalid/part",+ `${base}/upload/multipart/complete`,+ ]);+ } finally {+ recorder.destroy();+ }+});diff --git a/packages/sdk-recorder/src/index.ts b/packages/sdk-recorder/src/index.tsindex 2da81477c..0bb0e7690 100644--- a/packages/sdk-recorder/src/index.ts+++ b/packages/sdk-recorder/src/index.ts@@ -51,9 +51,9 @@ export class CapRecorder {constructor(options: RecorderOptions) {this.options = {- apiBase: DEFAULT_API_BASE,- mode: "fullscreen",...options,+ apiBase: options.apiBase ?? DEFAULT_API_BASE,+ mode: options.mode ?? "fullscreen",};this.maxDurationMs = options.maxDurationMs ?? 4 * 60 * 60 * 1000;this.client = new MultipartClient(