Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(cli): start Instant recordings behind a start gate

Richie McIlroy9acfe8d801c1
diff --git a/apps/cli/src/record.rs b/apps/cli/src/record.rs
index 58ff1eba1..7ffa7b459 100644
--- a/apps/cli/src/record.rs
+++ b/apps/cli/src/record.rs
@@ -868,8 +868,13 @@ async fn start_recording(
if let Some(fps) = params.fps {
builder = builder.with_max_fps(fps);
}
+ // As in the desktop app: the screen and audio tracks both start at
+ // the gate's arm time, so a microphone that is ready late does not
+ // move all audio early. The CLI has no start cue to wait for.
+ let start_gate = cap_recording::RecordingStartGate::new();
+ builder = builder.with_start_gate(start_gate.clone());
- builder
+ let actor = builder
.build(
#[cfg(target_os = "macos")]
Some(
@@ -877,11 +882,12 @@ async fn start_recording(
),
)
.await
- .map(|actor| ActorHandle::Instant {
- actor,
- _upload_lock: upload_lock,
- })
- .map_err(|e| e.to_string())
+ .map_err(|e| e.to_string())?;
+ start_gate.arm();
+ Ok(ActorHandle::Instant {
+ actor,
+ _upload_lock: upload_lock,
+ })
}
}
}