Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(recording): keep the backup when it holds a legacy omitted track, and gate the backup check to unix

Richie McIlroyaaa056868a29
diff --git a/crates/recording/src/recovery.rs b/crates/recording/src/recovery.rs
index 9ca452c12..96c7618b5 100644
--- a/crates/recording/src/recovery.rs
+++ b/crates/recording/src/recovery.rs
@@ -286,8 +286,12 @@ impl RecoveryManager {
// Without a preparing editor nothing reads the originals once they are
// published, so the backup goes with the stop instead of doubling the
- // recording's size on disk for good.
- let unread = preparing.is_none();
+ // recording's size on disk for good -- unless it holds a legacy
+ // omitted track, which publication leaves out and only the backup
+ // keeps.
+ let unread = preparing.is_none()
+ && legacy_omitted_tracks(&incomplete.meta, project_path)
+ .is_ok_and(|tracks| tracks.is_empty());
let published_workspace = std::cell::RefCell::new(None);
Self::finalize_with_publication(
&incomplete,
@@ -5237,8 +5241,8 @@ mod clean_studio_snapshot_tests {
})
.unwrap();
// A stop without a preparing editor retires the original backup once
- // the published tracks above are in place.
- assert!(!backup.join("original-segments").exists());
+ // the published tracks above are in place (unix only, for now).
+ assert_eq!(backup.join("original-segments").exists(), !cfg!(unix));
}
#[test]