Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(web): seek the first transcript search result

Aditya Garudad25edd80716
diff --git a/apps/web/__tests__/unit/transcript-sidebar-search.test.ts b/apps/web/__tests__/unit/transcript-sidebar-search.test.ts
new file mode 100644
index 000000000..63096a27b
--- /dev/null
+++ b/apps/web/__tests__/unit/transcript-sidebar-search.test.ts
@@ -0,0 +1,175 @@
+// @vitest-environment jsdom
+
+import type { Video } from "@cap/web-domain";
+import { act, createElement, type RefObject } from "react";
+import { createRoot, type Root } from "react-dom/client";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+const mocks = vi.hoisted(() => ({
+ getEditTranscript: vi.fn(),
+ scrollToIndex: vi.fn(),
+}));
+
+vi.mock("@/actions/videos/get-edit-transcript", () => ({
+ getEditTranscript: mocks.getEditTranscript,
+ requestEditTranscript: vi.fn(),
+}));
+
+vi.mock("@/app/s/[videoId]/edit/use-active-transcript-word-index", () => ({
+ useActiveTranscriptWordIndex: () => -1,
+}));
+
+vi.mock("@virtual-grid/react", () => ({
+ useVirtualizer: ({ count }: { count: number }) => ({
+ getTotalSize: () => count * 100,
+ getVirtualItems: () =>
+ Array.from({ length: count }, (_, index) => ({
+ index,
+ key: index,
+ start: index * 100,
+ })),
+ measureElement: vi.fn(),
+ scrollToIndex: mocks.scrollToIndex,
+ }),
+}));
+
+import { TranscriptSidebar } from "@/app/s/[videoId]/edit/TranscriptSidebar";
+
+const videoId = "video-id" as Video.VideoId;
+const transcript = {
+ version: 3 as const,
+ speechModelUsed: "fixture",
+ durationMs: 5_000,
+ languageCode: "en",
+ words: [
+ {
+ id: "word-0",
+ text: "Match",
+ startMs: 1_000,
+ endMs: 1_400,
+ confidence: 1,
+ speaker: null,
+ channel: null,
+ },
+ {
+ id: "word-1",
+ text: "between",
+ startMs: 2_000,
+ endMs: 2_400,
+ confidence: 1,
+ speaker: null,
+ channel: null,
+ },
+ {
+ id: "word-2",
+ text: "matching",
+ startMs: 3_000,
+ endMs: 3_400,
+ confidence: 1,
+ speaker: null,
+ channel: null,
+ },
+ ],
+};
+
+let container: HTMLDivElement;
+let root: Root;
+let video: HTMLVideoElement;
+
+async function waitFor(assertion: () => void) {
+ let error: unknown;
+ for (let attempt = 0; attempt < 50; attempt++) {
+ try {
+ assertion();
+ return;
+ } catch (cause) {
+ error = cause;
+ }
+ await act(async () => {
+ await new Promise((resolve) => setTimeout(resolve, 10));
+ });
+ }
+ throw error;
+}
+
+async function enterSearch(query: string) {
+ const input = container.querySelector<HTMLInputElement>(
+ 'input[placeholder="Search transcript"]',
+ );
+ if (!input) throw new Error("Search input missing");
+
+ await act(async () => {
+ const setter = Object.getOwnPropertyDescriptor(
+ HTMLInputElement.prototype,
+ "value",
+ )?.set;
+ setter?.call(input, query);
+ input.dispatchEvent(new Event("input", { bubbles: true }));
+ });
+ await waitFor(() => expect(container.textContent).toContain("1/2"));
+ return input;
+}
+
+async function pressEnter(input: HTMLInputElement) {
+ await act(async () => {
+ input.dispatchEvent(
+ new KeyboardEvent("keydown", { bubbles: true, key: "Enter" }),
+ );
+ });
+}
+
+beforeEach(async () => {
+ vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
+ vi.stubGlobal("requestAnimationFrame", (callback: FrameRequestCallback) => {
+ callback(0);
+ return 1;
+ });
+ HTMLElement.prototype.scrollIntoView = vi.fn();
+ mocks.getEditTranscript.mockResolvedValue({ status: "ready", transcript });
+ container = document.createElement("div");
+ document.body.append(container);
+ root = createRoot(container);
+ video = document.createElement("video");
+ const videoRef: RefObject<HTMLVideoElement | null> = { current: video };
+
+ await act(async () => {
+ root.render(
+ createElement(TranscriptSidebar, {
+ videoId,
+ videoRef,
+ keepRanges: [{ start: 0, end: 5 }],
+ onDeleteRanges: vi.fn(),
+ }),
+ );
+ });
+ await waitFor(() =>
+ expect(
+ container.querySelector('input[placeholder="Search transcript"]'),
+ ).not.toBeNull(),
+ );
+});
+
+afterEach(async () => {
+ await act(async () => root.unmount());
+ container.remove();
+ vi.unstubAllGlobals();
+ vi.clearAllMocks();
+});
+
+describe("transcript search navigation", () => {
+ it("seeks to the first match before advancing through later matches", async () => {
+ const input = await enterSearch("match");
+
+ await pressEnter(input);
+ expect(video.currentTime).toBe(1);
+ expect(container.textContent).toContain("1/2");
+
+ await pressEnter(input);
+ expect(video.currentTime).toBe(3);
+ expect(container.textContent).toContain("2/2");
+
+ await pressEnter(input);
+ expect(video.currentTime).toBe(1);
+ expect(container.textContent).toContain("1/2");
+ });
+});
diff --git a/apps/web/app/s/[videoId]/edit/TranscriptSidebar.tsx b/apps/web/app/s/[videoId]/edit/TranscriptSidebar.tsx
index dd72e7b39..0c54fcf62 100644
--- a/apps/web/app/s/[videoId]/edit/TranscriptSidebar.tsx
+++ b/apps/web/app/s/[videoId]/edit/TranscriptSidebar.tsx
@@ -240,7 +240,7 @@ export function TranscriptSidebar({
endIndex: number;
} | null>(null);
const [searchQuery, setSearchQuery] = useState("");
- const [searchMatchIndex, setSearchMatchIndex] = useState(0);
+ const [searchMatchIndex, setSearchMatchIndex] = useState(-1);
const [previewFillers, setPreviewFillers] = useState(false);
const deferredSearchQuery = useDeferredValue(searchQuery);
const dragAnchorRef = useRef<number | null>(null);
@@ -465,9 +465,14 @@ export function TranscriptSidebar({
const moveSearchMatch = useCallback(
(direction: -1 | 1) => {
if (searchMatches.length === 0) return;
- const next =
- (searchMatchIndex + direction + searchMatches.length) %
- searchMatches.length;
+ let next: number;
+ if (searchMatchIndex === -1) {
+ next = direction === 1 ? 0 : searchMatches.length - 1;
+ } else {
+ next =
+ (searchMatchIndex + direction + searchMatches.length) %
+ searchMatches.length;
+ }
setSearchMatchIndex(next);
const wordIndex = searchMatches[next];
if (wordIndex === undefined) return;
@@ -666,7 +671,7 @@ export function TranscriptSidebar({
value={searchQuery}
onChange={(event) => {
setSearchQuery(event.target.value);
- setSearchMatchIndex(0);
+ setSearchMatchIndex(-1);
}}
onKeyDown={(event) => {
if (event.key === "Enter") {
@@ -678,7 +683,7 @@ export function TranscriptSidebar({
event.preventDefault();
event.stopPropagation();
setSearchQuery("");
- setSearchMatchIndex(0);
+ setSearchMatchIndex(-1);
}
}}
placeholder="Search transcript"
@@ -687,8 +692,10 @@ export function TranscriptSidebar({
{searchQuery && (
<>
<span className="shrink-0 text-[10px] font-medium tabular-nums text-gray-9">
- {searchMatches.length === 0 ? 0 : searchMatchIndex + 1}/
- {searchMatches.length}
+ {searchMatches.length === 0
+ ? 0
+ : Math.max(searchMatchIndex + 1, 1)}
+ /{searchMatches.length}
</span>
<button
type="button"