Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(sdk-recorder): release capture before uploading
Akshar Patelb1511e1f7249
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.ymlindex 9b172fa48..dbfadd702 100644--- a/.github/workflows/ci.yml+++ b/.github/workflows/ci.yml@@ -117,6 +117,9 @@ jobs:- name: Test Chrome extensionrun: bun run --cwd apps/chrome-extension test+ - name: Test recorder SDK+ run: bun --no-install test packages/sdk-recorder+- name: Test render farm orchestrationrun: |bun test apps/render-farmdiff --git a/packages/sdk-recorder/__tests__/capture-release.test.ts b/packages/sdk-recorder/__tests__/capture-release.test.tsnew file mode 100644index 000000000..5f270915b--- /dev/null+++ b/packages/sdk-recorder/__tests__/capture-release.test.ts@@ -0,0 +1,141 @@+import { afterEach, beforeEach, expect, test } from "bun:test";+import { CapRecorder } from "../src/index";++class Track {+ readyState: MediaStreamTrackState = "live";+ constructor(readonly kind: "video" | "audio") {}+ stop() {+ this.readyState = "ended";+ }+}++class Stream {+ constructor(private readonly tracks: Track[]) {}+ getTracks() {+ return this.tracks;+ }+ getVideoTracks() {+ return this.tracks.filter((track) => track.kind === "video");+ }+ getAudioTracks() {+ return this.tracks.filter((track) => track.kind === "audio");+ }+}++class Encoder {+ state: RecordingState = "inactive";+ ondataavailable: ((event: { data: Blob }) => void) | null = null;+ onstop: (() => void) | null = null;+ static isTypeSupported() {+ return true;+ }+ start() {+ this.state = "recording";+ this.ondataavailable?.({ data: new Blob(["recording bytes"]) });+ }+ pause() {+ this.state = "paused";+ }+ stop() {+ if (this.state === "inactive") return;+ this.state = "inactive";+ queueMicrotask(() => {+ this.ondataavailable?.({ data: new Blob(["final recording bytes"]) });+ this.onstop?.();+ });+ }+}++const originals = ["navigator", "MediaStream", "MediaRecorder", "fetch"].map(+ (name) => [name, Object.getOwnPropertyDescriptor(globalThis, name)] as const,+);++beforeEach(() => {+ for (const [name, value] of Object.entries({+ MediaStream: Stream,+ MediaRecorder: Encoder,+ })) {+ Object.defineProperty(globalThis, name, { configurable: true, value });+ }+});++afterEach(() => {+ for (const [name, descriptor] of originals) {+ if (descriptor) Object.defineProperty(globalThis, name, descriptor);+ else Reflect.deleteProperty(globalThis, name);+ }+});++test.each(["recording", "paused", "upload failure"] as const)(+ "releases capture before an upload settles from %s",+ async (scenario) => {+ const camera = new Track("video");+ const microphone = new Track("audio");+ const started = Promise.withResolvers<void>();+ const gate = Promise.withResolvers<void>();+ let uploaded = "";+ const globals = {+ navigator: {+ mediaDevices: {+ getUserMedia: async (constraints: MediaStreamConstraints) =>+ new Stream([constraints.video ? camera : microphone]),+ },+ },+ fetch: async (input: string, init?: RequestInit) => {+ if (input.endsWith("/videos/create")) {+ started.resolve();+ await gate.promise;+ if (scenario === "upload failure") {+ return new Response("Fixture unavailable", { status: 503 });+ }+ return Response.json({+ videoId: "fixture",+ shareUrl: "https://fixture.invalid/s/fixture",+ embedUrl: "https://fixture.invalid/embed/fixture",+ });+ }+ if (input.endsWith("/initiate")) {+ return Response.json({ uploadId: "upload" });+ }+ if (input.endsWith("/presign-part")) {+ return Response.json({ presignedUrl: "https://fixture.invalid/part" });+ }+ if (input === "https://fixture.invalid/part") {+ uploaded = await new Response(init?.body).text();+ return new Response(null, { headers: { ETag: "fixture-etag" } });+ }+ if (input.endsWith("/complete")) {+ return Response.json({ success: true });+ }+ throw new Error(`Unexpected request ${input}`);+ },+ };+ for (const [name, value] of Object.entries(globals)) {+ Object.defineProperty(globalThis, name, { configurable: true, value });+ }+ const recorder = new CapRecorder({ publicKey: "fixture", mode: "camera" });+ let stopping: ReturnType<CapRecorder["stop"]> | undefined;+ try {+ await recorder.start();+ if (scenario === "paused") recorder.pause();+ stopping = recorder.stop();+ await started.promise;+ expect(recorder.phase).toBe("uploading");+ expect(camera.readyState).toBe("ended");+ expect(microphone.readyState).toBe("ended");+ gate.resolve();+ if (scenario === "upload failure") {+ await expect(stopping).rejects.toThrow("SDK API error (503)");+ expect(recorder.phase).toBe("error");+ } else {+ await expect(stopping).resolves.toMatchObject({ videoId: "fixture" });+ expect(uploaded).toBe("recording bytesfinal recording bytes");+ expect(recorder.phase).toBe("complete");+ }+ } finally {+ gate.resolve();+ await stopping?.catch(() => {});+ recorder.destroy();+ }+ },+);diff --git a/packages/sdk-recorder/src/index.ts b/packages/sdk-recorder/src/index.tsindex edd71d913..a08ea9571 100644--- a/packages/sdk-recorder/src/index.ts+++ b/packages/sdk-recorder/src/index.ts@@ -222,6 +222,10 @@ export class CapRecorder {const stopped = this.recordingStopped;if (recorder.state !== "inactive") recorder.stop();await stopped;+ if (this.streams) {+ releaseStreams(this.streams);+ this.streams = null;+ }return this.uploadRecording();}