Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(media-server): scale the recording timing read budget with file size

Richie McIlroybd65c713e7d9
diff --git a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts
index 129c807bd..3734559ef 100644
--- a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts
+++ b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts
@@ -21,6 +21,7 @@ import {
import {
RecordingTimingError,
readRecordingVideoTiming,
+ timingMetadataBudget,
} from "../../lib/recording-timing";
import {
inspectRecordingSources,
@@ -1964,6 +1965,25 @@ function expectExited(pid: number) {
expect(() => process.kill(pid, 0)).toThrow();
}
+describe("recording timing metadata budget", () => {
+ const mb = 1024 * 1024;
+ test("keeps the 64 MB budget for normal recordings", () => {
+ expect(timingMetadataBudget(0)).toBe(64 * mb);
+ expect(timingMetadataBudget(300 * mb)).toBe(64 * mb);
+ expect(timingMetadataBudget(4096 * mb)).toBe(64 * mb);
+ });
+
+ test("scales with very long recordings up to 1 GB", () => {
+ expect(timingMetadataBudget(20 * 1024 * mb)).toBe(320 * mb);
+ expect(timingMetadataBudget(200 * 1024 * mb)).toBe(1024 * mb);
+ });
+
+ test("ignores an invalid size", () => {
+ expect(timingMetadataBudget(Number.NaN)).toBe(64 * mb);
+ expect(timingMetadataBudget(-1)).toBe(64 * mb);
+ });
+});
+
describe("recording timing metadata lifetime", () => {
test.each(["cancel", "timeout"])(
"joins a stalled raw terminal-duration read after %s",
diff --git a/apps/media-server/src/lib/recording-timing.ts b/apps/media-server/src/lib/recording-timing.ts
index c6b740121..ac1934f17 100644
--- a/apps/media-server/src/lib/recording-timing.ts
+++ b/apps/media-server/src/lib/recording-timing.ts
@@ -13,6 +13,9 @@ import {
} from "mediabunny";
const MAX_METADATA_BYTES = 64 * 1024 * 1024;
+const MAX_LONG_RECORDING_METADATA_BYTES = 1024 * 1024 * 1024;
+// Sample tables grow with a recording's length; reads stream through a fixed cache.
+const METADATA_BYTES_PER_FILE_BYTE = 1 / 64;
const MAX_RANGE_BYTES = 1024 * 1024;
const MAX_CACHE_BYTES = 8 * 1024 * 1024;
const MAX_TERMINAL_PACKETS = 1024;
@@ -304,6 +307,22 @@ async function readTerminalDurations(
return durations;
}
+export function timingMetadataBudget(fileSize: number): number {
+ if (!Number.isSafeInteger(fileSize) || fileSize <= 0)
+ return MAX_METADATA_BYTES;
+ return Math.min(
+ MAX_LONG_RECORDING_METADATA_BYTES,
+ Math.max(
+ MAX_METADATA_BYTES,
+ Math.ceil(fileSize * METADATA_BYTES_PER_FILE_BYTE),
+ ),
+ );
+}
+
+function megabytes(bytes: number): string {
+ return (bytes / (1024 * 1024)).toFixed(1);
+}
+
export async function readRecordingVideoTiming(
path: string,
options: RecordingTimingOptions,
@@ -359,13 +378,10 @@ export async function readRecordingVideoTiming(
const reads = new Set<Promise<Uint8Array>>();
const reserve = (bytes: number) => {
metadataBytes += bytes;
- if (
- !Number.isSafeInteger(bytes) ||
- bytes < 0 ||
- metadataBytes > MAX_METADATA_BYTES
- ) {
+ const budget = timingMetadataBudget(fileSize);
+ if (!Number.isSafeInteger(bytes) || bytes < 0 || metadataBytes > budget) {
throw new RecordingTimingError(
- "Recording timing metadata exceeds its read budget",
+ `Recording timing metadata exceeds its read budget (${megabytes(metadataBytes)} of ${megabytes(budget)} MB for a ${megabytes(fileSize)} MB file)`,
false,
);
}