Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(media-server): let recordings of tiny frames read their timing metadata
Richie McIlroybf5cdaf37e98
diff --git a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.tsindex 8ce747bb6..8e5e1ff04 100644--- a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts+++ b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts@@ -1967,14 +1967,17 @@ function expectExited(pid: number) {describe("recording timing metadata budget", () => {const mb = 1024 * 1024;- test("keeps the 64 MB budget for normal recordings", () => {+ test("keeps at least 64 MB for small recordings", () => {expect(timingMetadataBudget(0)).toBe(64 * mb);- expect(timingMetadataBudget(300 * mb)).toBe(64 * mb);- expect(timingMetadataBudget(4096 * mb)).toBe(64 * mb);+ expect(timingMetadataBudget(2 * mb)).toBe(64 * mb);+ expect(timingMetadataBudget(32 * mb)).toBe(64 * mb);});- test("scales with very long recordings up to 1 GB", () => {- expect(timingMetadataBudget(20 * 1024 * mb)).toBe(320 * mb);+ test("allows twice the file size, up to 1 GB", () => {+ // Production failures: 64 MB read for a 156 MB and a 324 MB recording of tiny frames.+ expect(timingMetadataBudget(156 * mb)).toBe(312 * mb);+ expect(timingMetadataBudget(324 * mb)).toBe(648 * mb);+ expect(timingMetadataBudget(4096 * mb)).toBe(1024 * mb);expect(timingMetadataBudget(200 * 1024 * mb)).toBe(1024 * mb);});diff --git a/apps/media-server/src/lib/recording-timing.ts b/apps/media-server/src/lib/recording-timing.tsindex cec679497..6bf2859e0 100644--- a/apps/media-server/src/lib/recording-timing.ts+++ b/apps/media-server/src/lib/recording-timing.ts@@ -16,8 +16,9 @@ const MAX_METADATA_BYTES = 64 * 1024 * 1024;const MAX_LONG_RECORDING_METADATA_BYTES = 1024 * 1024 * 1024;// A long budget covers many reads; one allocation for a single header box stays bounded.const MAX_SINGLE_METADATA_READ_BYTES = 256 * 1024 * 1024;-// Sample tables grow with a recording's length; reads stream through a fixed cache.-const METADATA_BYTES_PER_FILE_BYTE = 1 / 64;+// Reads stream through a fixed cache and also pull in any fragment that fits in one read, so recordings of+// tiny frames (a mostly static screen) read close to their whole file; allow twice the file size for re-reads.+const METADATA_BYTES_PER_FILE_BYTE = 2;const MAX_RANGE_BYTES = 1024 * 1024;const MAX_CACHE_BYTES = 8 * 1024 * 1024;const MAX_TERMINAL_PACKETS = 1024;