Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
ci(verify): report-only real-capture artifacts for the baseline diff, baselines from runs that succeeded or failed
Richie McIlroyc2d41ba3ed37
diff --git a/.github/workflows/baseline-diff.yml b/.github/workflows/baseline-diff.ymlindex 86077dbe9..f89b935e1 100644--- a/.github/workflows/baseline-diff.yml+++ b/.github/workflows/baseline-diff.yml@@ -68,7 +68,8 @@ jobs:# Baseline runs fail (0.6.0 has known bugs), but a run with a# cancelled or timed-out job stopped before reporting every case.for candidate in $(gh run list --repo "$GITHUB_REPOSITORY" --workflow "$workflow" --branch "$BASELINE_BRANCH" \- --status completed --limit 20 --json databaseId --jq '.[].databaseId'); do+ --limit 20 --json databaseId,conclusion \+ --jq '.[] | select(.conclusion == "success" or .conclusion == "failure") | .databaseId'); dostopped=$(gh run view "$candidate" --repo "$GITHUB_REPOSITORY" --json conclusion,jobs \--jq '[.conclusion, .jobs[].conclusion] | map(select(. == "cancelled" or . == "timed_out")) | length')if [[ "$stopped" == 0 ]]; then@@ -96,10 +97,14 @@ jobs:run=$([[ $side == main ]] && echo "$MAIN_RUN" || echo "$BASELINE_RUN")dest="$RUNNER_TEMP/reports/$side"mkdir -p "$dest"+ # Real capture also uploads its reports alone; runs from before+ # that only have the artifact with the recordings.gh run download "$run" --repo "$GITHUB_REPOSITORY" --dir "$dest" \- --pattern 'verify-report-*' --pattern 'verify-recording-*'- # Recordings are large and not read by the diff.- find "$dest" -type d -name verify-scratch -prune -exec rm -r {} ++ --pattern 'verify-report-*' --pattern 'verify-recording-report-*' || true+ if [[ -z "$(find "$dest" -maxdepth 1 -name 'verify-*' -print -quit)" ]]; then+ gh run download "$run" --repo "$GITHUB_REPOSITORY" --dir "$dest" --pattern 'verify-recording-*'+ find "$dest" -type d -name verify-scratch -prune -exec rm -r {} ++ fiecho "$side: $(find "$dest" -name '*.jsonl' | wc -l) report files"donediff --git a/.github/workflows/verify-recording.yml b/.github/workflows/verify-recording.ymlindex 28a0af887..41ef09139 100644--- a/.github/workflows/verify-recording.yml+++ b/.github/workflows/verify-recording.yml@@ -317,6 +317,14 @@ jobs:run: |python3 scripts/verify/summary.py --title "real capture ${{ matrix.runner }} ${{ needs.scope.outputs.tier }}" "$CAP_VERIFY_REPORT_DIR" >> "$GITHUB_STEP_SUMMARY" || true+ - name: Upload reports+ if: always()+ uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2+ with:+ name: verify-recording-report-${{ matrix.runner }}+ path: ${{ github.workspace }}/verify-report+ if-no-files-found: ignore+- name: Upload artifactsif: always()uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2diff --git a/scripts/verify/diff.py b/scripts/verify/diff.pyindex f112a8739..3beb84d7c 100644--- a/scripts/verify/diff.py+++ b/scripts/verify/diff.py@@ -34,7 +34,7 @@ def lane_of(artifact):m = re.match(r"verify-report-(.+?)-(fast|full)(-\d+)?$", artifact)if m:return m.group(1)- m = re.match(r"verify-recording-(.+)$", artifact)+ m = re.match(r"verify-recording-(?:report-)?(.+)$", artifact)if m:return "recording-" + m.group(1)return artifact