Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(web): validate mobile reply parents
Aditya Garudd32c8d302c8f
diff --git a/apps/web/__tests__/unit/mobile-comment-parent.test.ts b/apps/web/__tests__/unit/mobile-comment-parent.test.tsnew file mode 100644index 000000000..1e74518cb--- /dev/null+++ b/apps/web/__tests__/unit/mobile-comment-parent.test.ts@@ -0,0 +1,222 @@+import * as Db from "@cap/database/schema";+import {+ CurrentUser,+ DatabaseError,+ HttpAuthMiddleware,+ Organisation,+ User,+ Video,+} from "@cap/web-domain";+import { type HttpApi, HttpApiBuilder, HttpServer } from "@effect/platform";+import type { SQL } from "drizzle-orm";+import { MySqlDialect, type MySqlTable } from "drizzle-orm/mysql-core";+import { Effect, Layer, Option } from "effect";+import { afterAll, beforeEach, describe, expect, it, vi } from "vitest";+import {+ Database,+ type DbClient,+} from "../../../../packages/web-backend/src/Database";++const mocks = vi.hoisted(() => ({ notify: vi.fn(async () => undefined) }));+vi.mock("server-only", () => ({}));+vi.mock("@cap/database/auth/auth-options", () => ({ authOptions: () => ({}) }));+vi.mock("@cap/database/emails/config", () => ({ sendEmail: vi.fn() }));+vi.mock("@/actions/loom", () => ({ downloadLoomVideo: vi.fn() }));+vi.mock("@/app/(org)/dashboard/analytics/data", () => ({+ getOrgAnalyticsData: vi.fn(),+}));+vi.mock("@/lib/account-deletion-request", () => ({}));+vi.mock("@/lib/desktop-segments-finalization", () => ({}));+vi.mock("@/lib/Notification", () => ({ createNotification: mocks.notify }));+vi.mock("@/lib/sync-video-storage-names", () => ({}));+vi.mock("@/lib/video-processing", () => ({}));+vi.mock("@/workflows/import-loom-video", () => ({}));+vi.mock("workflow/api", () => ({ start: vi.fn() }));+vi.mock("@cap/web-backend", async () => {+ const { Context } = await import("effect");+ const { Database } = await import(+ "../../../../packages/web-backend/src/Database"+ );+ return {+ Database,+ Videos: Context.GenericTag("mobile-comment-test/Videos"),+ ImageUploads: Context.GenericTag("mobile-comment-test/ImageUploads"),+ };+});++const user = {+ id: User.UserId.make("viewer"),+ email: "[email protected]",+ activeOrganizationId: Organisation.OrganisationId.make("organization"),+ iconUrlOrKey: Option.none(),+};+const videoId = Video.VideoId.make("accessible-video");+type Row = Record<string, unknown>;+let parents: Row[];+let inserted: Row[];+const dialect = new MySqlDialect();++function matchesParent(condition: SQL, row: Row) {+ const { sql, params } = dialect.sqlToQuery(condition);+ let index = 0;+ return sql+ .replaceAll(/[()]/g, "")+ .split(" and ")+ .every((clause) => {+ const match = /^`comments`\.`([^`]+)` = \?$/.exec(clause);+ if (!match?.[1]) throw new Error(`Unsupported predicate: ${clause}`);+ return row[match[1]] === params[index++];+ });+}++const database = {+ select: (columns?: Record<string, unknown>) => ({+ from: (table: MySqlTable) => {+ let condition: SQL;+ const result = () => {+ if (table === Db.users) return [{ preferences: {} }];+ if (table === Db.organizations)+ return [{ id: user.activeOrganizationId }];+ if (table === Db.videos) return [{ ownerId: user.id }];+ if (table !== Db.comments) throw new Error("Unexpected table");+ if (columns && Object.keys(columns).length === 1) {+ return parents.filter((row) => matchesParent(condition, row));+ }+ return inserted.map((row) => ({+ ...row,+ authorName: "Viewer",+ authorImage: null,+ authorPreferences: {},+ }));+ };+ const query = {+ leftJoin: () => query,+ innerJoin: () => query,+ where: (value: SQL) => {+ condition = value;+ return query;+ },+ limit: async () => result(),+ orderBy: async () => result(),+ };+ return query;+ },+ }),+ insert: (table: MySqlTable) => ({+ values: async (row: Row) => {+ if (table !== Db.comments) throw new Error("Unexpected insert");+ inserted.push(row);+ },+ }),+};++let dispose: () => Promise<void>;+vi.mock("@/lib/server", async () => {+ const { Videos, ImageUploads } = await import("@cap/web-backend");+ return {+ apiToHandler: (+ api: Layer.Layer<HttpApi.Api, never, Database | HttpAuthMiddleware>,+ ) => {+ const web = HttpApiBuilder.toWebHandler(+ api.pipe(+ Layer.provide(+ Layer.succeed(+ Database,+ Database.make({+ use: (callback) =>+ Effect.tryPromise({+ try: () => callback(database as unknown as DbClient),+ catch: (cause) => new DatabaseError({ cause }),+ }),+ }),+ ),+ ),+ Layer.provide(Layer.mock(Videos, { _tag: "Videos" })),+ Layer.provide(Layer.mock(ImageUploads, { _tag: "ImageUploads" })),+ Layer.provide(+ Layer.succeed(+ HttpAuthMiddleware,+ Effect.succeed(CurrentUser.of(user)),+ ),+ ),+ Layer.merge(HttpServer.layerContext),+ ),+ );+ dispose = web.dispose;+ return web.handler;+ },+ };+});++const { POST } = await import("@/app/api/mobile/[...route]/route");++function postComment(parentCommentId: string | null = "parent") {+ return POST(+ new Request(`http://localhost/api/mobile/caps/${videoId}/comments`, {+ method: "POST",+ headers: { "Content-Type": "application/json" },+ body: JSON.stringify({+ content: " A reply ",+ timestamp: null,+ parentCommentId,+ }),+ }),+ );+}++beforeEach(() => {+ parents = [{ id: "parent", videoId, type: "text" }];+ inserted = [];+ mocks.notify.mockClear();+});++afterAll(async () => {+ await dispose();+});++describe("mobile reply parent authorization", () => {+ it.each([+ {+ name: "belongs to another video",+ candidates: [{ id: "parent", videoId: "private-video", type: "text" }],+ },+ {+ name: "is not a text comment",+ candidates: [{ id: "parent", videoId, type: "emoji" }],+ },+ { name: "does not exist", candidates: [] },+ ])("rejects a parent that $name", async ({ candidates }) => {+ parents = candidates;+ const response = await postComment();+ expect(response.status).toBe(404);+ expect(inserted).toEqual([]);+ expect(mocks.notify).not.toHaveBeenCalled();+ });++ it("preserves replies to text comments on the accessible video", async () => {+ const response = await postComment();+ expect(response.status).toBe(200);+ expect(await response.json()).toMatchObject({+ content: "A reply",+ parentCommentId: "parent",+ videoId,+ });+ expect(inserted).toHaveLength(1);+ expect(mocks.notify).toHaveBeenCalledWith(+ expect.objectContaining({+ type: "reply",+ parentCommentId: "parent",+ videoId,+ }),+ );+ });++ it("preserves top-level comments", async () => {+ const response = await postComment(null);+ expect(response.status).toBe(200);+ expect(inserted).toHaveLength(1);+ expect(mocks.notify).toHaveBeenCalledWith(+ expect.objectContaining({ type: "comment" }),+ );+ });+});diff --git a/apps/web/app/api/mobile/[...route]/route.ts b/apps/web/app/api/mobile/[...route]/route.tsindex dd56af277..93e55bb63 100644--- a/apps/web/app/api/mobile/[...route]/route.ts+++ b/apps/web/app/api/mobile/[...route]/route.ts@@ -2111,6 +2111,22 @@ const createMobileComment = Effect.fn("Mobile.createComment")(function* ({const id = Comment.CommentId.make(nanoId());const now = new Date();const database = yield* Database;+ if (parentCommentId) {+ const [parent] = yield* database.use((db) =>+ db+ .select({ id: Db.comments.id })+ .from(Db.comments)+ .where(+ and(+ eq(Db.comments.id, parentCommentId),+ eq(Db.comments.videoId, videoId),+ eq(Db.comments.type, "text"),+ ),+ )+ .limit(1),+ );+ if (!parent) return yield* Effect.fail(new HttpApiError.NotFound());+ }yield* database.use((db) =>db.insert(Db.comments).values({id,