Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(media-server): keep NVENC on browser recordings that change size mid-stream

Richie McIlroydcd2c137eb62
diff --git a/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts b/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts
index d5516bb73..5892b6181 100644
--- a/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts
+++ b/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts
@@ -537,6 +537,8 @@ describe("process video args", () => {
"4",
"-fflags",
"+genpts",
+ "-reinit_filter",
+ "0",
"-i",
"in.webm",
...nvencVideoArgs,
diff --git a/apps/media-server/src/lib/media-video.ts b/apps/media-server/src/lib/media-video.ts
index f65a33d68..da16eceb2 100644
--- a/apps/media-server/src/lib/media-video.ts
+++ b/apps/media-server/src/lib/media-video.ts
@@ -1777,6 +1777,12 @@ export function buildProcessVideoArgs(input: ProcessVideoArgsInput): string[] {
)
: []),
...input.extraInputArgs,
+ // Browser captures change size when the tab resizes. Rebuilding the filter graph for that crashes h264_nvenc
+ // (SIGSEGV on FFmpeg 7.1, even with a fixed output size), so keep the first graph; scale absorbs the new size
+ // exactly as the libx264 fallback's auto-inserted scaler does.
+ ...(nvenc && !gpuDecode && input.videoTranscode && !input.normalizeH264Level
+ ? ["-reinit_filter", "0"]
+ : []),
"-i",
input.inputPath,
];