Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

test(verify): drop the Instant system-on-mic-timeline bound test and measures with its xfail

Richie McIlroydf1204d14be2
diff --git a/crates/verify/src/report.rs b/crates/verify/src/report.rs
index c35b36d83..102002911 100644
--- a/crates/verify/src/report.rs
+++ b/crates/verify/src/report.rs
@@ -645,43 +645,4 @@ mod tests {
Some("track absent")
);
}
- #[test]
- fn instant_system_audio_expectation_requires_the_microphone_timeline() {
- let entries = cap_verify_expect::parse(include_str!("../expectations.toml")).unwrap();
- let entries: Vec<_> = entries
- .iter()
- .filter(|entry| {
- entry.class == "sync-system" && entry.case == "export/instant/output/mp4/native"
- })
- .collect();
- assert_eq!(entries.len(), 1);
- assert!(!entries[0].flaky);
- let metrics = |offset: f64, mic: f64| {
- BTreeMap::from([
- ("count".into(), cap_verify_expect::Range::at(1.0)),
- ("offset-ms".into(), cap_verify_expect::Range::at(offset)),
- ("mic-offset-ms".into(), cap_verify_expect::Range::at(mic)),
- (
- "system-minus-mic-ms".into(),
- cap_verify_expect::Range::at(((offset - mic) * 10.0_f64).round() / 10.0),
- ),
- ])
- };
- let accepts = |metrics: &BTreeMap<String, cap_verify_expect::Range>| {
- cap_verify_expect::within(&entries[0].bound, Some(metrics)).is_ok()
- };
- for (offset, mic) in [(14.0, 14.0), (13.3, 13.3), (15.4, 15.0)] {
- assert!(accepts(&metrics(offset, mic)));
- }
- // The -60 ms and -6.7 ms mixer modes, and system audio off the mic.
- for (offset, mic) in [(-46.1, 13.9), (7.8, 14.5), (16.0, 14.5), (14.0, 35.0)] {
- assert!(!accepts(&metrics(offset, mic)));
- }
- let mut absent = metrics(14.0, 14.0);
- absent.remove("system-minus-mic-ms");
- assert!(!accepts(&absent));
- for platform in ["macos", "windows", "linux"] {
- assert!(entries[0].matches("export/instant/output/mp4/native", platform));
- }
- }
}
diff --git a/crates/verify/tests/export.rs b/crates/verify/tests/export.rs
index 46d062216..a4080e834 100644
--- a/crates/verify/tests/export.rs
+++ b/crates/verify/tests/export.rs
@@ -654,7 +654,6 @@ fn instant_case(spec: cap_verify::pipeline::InstantSpec) -> Option<String> {
}
let audio = media::decode_audio(&output, None).expect("decode instant audio");
let mono = audio.mono();
- let mut mic_offset_ms = None;
for source in [AudioSource::Mic, AudioSource::System] {
let expected: Vec<(u32, f64)> = emitted
.audio
@@ -795,21 +794,7 @@ fn instant_case(spec: cap_verify::pipeline::InstantSpec) -> Option<String> {
),
);
}
- if source == AudioSource::Mic {
- mic_offset_ms = Some((av * 1e4).round() / 10.0);
- }
if av.abs() > 0.005 {
- if source == AudioSource::System
- && case.id == "export/instant/output/mp4/native"
- && let Some(mic_offset_ms) = mic_offset_ms
- {
- case.measure(&sync_class, "mic-offset-ms", mic_offset_ms);
- case.measure(
- &sync_class,
- "system-minus-mic-ms",
- ((av * 1e3 - mic_offset_ms) * 10.0).round() / 10.0,
- );
- }
case.measure(&sync_class, "offset-ms", (av * 1e4).round() / 10.0);
case.problem(
&sync_class,