The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.
Forward node class attributes into schema for dataset nodes (#15683)
Christian Byrne0d80858061b5
diff --git a/comfy_extras/nodes_dataset.py b/comfy_extras/nodes_dataset.pyindex 71e5ee368..5ca5a8e14 100644--- a/comfy_extras/nodes_dataset.py+++ b/comfy_extras/nodes_dataset.py@@ -692,6 +692,7 @@ class ImageProcessingNode(io.ComfyNode):category=cls.category,description=cls.description,is_experimental=True,+ is_deprecated=cls.is_deprecated,is_input_list=is_group, # True for group, False for individualinputs=inputs,outputs=[@@ -861,9 +862,12 @@ class TextProcessingNode(io.ComfyNode):return io.Schema(node_id=cls.node_id,+ search_aliases=cls.search_aliases,display_name=cls.display_name or cls.node_id,category="text",+ description=cls.description,is_experimental=True,+ is_deprecated=cls.is_deprecated,is_input_list=is_group, # True for group, False for individualinputs=inputs,outputs=[diff --git a/tests-unit/comfy_extras_test/nodes_dataset_test.py b/tests-unit/comfy_extras_test/nodes_dataset_test.pynew file mode 100644index 000000000..0fb0b8c9b--- /dev/null+++ b/tests-unit/comfy_extras_test/nodes_dataset_test.py@@ -0,0 +1,56 @@+"""Tests that dataset node config declared as class attributes reaches the schema.++``ImageProcessingNode`` and ``TextProcessingNode`` let subclasses configure+themselves with plain class attributes, and their shared ``define_schema()`` is+what forwards those attributes into ``io.Schema``. Anything it forgets to+forward is silently dropped from /object_info, so this pins the forwarding+itself rather than any single field.+"""++import dataclasses++import pytest++from comfy_api.latest import io+from comfy_extras import nodes_dataset++# Structural schema members, not per-node config; a node class would never+# declare these as class attributes.+IGNORED_FIELDS = {"inputs", "outputs", "hidden", "node_id"}++SCHEMA_FIELDS = [+ f.name for f in dataclasses.fields(io.Schema) if f.name not in IGNORED_FIELDS+]+++def _node_classes():+ """Every concrete node defined in nodes_dataset."""+ found = []+ for obj in vars(nodes_dataset).values():+ if not isinstance(obj, type) or not issubclass(obj, io.ComfyNode):+ continue+ if obj.__module__ != nodes_dataset.__name__:+ continue+ if getattr(obj, "node_id", "") is None:+ continue # abstract base class, define_schema() would raise+ found.append(obj)+ return sorted(found, key=lambda c: c.__name__)++[email protected]("node_cls", _node_classes(), ids=lambda c: c.__name__)+def test_class_attributes_are_forwarded_to_schema(node_cls):+ schema = node_cls.define_schema()+ for name in SCHEMA_FIELDS:+ declared = getattr(node_cls, name, None)+ if not declared:+ continue # unset, or left at the base class default+ assert getattr(schema, name) == declared, (+ f"{node_cls.__name__}.{name} is not forwarded into io.Schema by "+ f"define_schema(), so /object_info reports "+ f"{name}={getattr(schema, name)!r} instead of {declared!r}"+ )+++def test_node_classes_are_discovered():+ """Guard against the parametrization above collapsing to zero cases."""+ assert _node_classes()