Skip to content

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.

Fix uncaught OverflowError in Math Expression node for large int results (#14214)

vidigoat33799c4a2ee2
diff --git a/comfy_extras/nodes_math.py b/comfy_extras/nodes_math.py
index 873ee7b51..0883c65ac 100644
--- a/comfy_extras/nodes_math.py
+++ b/comfy_extras/nodes_math.py
@@ -102,11 +102,18 @@ class MathExpressionNode(io.ComfyNode):
f"Math Expression '{expression}' must evaluate to a numeric result, "
f"got {type(result).__name__}: {result!r}"
)
- if not math.isfinite(result):
+ try:
+ float_result = float(result)
+ except OverflowError:
+ raise ValueError(
+ f"Math Expression '{expression}' produced a result too large to "
+ f"represent as a float: {result}"
+ ) from None
+ if not math.isfinite(float_result):
raise ValueError(
f"Math Expression '{expression}' produced a non-finite result: {result}"
)
- return io.NodeOutput(float(result), int(result), bool(result))
+ return io.NodeOutput(float_result, int(result), bool(result))
class MathExtension(ComfyExtension):
diff --git a/tests-unit/comfy_extras_test/nodes_math_test.py b/tests-unit/comfy_extras_test/nodes_math_test.py
index 714e37c32..030accc5e 100644
--- a/tests-unit/comfy_extras_test/nodes_math_test.py
+++ b/tests-unit/comfy_extras_test/nodes_math_test.py
@@ -197,3 +197,10 @@ class TestMathExpressionExecute:
def test_pow_huge_exponent_raises(self):
with pytest.raises(ValueError, match="Exponent .* exceeds maximum"):
self._exec("pow(a, b)", a=10, b=10000000)
+
+ def test_huge_int_result_raises_value_error(self):
+ # Exponent is within the allowed MAX_EXPONENT range, so the result is a
+ # finite Python int that is nonetheless too large to convert to float.
+ # This must raise a clean ValueError, not an uncaught OverflowError.
+ with pytest.raises(ValueError, match="too large to represent as a float"):
+ self._exec("2 ** 3999")