Skip to content

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.

Improvements to the stable release workflow. (#10065)

comfyanonymous40ae495ddcbc
diff --git a/.github/workflows/stable-release.yml b/.github/workflows/stable-release.yml
index 2bc8e5905..b39b42acd 100644
--- a/.github/workflows/stable-release.yml
+++ b/.github/workflows/stable-release.yml
@@ -8,11 +8,11 @@ on:
description: 'Git tag'
required: true
type: string
- cu:
- description: 'CUDA version'
+ cache_tag:
+ description: 'Cached dependencies tag'
required: true
type: string
- default: "129"
+ default: "cu129"
python_minor:
description: 'Python minor version'
required: true
@@ -23,7 +23,11 @@ on:
required: true
type: string
default: "6"
-
+ rel_name:
+ description: 'Release name'
+ required: true
+ type: string
+ default: "nvidia"
jobs:
package_comfy_windows:
@@ -42,15 +46,15 @@ jobs:
id: cache
with:
path: |
- cu${{ inputs.cu }}_python_deps.tar
+ ${{ inputs.cache_tag }}_python_deps.tar
update_comfyui_and_python_dependencies.bat
- key: ${{ runner.os }}-build-cu${{ inputs.cu }}-${{ inputs.python_minor }}
+ key: ${{ runner.os }}-build-${{ inputs.cache_tag }}-${{ inputs.python_minor }}
- shell: bash
run: |
- mv cu${{ inputs.cu }}_python_deps.tar ../
+ mv ${{ inputs.cache_tag }}_python_deps.tar ../
mv update_comfyui_and_python_dependencies.bat ../
cd ..
- tar xf cu${{ inputs.cu }}_python_deps.tar
+ tar xf ${{ inputs.cache_tag }}_python_deps.tar
pwd
ls
@@ -65,12 +69,19 @@ jobs:
echo 'import site' >> ./python3${{ inputs.python_minor }}._pth
curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
./python.exe get-pip.py
- ./python.exe -s -m pip install ../cu${{ inputs.cu }}_python_deps/*
+ ./python.exe -s -m pip install ../${{ inputs.cache_tag }}_python_deps/*
+
+ grep comfyui ../ComfyUI/requirements.txt ./requirements_comfyui.txt
+ ./python.exe -s -m pip install -r requirements_comfyui.txt
+ rm requirements_comfyui.txt
+
sed -i '1i../ComfyUI' ./python3${{ inputs.python_minor }}._pth
- rm ./Lib/site-packages/torch/lib/dnnl.lib #I don't think this is actually used and I need the space
- rm ./Lib/site-packages/torch/lib/libprotoc.lib
- rm ./Lib/site-packages/torch/lib/libprotobuf.lib
+ if test -f ./Lib/site-packages/torch/lib/dnnl.lib; then
+ rm ./Lib/site-packages/torch/lib/dnnl.lib #I don't think this is actually used and I need the space
+ rm ./Lib/site-packages/torch/lib/libprotoc.lib
+ rm ./Lib/site-packages/torch/lib/libprotobuf.lib
+ fi
cd ..
@@ -91,7 +102,7 @@ jobs:
cd ..
"C:\Program Files\7-Zip\7z.exe" a -t7z -m0=lzma2 -mx=9 -mfb=128 -md=768m -ms=on -mf=BCJ2 ComfyUI_windows_portable.7z ComfyUI_windows_portable
- mv ComfyUI_windows_portable.7z ComfyUI/ComfyUI_windows_portable_nvidia.7z
+ mv ComfyUI_windows_portable.7z ComfyUI/ComfyUI_windows_portable_${{ inputs.rel_name }}.7z
cd ComfyUI_windows_portable
python_embeded/python.exe -s ComfyUI/main.py --quick-test-for-ci --cpu
@@ -104,7 +115,7 @@ jobs:
uses: svenstaro/upload-release-action@v2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
- file: ComfyUI_windows_portable_nvidia.7z
+ file: ComfyUI_windows_portable_${{ inputs.rel_name }}.7z
tag: ${{ inputs.git_tag }}
overwrite: true
draft: true
diff --git a/.github/workflows/windows_release_dependencies.yml b/.github/workflows/windows_release_dependencies.yml
index 7761cc1ed..f1e2946e6 100644
--- a/.github/workflows/windows_release_dependencies.yml
+++ b/.github/workflows/windows_release_dependencies.yml
@@ -56,7 +56,8 @@ jobs:
..\python_embeded\python.exe -s -m pip install --upgrade torch torchvision torchaudio ${{ inputs.xformers }} --extra-index-url https://download.pytorch.org/whl/cu${{ inputs.cu }} -r ../ComfyUI/requirements.txt pygit2
pause" > update_comfyui_and_python_dependencies.bat
- python -m pip wheel --no-cache-dir torch torchvision torchaudio ${{ inputs.xformers }} ${{ inputs.extra_dependencies }} --extra-index-url https://download.pytorch.org/whl/cu${{ inputs.cu }} -r requirements.txt pygit2 -w ./temp_wheel_dir
+ grep -v comfyui requirements.txt > requirements_nocomfyui.txt
+ python -m pip wheel --no-cache-dir torch torchvision torchaudio ${{ inputs.xformers }} ${{ inputs.extra_dependencies }} --extra-index-url https://download.pytorch.org/whl/cu${{ inputs.cu }} -r requirements_nocomfyui.txt pygit2 -w ./temp_wheel_dir
python -m pip install --no-cache-dir ./temp_wheel_dir/*
echo installed basic
ls -lah temp_wheel_dir