Skip to content

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.

Native block swap custom nodes considered harmful. (#10783)

comfyanonymous47bfd5a33fa9
diff --git a/comfy_extras/nodes_nop.py b/comfy_extras/nodes_nop.py
new file mode 100644
index 000000000..953061bcb
--- /dev/null
+++ b/comfy_extras/nodes_nop.py
@@ -0,0 +1,39 @@
+from comfy_api.latest import ComfyExtension, io
+from typing_extensions import override
+# If you write a node that is so useless that it breaks ComfyUI it will be featured in this exclusive list
+
+# "native" block swap nodes are placebo at best and break the ComfyUI memory management system.
+# They are also considered harmful because instead of users reporting issues with the built in
+# memory management they install these stupid nodes and complain even harder. Now it completely
+# breaks with some of the new ComfyUI memory optimizations so I have made the decision to NOP it
+# out of all workflows.
+class wanBlockSwap(io.ComfyNode):
+ @classmethod
+ def define_schema(cls):
+ return io.Schema(
+ node_id="wanBlockSwap",
+ category="",
+ description="NOP",
+ inputs=[
+ io.Model.Input("model"),
+ ],
+ outputs=[
+ io.Model.Output(),
+ ],
+ is_deprecated=True,
+ )
+
+ @classmethod
+ def execute(cls, model) -> io.NodeOutput:
+ return io.NodeOutput(model)
+
+
+class NopExtension(ComfyExtension):
+ @override
+ async def get_node_list(self) -> list[type[io.ComfyNode]]:
+ return [
+ wanBlockSwap
+ ]
+
+async def comfy_entrypoint() -> NopExtension:
+ return NopExtension()
diff --git a/nodes.py b/nodes.py
index 5689f6fe1..f6aeedc78 100644
--- a/nodes.py
+++ b/nodes.py
@@ -2330,6 +2330,7 @@ async def init_builtin_extra_nodes():
"nodes_easycache.py",
"nodes_audio_encoder.py",
"nodes_rope.py",
+ "nodes_nop.py",
]
import_failed = []