The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.
fix(api-nodes): enable more pylint rules (#10213)
Alexander Piskun6ae35158013e
diff --git a/comfy_api_nodes/apinode_utils.py b/comfy_api_nodes/apinode_utils.pyindex 37438f835..5ac3b92aa 100644--- a/comfy_api_nodes/apinode_utils.py+++ b/comfy_api_nodes/apinode_utils.py@@ -152,7 +152,7 @@ def validate_aspect_ratio(raise TypeError(f"Aspect ratio cannot reduce to any less than {minimum_ratio_str} ({minimum_ratio}), but was {aspect_ratio} ({calculated_ratio}).")- elif calculated_ratio > maximum_ratio:+ if calculated_ratio > maximum_ratio:raise TypeError(f"Aspect ratio cannot reduce to any greater than {maximum_ratio_str} ({maximum_ratio}), but was {aspect_ratio} ({calculated_ratio}).")diff --git a/comfy_api_nodes/nodes_moonvalley.py b/comfy_api_nodes/nodes_moonvalley.pyindex 6467dd614..55471a69d 100644--- a/comfy_api_nodes/nodes_moonvalley.py+++ b/comfy_api_nodes/nodes_moonvalley.py@@ -473,7 +473,7 @@ class MoonvalleyImg2VideoNode(comfy_io.ComfyNode):height=width_height["height"],use_negative_prompts=True,)- """Upload image to comfy backend to have a URL available for further processing"""+# Get MIME type from tensor - assuming PNG format for image tensorsmime_type = "image/png"@@ -591,7 +591,6 @@ class MoonvalleyVideo2VideoNode(comfy_io.ComfyNode):validated_video = validate_video_to_video_input(video)video_url = await upload_video_to_comfyapi(validated_video, auth_kwargs=auth)- """Validate prompts and inference input"""validate_prompts(prompt, negative_prompt)# Only include motion_intensity for Motion Transferdiff --git a/comfy_api_nodes/nodes_recraft.py b/comfy_api_nodes/nodes_recraft.pyindex a006104b7..0bbb551b8 100644--- a/comfy_api_nodes/nodes_recraft.py+++ b/comfy_api_nodes/nodes_recraft.py@@ -107,7 +107,7 @@ def recraft_multipart_parser(data, parent_key=None, formatter: callable=None, co# if list already exists exists, just extend list with datafor check_list in lists_to_check:for conv_tuple in check_list:- if conv_tuple[0] == parent_key and type(conv_tuple[1]) is list:+ if conv_tuple[0] == parent_key and isinstance(conv_tuple[1], list):conv_tuple[1].append(formatter(data))return Truereturn False@@ -119,7 +119,7 @@ def recraft_multipart_parser(data, parent_key=None, formatter: callable=None, coif formatter is None:formatter = lambda v: v # Multipart representation of value- if type(data) is not dict:+ if not isinstance(data, dict):# if list already exists exists, just extend list with dataadded = handle_converted_lists(data, parent_key, converted_to_check)if added:@@ -136,9 +136,9 @@ def recraft_multipart_parser(data, parent_key=None, formatter: callable=None, cofor key, value in data.items():current_key = key if parent_key is None else f"{parent_key}[{key}]"- if type(value) is dict:+ if isinstance(value, dict):converted.extend(recraft_multipart_parser(value, current_key, formatter, next_check).items())- elif type(value) is list:+ elif isinstance(value, list):for ind, list_value in enumerate(value):iter_key = f"{current_key}[]"converted.extend(recraft_multipart_parser(list_value, iter_key, formatter, next_check, is_list=True).items())diff --git a/pyproject.toml b/pyproject.tomlindex a9e3de0c6..abd1a5f5c 100644--- a/pyproject.toml+++ b/pyproject.toml@@ -57,18 +57,14 @@ messages_control.disable = ["redefined-builtin","unnecessary-lambda","dangerous-default-value",+ "invalid-overridden-method",# next warnings should be fixed in future"bad-classmethod-argument", # Class method should have 'cls' as first argument"wrong-import-order", # Standard imports should be placed before third party imports"logging-fstring-interpolation", # Use lazy % formatting in logging functions"ungrouped-imports","unnecessary-pass",- "unidiomatic-typecheck","unnecessary-lambda-assignment","no-else-return",- "no-else-raise",- "invalid-overridden-method","unused-variable",- "pointless-string-statement",- "redefined-outer-name",]