Skip to content

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.

Add Boolean support to Math Expression Node (#13224)

LaVie02495f6652ef5e9
diff --git a/comfy_extras/nodes_math.py b/comfy_extras/nodes_math.py
index 8f6e687d2..6030ee9d8 100644
--- a/comfy_extras/nodes_math.py
+++ b/comfy_extras/nodes_math.py
@@ -63,7 +63,7 @@ class MathExpressionNode(io.ComfyNode):
@classmethod
def define_schema(cls) -> io.Schema:
autogrow = io.Autogrow.TemplateNames(
- input=io.MultiType.Input("value", [io.Float, io.Int]),
+ input=io.MultiType.Input("value", [io.Float, io.Int, io.Boolean]),
names=list(string.ascii_lowercase),
min=1,
)
@@ -82,6 +82,7 @@ class MathExpressionNode(io.ComfyNode):
outputs=[
io.Float.Output(display_name="FLOAT"),
io.Int.Output(display_name="INT"),
+ io.Boolean.Output(display_name="BOOL"),
],
)
@@ -97,7 +98,7 @@ class MathExpressionNode(io.ComfyNode):
result = simple_eval(expression, names=context, functions=MATH_FUNCTIONS)
# bool check must come first because bool is a subclass of int in Python
- if isinstance(result, bool) or not isinstance(result, (int, float)):
+ if not isinstance(result, (int, float)):
raise ValueError(
f"Math Expression '{expression}' must evaluate to a numeric result, "
f"got {type(result).__name__}: {result!r}"
@@ -106,7 +107,7 @@ class MathExpressionNode(io.ComfyNode):
raise ValueError(
f"Math Expression '{expression}' produced a non-finite result: {result}"
)
- return io.NodeOutput(float(result), int(result))
+ return io.NodeOutput(float(result), int(result), bool(result))
class MathExtension(ComfyExtension):
diff --git a/tests-unit/comfy_extras_test/nodes_math_test.py b/tests-unit/comfy_extras_test/nodes_math_test.py
index fa4cdcac3..714e37c32 100644
--- a/tests-unit/comfy_extras_test/nodes_math_test.py
+++ b/tests-unit/comfy_extras_test/nodes_math_test.py
@@ -124,9 +124,11 @@ class TestMathExpressionExecute:
with pytest.raises(Exception, match="not defined"):
self._exec("str(a)", a=42)
- def test_boolean_result_raises(self):
- with pytest.raises(ValueError, match="got bool"):
- self._exec("a > b", a=5, b=3)
+ def test_boolean_result(self):
+ result = self._exec("a > b", a=5, b=3)
+ assert result[2] is True
+ result = self._exec("a > b", a=3, b=5)
+ assert result[2] is False
def test_empty_expression_raises(self):
with pytest.raises(ValueError, match="Expression cannot be empty"):