Skip to content

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.

Use the cached frontend for pinned versions without a v prefix. (#17348)

Christian Byrneafa6461c182d
diff --git a/app/frontend_management.py b/app/frontend_management.py
index 2671759dd..5683aefe7 100644
--- a/app/frontend_management.py
+++ b/app/frontend_management.py
@@ -375,7 +375,7 @@ comfyui-workflow-templates is not installed.
repo_owner, repo_name, version = cls.parse_version_string(version_string)
- if version.startswith("v"):
+ if version not in ("latest", "prerelease"):
expected_path = str(
Path(cls.CUSTOM_FRONTENDS_ROOT)
/ f"{repo_owner}_{repo_name}"
diff --git a/tests-unit/app_test/frontend_manager_test.py b/tests-unit/app_test/frontend_manager_test.py
index 45f065488..8f26598c8 100644
--- a/tests-unit/app_test/frontend_manager_test.py
+++ b/tests-unit/app_test/frontend_manager_test.py
@@ -130,6 +130,21 @@ def test_finally_block(mock_os_functions, mock_download, mock_provider):
mock_rmdir.assert_called_once()
[email protected]("version", ["1.0.0", "v1.0.0"])
+def test_init_frontend_uses_cached_version(tmp_path, version):
+ cached = tmp_path / "test-owner_test-repo" / "1.0.0"
+ cached.mkdir(parents=True)
+
+ with (
+ patch.object(FrontendManager, "CUSTOM_FRONTENDS_ROOT", str(tmp_path)),
+ patch.object(FrontEndProvider, "get_release", side_effect=HTTPError("403 rate limit exceeded")),
+ patch.object(FrontendManager, "default_frontend_path", return_value="/default/path"),
+ ):
+ frontend_path = FrontendManager.init_frontend(f"test-owner/test-repo@{version}")
+
+ assert frontend_path == str(cached)
+
+
def test_parse_version_string():
version_string = "owner/[email protected]"
repo_owner, repo_name, version = FrontendManager.parse_version_string(