The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.
Add TLS Support (#3312)
Garrett Sutulabacce529fbed
diff --git a/README.md b/README.mdindex d392cd802..eb07540cc 100644--- a/README.md+++ b/README.md@@ -207,6 +207,14 @@ Use ```--preview-method auto``` to enable previews.The default installation includes a fast latent preview method that's low-resolution. To enable higher-quality previews with [TAESD](https://github.com/madebyollin/taesd), download the [taesd_decoder.pth](https://github.com/madebyollin/taesd/raw/main/taesd_decoder.pth) (for SD1.x and SD2.x) and [taesdxl_decoder.pth](https://github.com/madebyollin/taesd/raw/main/taesdxl_decoder.pth) (for SDXL) models and place them in the `models/vae_approx` folder. Once they're installed, restart ComfyUI to enable high-quality previews.+## How to use TLS/SSL?+Generate a self-signed certificate (not appropriate for shared/production use) and key by running the command: `openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -sha256 -days 3650 -nodes -subj "/C=XX/ST=StateName/L=CityName/O=CompanyName/OU=CompanySectionName/CN=CommonNameOrHostname"`++Use `--tls-keyfile key.pem --tls-certfile cert.pem` to enable TLS/SSL, the app will now be accessible with `https://...` instead of `http://...`.++> Note: Windows users can use [alexisrolland/docker-openssl](https://github.com/alexisrolland/docker-openssl) or one of the [3rd party binary distributions](https://wiki.openssl.org/index.php/Binaries) to run the command example above.+<br/><br/>If you use a container, note that the volume mount `-v` can be a relative path so `... -v ".\:/openssl-certs" ...` would create the key & cert files in the current directory of your command prompt or powershell terminal.+## Support and dev channel[Matrix space: #comfyui_space:matrix.org](https://app.element.io/#/room/%23comfyui_space%3Amatrix.org) (it's like discord but open source).diff --git a/comfy/cli_args.py b/comfy/cli_args.pyindex 353bb51e7..569c79380 100644--- a/comfy/cli_args.py+++ b/comfy/cli_args.py@@ -35,6 +35,8 @@ parser = argparse.ArgumentParser()parser.add_argument("--listen", type=str, default="127.0.0.1", metavar="IP", nargs="?", const="0.0.0.0", help="Specify the IP address to listen on (default: 127.0.0.1). If --listen is provided without an argument, it defaults to 0.0.0.0. (listens on all)")parser.add_argument("--port", type=int, default=8188, help="Set the listen port.")+parser.add_argument("--tls-keyfile", type=str, help="Path to TLS (SSL) key file. Enables TLS, makes app accessible at https://... requires --tls-certfile to function")+parser.add_argument("--tls-certfile", type=str, help="Path to TLS (SSL) certificate file. Enables TLS, makes app accessible at https://... requires --tls-keyfile to function")parser.add_argument("--enable-cors-header", type=str, default=None, metavar="ORIGIN", nargs="?", const="*", help="Enable CORS (Cross-Origin Resource Sharing) with optional origin or allow all with default '*'.")parser.add_argument("--max-upload-size", type=float, default=100, help="Set the maximum upload size in MB.")diff --git a/main.py b/main.pyindex b3a3ebea8..a374f2b12 100644--- a/main.py+++ b/main.py@@ -243,11 +243,11 @@ if __name__ == "__main__":call_on_start = Noneif args.auto_launch:- def startup_server(address, port):+ def startup_server(scheme, address, port):import webbrowserif os.name == 'nt' and address == '0.0.0.0':address = '127.0.0.1'- webbrowser.open(f"http://{address}:{port}")+ webbrowser.open(f"{scheme}://{address}:{port}")call_on_start = startup_servertry:diff --git a/server.py b/server.pyindex 5642bd5e2..bab3b0600 100644--- a/server.py+++ b/server.py@@ -11,6 +11,7 @@ import urllibimport jsonimport globimport struct+import sslfrom PIL import Image, ImageOpsfrom PIL.PngImagePlugin import PngInfofrom io import BytesIO@@ -623,14 +624,22 @@ class PromptServer():async def start(self, address, port, verbose=True, call_on_start=None):runner = web.AppRunner(self.app, access_log=None)await runner.setup()- site = web.TCPSite(runner, address, port)+ ssl_ctx = None+ scheme = "http"+ if args.tls_keyfile and args.tls_certfile:+ ssl_ctx = ssl.SSLContext(protocol=ssl.PROTOCOL_TLS_SERVER, verify_mode=ssl.CERT_NONE)+ ssl_ctx.load_cert_chain(certfile=args.tls_certfile,+ keyfile=args.tls_keyfile)+ scheme = "https"++ site = web.TCPSite(runner, address, port, ssl_context=ssl_ctx)await site.start()if verbose:logging.info("Starting server\n")- logging.info("To see the GUI go to: http://{}:{}".format(address, port))+ logging.info("To see the GUI go to: {}://{}:{}".format(scheme, address, port))if call_on_start is not None:- call_on_start(address, port)+ call_on_start(scheme, address, port)def add_on_prompt_handler(self, handler):self.on_prompt_handlers.append(handler)