The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface. The fastest local inference engine in the world.
Log typed asset scanner filesystem errors (#16096)
Christian Byrned43a5fa20c85
diff --git a/app/assets/scanner.py b/app/assets/scanner.pyindex 0db7588de..64d169c49 100644--- a/app/assets/scanner.py+++ b/app/assets/scanner.py@@ -61,6 +61,13 @@ class _AssetAccumulator(TypedDict):RootType = Literal["models", "input", "output"]+def _log_scan_error(phase: str, error: OSError) -> None:+ error_type = (+ "permission_denied" if isinstance(error, PermissionError) else "os_error"+ )+ logging.warning("Asset scan error: phase=%s error_type=%s", phase, error_type)++def get_scan_prefixes_for_root(root: RootType) -> list[str]:if root == "models":bases: list[str] = []@@ -168,11 +175,13 @@ def sync_prefixes_with_filesystem()except FileNotFoundError:exists = False- except PermissionError:+ except PermissionError as e:exists = True+ _log_scan_error("reference_stat", e)logging.debug("Permission denied accessing %s", row.file_path)except OSError as e:exists = False+ _log_scan_error("reference_stat", e)logging.debug("OSError checking %s: %s", row.file_path, e)acc["refs"].append(@@ -332,7 +341,10 @@ def build_asset_specs(continuetry:stat_p = os.stat(abs_p, follow_symlinks=True)- except OSError:+ except FileNotFoundError:+ continue+ except OSError as e:+ _log_scan_error("discovery_stat", e)continueif not stat_p.st_size:continue@@ -455,7 +467,10 @@ def enrich_asset(try:stat_p = os.stat(file_path, follow_symlinks=True)- except OSError:+ except FileNotFoundError:+ return new_level+ except OSError as e:+ _log_scan_error("enrichment_stat", e)return new_levelinitial_mtime_ns = get_mtime_ns(stat_p)@@ -520,7 +535,10 @@ def enrich_asset(if metadata_ok:new_level = ENRICHMENT_HASHEDexcept Exception as e:- logging.warning("Failed to hash %s: %s", file_path, e)+ if isinstance(e, OSError):+ _log_scan_error("hashing", e)+ else:+ logging.warning("Failed to hash %s: %s", file_path, e)# Optimistic guard: if the reference's mtime_ns changed since we# started (e.g. ingest_existing_file updated it), our results arediff --git a/tests-unit/assets_test/services/test_bulk_ingest.py b/tests-unit/assets_test/services/test_bulk_ingest.pyindex a3889f235..ef4b54dfb 100644--- a/tests-unit/assets_test/services/test_bulk_ingest.py+++ b/tests-unit/assets_test/services/test_bulk_ingest.py@@ -1,5 +1,6 @@"""Tests for bulk ingest services."""+import loggingimport osfrom pathlib import Pathfrom unittest.mock import patch@@ -13,6 +14,25 @@ from app.assets.services.bulk_ingest import SeedAssetSpec, batch_insert_seed_assclass TestBatchInsertSeedAssets:+ def test_locked_file_logs_typed_error_without_path(self, caplog):+ locked_path = "/private/user/models/locked.safetensors"++ with (+ patch(+ "app.assets.scanner.os.stat", side_effect=PermissionError(locked_path)+ ),+ caplog.at_level(logging.WARNING),+ ):+ specs, tags, skipped = build_asset_specs([locked_path], set())++ assert specs == []+ assert tags == set()+ assert skipped == 0+ assert caplog.messages == [+ "Asset scan error: phase=discovery_stat error_type=permission_denied"+ ]+ assert locked_path not in caplog.text+def test_populates_mime_type_for_model_files(self, session: Session, temp_dir: Path):"""Verify mime_type is stored in the Asset table for model files."""file_path = temp_dir / "model.safetensors"