The truly free, open-source, local-first, cross-platform CapCut replacement. Scriptable through a JSON-RPC API & MCP.
Rust ffmpegfree-video-editormodel-context-protocolnon-linear-editoroffline-firstopen-source-video-editorself-hostedvideo-editingvideo-editing-automationvideo-editing-softwarevideo-editing-toolsvideo-editorvoice-cloningyoutube-automationyoutube-shorts
ci: every bundled library is checked against the OS its bundle declares, and Intel Macs declare 13.4 (#333)
Jareer414acc3ec666
diff --git a/.github/workflows/build-app.yml b/.github/workflows/build-app.ymlindex 75651847..a9aea66c 100644--- a/.github/workflows/build-app.yml+++ b/.github/workflows/build-app.yml@@ -97,8 +97,9 @@ env:ORT_INTEL_MAC_VERSION: 1.23.2# WiX for the Windows .msi, as a dotnet tool, pinned by version.WIX_VERSION: 6.0.2- # Oldest macOS the bundles run on. Apple silicon Macs all run newer than- # this; it is the Intel floor.+ # Oldest macOS the bundles run on, unless a target sets its own+ # (`macos-min` below): Apple silicon's. scripts/ci/check-min-os.sh lists+ # every bundled library built for a newer one.MACOSX_DEPLOYMENT_TARGET: "12.0"# ggml (whisper.cpp's kernels) tunes itself to the machine it is built# on unless told otherwise, and these bundles run on other machines: a@@ -137,6 +138,9 @@ jobs:os: macos-15-inteltarget: x86_64-apple-darwinsherpa: osx-x64+ # The ONNX Runtime it ships (1.23.2, the last for Intel Macs)+ # is built for 13.4 and dies at launch on 12 (#333).+ macos-min: "13.4"# 22.04, not latest: the binary links the build machine's glibc,# so the oldest supported runner is what keeps it runnable on# older distributions.@@ -180,6 +184,8 @@ jobs:# at most 155 minutes between them on any one target, so a stuck step# is named by its own timeout; this is for a job stuck anywhere else.timeout-minutes: 190+ env:+ MACOSX_DEPLOYMENT_TARGET: ${{ matrix.macos-min || '12.0' }}steps:# The ref release.yml names, which is its tag: without one a run# started by hand builds main and publishes it under the tag's name.@@ -604,6 +610,12 @@ jobs:exit 1fi+ # Every library in the bundle against the floor it declares. A+ # warning for now: Homebrew's FFmpeg is built for the runner's+ # macOS, so every Mac bundle has some until FFmpeg is built here+ # for the floor.+ scripts/ci/check-min-os.sh "$app" "$MACOSX_DEPLOYMENT_TARGET"+# Signed with the repository's Developer ID when it has one, and# notarised so Gatekeeper opens it without a warning; ad-hoc signed# otherwise, which is what a fork's build gets. Either way thediff --git a/.github/workflows/mobile.yml b/.github/workflows/mobile.ymlindex 97525979..aa5d9024 100644--- a/.github/workflows/mobile.yml+++ b/.github/workflows/mobile.yml@@ -402,6 +402,13 @@ jobs:- name: Bundlerun: src/scripts/ios-app.sh aarch64-apple-ios release+ # Every framework in the app against the iOS it declares (#294). A+ # warning until a run has shown what is there.+ - name: Minimum iOS of everything in the app+ run: |+ app=src/target/aarch64-apple-ios/release/Concat.app+ scripts/ci/check-min-os.sh "$app" "$(/usr/libexec/PlistBuddy -c 'Print :MinimumOSVersion' "$app/Info.plist")"+# An .ipa is the bundle under Payload/ in a zip: the form every# sideloading tool and Xcode's Devices window take, re-signing it# with the tester's own identity on the way onto the phone. dittodiff --git a/scripts/ci/check-min-os.sh b/scripts/ci/check-min-os.shnew file mode 100755index 00000000..2dee1c13--- /dev/null+++ b/scripts/ci/check-min-os.sh@@ -0,0 +1,71 @@+#!/usr/bin/env bash+# Whether every Mach-O file in a bundle runs on the oldest OS the bundle+# says it runs on.+#+# Usage: check-min-os.sh <bundle> <declared-minimum> [--enforce]+#+# A bundle declares its floor once (LSMinimumSystemVersion on a Mac,+# MinimumOSVersion on a phone), but every library in it was built for a+# floor of its own, and dyld does not refuse one built for a newer system:+# it loads it, and the process dies on the first symbol the older system+# lacks. 0.2.7 for Intel Macs declared macOS 12 and shipped an ONNX Runtime+# built for 13.4, which died at launch on 12 (#333); Homebrew's libraries+# are built for the runner they were installed on.+#+# Lists each file whose own minimum is newer than the declared one, as a+# warning, in the job summary too. With --enforce, any such file fails.+set -euo pipefail++bundle="$1"+declared="$2"+enforce="${3:-}"++# The newer of two dotted versions.+newer() { printf '%s\n%s\n' "$1" "$2" | sort -V | tail -n 1; }++# A Mach-O's own minimum OS: LC_BUILD_VERSION's minos, or the older+# LC_VERSION_MIN_* command's version.+minimum_of() {+ otool -l "$1" 2>/dev/null | awk '+ /LC_BUILD_VERSION/ { build = 1; next }+ /LC_VERSION_MIN_/ { legacy = 1; next }+ build && $1 == "minos" { print $2; exit }+ legacy && $1 == "version" { print $2; exit }'+}++over=()+checked=0+while IFS= read -r -d '' file; do+ file -b "$file" | grep -q 'Mach-O' || continue+ checked=$((checked + 1))+ own=$(minimum_of "$file")+ [ -n "$own" ] || continue+ if [ "$own" != "$declared" ] && [ "$(newer "$own" "$declared")" = "$own" ]; then+ over+=("${file#"$bundle"/} needs $own")+ fi+done < <(find "$bundle" -type f -print0)++echo "check-min-os: $checked Mach-O files in $bundle, declared minimum $declared"+if [ "${#over[@]}" -eq 0 ]; then+ echo "check-min-os: every file runs on $declared"+ exit 0+fi++level=warning+[ "$enforce" = --enforce ] && level=error+for line in "${over[@]}"; do+ if [ -n "${GITHUB_ACTIONS:-}" ]; then+ echo "::$level::$(basename "$bundle"): $line, newer than the declared $declared"+ else+ echo "check-min-os: $line, newer than the declared $declared"+ fi+done+if [ -n "${GITHUB_STEP_SUMMARY:-}" ]; then+ {+ printf '### %s: files newer than the declared minimum, %s\n\n' "$(basename "$bundle")" "$declared"+ printf -- '- %s\n' "${over[@]}"+ echo+ } >> "$GITHUB_STEP_SUMMARY"+fi+[ "$level" = error ] && exit 1+exit 0