Skip to content

The truly free, open-source, local-first, cross-platform CapCut replacement. Scriptable through a JSON-RPC API & MCP.

docs(audit): the 9 October audit

Jareer48e48a1fd12c
diff --git a/audit/AUDIT-2026-10-09-QUICK.md b/audit/AUDIT-2026-10-09-QUICK.md
new file mode 100644
index 00000000..326b54a9
--- /dev/null
+++ b/audit/AUDIT-2026-10-09-QUICK.md
@@ -0,0 +1,133 @@
+# Concat audit, 9 Oct 2026 — the quick version
+
+Same audit as `AUDIT-2026-10-09.md`, one screen. Each bar has 10 slots:
+🟢 filled = good, ⚪ empty = missing. Severity: 🔴 critical · 🟠 high · 🟡 medium · ⚪ low.
+Arrows are against the 4 Oct audit. Every crate was read in full by one of four reviewers.
+
+## 🎯 Verdict
+
+**A good week for the code, a bad week for the pipeline.** Five days and 54 commits after the last audit, two of its three headline findings are closed (`[[replaces]]` fenced with tests, the preview's sound at the stream start), fmt is green, the window suite no longer races, and the day's six fixes each land with a test that fails without them: phones export and can find the file, stills keep their shape, Detach means detached, Chinese and Korean have a face to fall back on. But the release pipeline has three holes it did not have on the 4th's radar: **0.2.6 was built from `main`, 35 commits past its tag**; `main` has been red for five days on a Windows test that hangs; and the Android release key is readable by every pull-request build. In the engine, an export with sound can leave a broken file at the final path. 🟠 ×5 new, no 🔴.
+
+## 📏 Size
+
+| | Lines | Δ vs 4 Oct |
+|---|---:|---:|
+| Rust, all crates | 88 879 | +1 503 |
+| Slint UI | 29 717 | +921 |
+| WGSL, packages | 1 764 | 0 |
+| Tests (`#[test]`) | 713 | +37 |
+| Largest file `concat/src/studio.rs` | 10 435 | +406 |
+
+Checks today: fmt clean · clippy 0 warnings · 711 tests pass, 1 ignored · locales 0 missing · 22/22 perf scenarios in budget (on a loaded machine) · CI on `main` red.
+
+## 📊 The whole app
+
+| Aspect | Bar | 4 Oct | Today |
+|---|---|:-:|:-:|
+| 🧹 Code quality | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 |
+| 🏛️ Architecture | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 |
+| 🧭 Design philosophy | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 |
+| 🔧 Maintainability | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | 5 | 5 |
+| 😊 User likeability | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 |
+| ⚡ Performance | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 |
+| 📈 Scalability | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | 5 | 5 |
+| 🔐 Security | 🟢🟢🟢🟢⚪⚪⚪⚪⚪⚪ | 4 | 4 |
+| 🧪 Testing | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 |
+| 📚 Docs | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 |
+| 🤖 CI and release | 🟢🟢🟢⚪⚪⚪⚪⚪⚪⚪ | 3 | 3 |
+
+Flat across the board: what landed was good and what it cost was elsewhere. Security stays at 4 because the hijack closed and the model downloads are pinned, while the release key, the untagged release and the unverified FFmpeg opened.
+
+## 🧱 Per crate (average of its scales)
+
+| Crate | Lines | Δ | Bar | Avg | One thing |
+|---|---:|---:|---|:-:|---|
+| concat-vision | 2 760 | 0 | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 7.5 ↑ | 🟢 untouched, pinned, digested · ⚪ runtime wrapper untested |
+| concat-core | 2 891 | +37 | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7.3 | 🟢 `FrameRate::checked` in lowest terms · ⚪ `reduce` panics on file rates |
+| concat-effects | 7 256 | +160 | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7.3 | 🟢 every take-over refused with a reason · 🟡 trials on the UI thread, a catalogue leaked per reload |
+| concat-project | 10 216 | +751 | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7.3 ↑ | 🟢 placement is a model rule, 10 tests · 🟡 a 1e300 start panics the export |
+| concat-server | 1 393 | +17 | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 6.6 ↓ | 🟢 Hub panics are one caller's error · 🟠 fd leak, pre-auth seats, a reader that stops pins its seat |
+| concat-speech | 3 109 | 0 | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 6.5 | 🟢 downloads pinned to commits · ⚪ no change, stale docs |
+| concat-media | 9 832 | +338 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.6 ↓ | 🟢 stream start fixed with a fixture; 38 `unsafe`, 38 SAFETY · 🟠 the mux writes the final path |
+| concat-text | 2 607 | +633 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.6 ↓ | 🟢 colour emoji probed, not trusted · 🟡 12 MB copied to the heap, PNG decoded per render |
+| concat-api | 2 351 | 0 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.4 ↓ | 🟢 confined writes · 🟡 reads unconfined, nine window operations it cannot name |
+| concat-render | 7 432 | −692 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.5 | 🟢 scopes gone cleanly · 🟡 no uncaptured-error handler, a 10 000-px frame panics |
+| concat-android | 398 | +63 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.0 | 🟢 publisher reports `[path, why]` · 🟡 a provider exception kills the process · ⚪ 0 tests |
+| concat-cli | 514 | 0 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.0 ↓ | ⚪ no logger, no signal handling, token on argv |
+| concat-host | 10 630 | −1 239 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 5.8 | 🟢 `catch_unwind`, memory-sized caches, voiceover · 🟡 `Server::stop` blocks the UI; crashed takes lost |
+| concat-export | 3 844 | +142 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 5.9 ↓ | 🟢 folder and still fixed with tests · 🟠 mux not atomic; silent frame loss on one path |
+| concat (Slint) | 29 717 | +921 | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6.5 | 🟢 Escape on the confirm sheet · 🟡 2 `accessible-*` in 29 717 lines |
+| concat (Rust) | 22 554 | +1 293 | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | 5.1 ↓ | 🟢 three `expect`s in 22.5k lines · 🟡 dialogs under a `RefCell` borrow; `studio.rs` +406; 71 tests |
+
+## 🎛️ Per feature
+
+| Feature | Bar | 4 Oct | Today | State |
+|---|---|:-:|:-:|---|
+| Launcher | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ |
+| Import and bin | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ ★ click to preview |
+| Timeline editing | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ ★ never lands on top, ★ detach alone |
+| Titles and text | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 7 | 8 ↑ | ✅ ★ colour emoji, ★ font picker |
+| Auto-captions | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 7 | 8 ↑ | ✅ words at the right time on MTS |
+| Effects and filters | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ `[[replaces]]` fenced |
+| Undo / redo | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ |
+| LUTs | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ |
+| Relink | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 8 | 6 ↓ | ⚠️ "Relink all" walks on the UI thread, follows symlink loops |
+| Themes | 🟢🟢🟢🟢🟢🟢🟢🟢⚪⚪ | 8 | 8 | ✅ |
+| Playback and audio | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 5 | 7 ↑ | ✅ stream start, one-word clock, window decoded ahead |
+| Transitions | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ⚠️ hold plays keyed effects early |
+| Colour and HDR | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ AMF Main 10 |
+| Colour grading | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ |
+| Keyframes | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ |
+| Crop, blend, masks | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ shape masks still absent (#239) |
+| Cutout | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ |
+| Text-to-speech | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ |
+| Templates | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ✅ |
+| Custom packages | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 6 | 7 ↑ | ✅ trials at Default, Min, Max on a sibling |
+| Export | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 7 | 7 | ⚠️ ★ makes its folder; mux not atomic; overwrites without asking |
+| ★ Monitor stills | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | – | 7 | ✅ keeps its shape, pixel test |
+| ★ Export on a phone | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | – | 6 | ⚠️ into Movies/Concat; unseen on a phone |
+| Phone shell | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 6 | 7 ↑ | ✅ exports, findable, stills right |
+| Languages | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 6 | 7 ↑ | ✅ ★ CJK face held to the locales; ja real; de/fr/ko/pt-BR half English |
+| Volume line | 🟢🟢🟢🟢🟢🟢🟢⚪⚪⚪ | 6 | 7 ↑ | ✅ flushes the title commit |
+| ★ Voiceover | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | – | 6 | ⚠️ a crashed take is lost |
+| Hardware encode | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 | ✅ |
+| Enhance | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 | ⚠️ copies in `cache/` |
+| Shapes / Stickers | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 | ⚠️ vanish under 0.2.5 |
+| Keyboard menus | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 | ⚠️ |
+| Windows data folders | 🟢🟢🟢🟢🟢🟢⚪⚪⚪⚪ | 6 | 6 | ✅ |
+| Remote API | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | 6 | 5 ↓ | ⚠️ nine window operations it cannot name; `stop` blocks the UI |
+| Proxies | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | 5 | 5 | ⚠️ |
+| Self-update | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | 5 | 5 | ⚠️ no signature |
+| ★ VU meters | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | – | 5 | ⚠️ programme meter has no feed |
+| ★ Windows text | 🟢🟢🟢🟢🟢⚪⚪⚪⚪⚪ | – | 5 | ⚠️ pixel-snapped at 1x; unseen on Windows |
+| Accessibility | 🟢🟢⚪⚪⚪⚪⚪⚪⚪⚪ | 2 | 2 | ❌ |
+| Scopes | – | 7 | – | removed |
+
+## 🚨 Findings
+
+🟠 **High**
+1. 0.2.6 was built from `main`, 35 commits past its tag: the build workflows check out with no `ref` (`build-app.yml:152`, `mobile.yml:58`).
+2. `main` red five days: the Windows test job hangs in `cards::tests::every_card_draws…` and dies at 90 min; the release gate reuses it.
+3. The Android release key and password reach pull-request builds and every build script (`mobile.yml:36, 113-130`).
+4. An export with sound muxes straight into the final path; a failure leaves a truncated file where the last export was (`audio.rs:720`, `concat-export/src/lib.rs:992`).
+5. The CJK face shipped with half of Big5 and no JIS; its test proved registration, not coverage. Fixed at the head with a coverage test.
+
+🟡 **Medium** — dialogs open under the studio's `RefCell` borrow (6) · the export sheet overwrites without asking and accepts `/` in a name (7) · a frame over 8192 px panics wgpu (8) · a 1e300 clip start panics the export (9) · a SAFETY line on `set_var` is untrue (10) · a group dragged past 0 collapses (11) · a speed curve grows over a neighbour (12) · trials on the UI thread, a catalogue leaked per reload (13) · "Relink all" on the UI thread (14) · fifteen English strings in Rust and Slint (15) · `Server::stop` blocks the window; jobs and decode workers die silently on a panic (16) · API reads unconfined, caller strings to FFmpeg's opener (17) · one export path drops failed frames silently (18) · pinned prefetch frames outside any budget (19) · a crashed voiceover take is lost (20) · unverified FFmpeg and sherpa downloads, mutable action tags (21) · three Android bridge crash paths (22).
+
+⚪ **Low** — doc drift in gpu.rs, studio.rs, pool.rs, ARCHITECTURE (23) · tests that skip in CI or prove the wrong thing (24) · Rational edges, negative starts, RIFF overflow, `DefaultHasher` proxy names (25) · non-ABI side-data sizes (26) · realtime audio frees and faults (27) · blocking IO on the UI thread (28) · hygiene (29).
+
+## 🧭 What the 4 Oct audit asked, and what landed
+
+✅ fmt, locale lock, 0.2.6 section · ✅ `[[replaces]]` fence, keys, notice, trials on a sibling · ✅ stream start with a fixture · ✅ export rate, volume flush, art caches · ❌ document version for shapes · ❌ `FocusScope`/Escape/`accessible-label` · ❌ the 28 Sept list (update signing, server seats and fds, API reach).
+
+## ▶️ Next, in order
+
+1. `ref:` the tag in both build workflows; Android signing on release runs only; skip or time out the cards test without a GPU; toolchain into CI; tag 0.2.7 from a green `main`.
+2. Mux into scratch and rename; one failure policy for the export; a size ceiling with an uncaptured-error handler; bound clip times and probed rates.
+3. Export sheet: refuse `/` and empty names, ask before overwriting; dialogs on the next loop turn.
+4. Trials, relink, cache clear and sweep off the UI thread.
+5. `Server::stop` cancels first; `catch_unwind` on jobs and workers; a protocol whitelist before FFmpeg; a write timeout.
+6. Pinned-frame budget; WAV placeholder header; group clamp; speed-curve ripple.
+7. The literals through `I18n`; a locale check that flags English.
+8. Digests for downloads; actions by SHA; `inputs.tag` through `env:`.
+9. See Windows text and the phone's export on real hardware. Then the 28 Sept list.
diff --git a/audit/AUDIT-2026-10-09.md b/audit/AUDIT-2026-10-09.md
new file mode 100644
index 00000000..9c8d9ed9
--- /dev/null
+++ b/audit/AUDIT-2026-10-09.md
@@ -0,0 +1,766 @@
+# Concat audit, 9 October 2026
+
+Where the codebase stands five days after the 4 October audit, at
+`99c3e26` (9 October), 62 commits past the 0.2.6 tag and 54 commits past
+the last audit. Same method, same scales, and every finding from the 4th
+(and what was carried from the 28th) re-verified against today's tree.
+Every finding names a file and a line. The sibling
+`AUDIT-2026-10-09-QUICK.md` is this audit as a one-screen scorecard.
+
+**How it was done.** Four reviewers each read one part of the tree in
+full: the window's Rust, Slint and locales; host, server, API and CLI;
+media, render, export and core; project, effects, text, vision, speech,
+Android, perf, CI and release. Each re-verified the 4 October findings in
+its part, scored it and reported new findings with locations. The four
+headline items (a release built from `main` instead of its tag, the
+Windows test hang that keeps `main` red, the Android key in pull-request
+builds, the non-atomic audio mux) were re-read by hand against the code
+and the workflow runs before they went in. Line, test and `unsafe`
+tallies come from the tree; `cargo fmt --check`,
+`cargo clippy --workspace --all-targets`, `cargo test --workspace`,
+`scripts/locales.py --check`, `scripts/models.py --check` and
+`cargo run -p concat-perf --release -- --check` were run on this machine
+(Apple Silicon, macOS 26) today. The app itself was not launched; the
+Android build was compile-checked for its target and the 0.2.6 APK was
+run on an emulator to the point where its window exits.
+
+**What also happened today.** Six fixes landed on `main` during the
+audit, after the reviewers had started: an export makes its folder
+(38e45a9), a phone's export goes into Movies (63f2633), a still keeps its
+shape on the monitor (89f5ddd), a CJK fallback face and five installer
+languages (eb18dbd, corrected by the commit at the head), a detached
+sound moves on its own (e11006e), and glyphs sit on whole pixels at 1x
+(3989e59, a vendored patch of Slint's Skia renderer). The reviewers judged
+them; two findings below are about them.
+
+**Scale.** 0 to 10. 8 and up means "keep doing this"; 5 to 7 means
+"works, with known debt"; 4 and under means "will bite at the next order
+of magnitude, or already bites".
+
+---
+
+## 1. The numbers
+
+### 1.1 Size, tests and hygiene per crate
+
+Deltas are against the 4 October table. The unwrap column gives the
+total and, in brackets, the count outside test modules and test files
+(everything before the first `#[cfg(test)]` in each file; `tests/`
+directories excluded); the panic column is the non-test count of
+`panic!`, `unreachable!`, `unimplemented!` and `todo!`.
+
+| Crate | Rust lines | Δ | Slint / WGSL | Tests (files) | `unsafe` | `unwrap`/`expect` (non-test) | `panic!` family (non-test) |
+|---|---:|---:|---:|---:|---:|---:|---:|
+| concat (window) | 22 554 | +1 293 | 29 717 slint | 71 (18) | 12 | 28 (3) | 0 |
+| concat-host | 10 630 | −1 239 | | 85 (19) | 4 | 243 (2) | 0 |
+| concat-project | 10 216 | +751 | | 113 (1) | 0 | 355 (11) | 6 |
+| concat-media | 9 832 | +338 | | 96 (11) | 38 | 204 (23) | 0 |
+| concat-render | 7 432 | −692 | shaders inline in `gpu.rs` | 86 (5) | 1 | 86 (68) | 3 |
+| concat-effects | 7 256 | +160 | 1 764 wgsl | 72 (9) | 0 | 134 (5) | 2 |
+| concat-export | 3 844 | +142 | | 31 (3) | 0 | 28 (0) | 0 |
+| concat-speech | 3 109 | 0 | | 19 (3) | 3 | 23 (2) | 0 |
+| concat-core | 2 891 | +37 | | 49 (7) | 0 | 26 (4) | 2 |
+| concat-vision | 2 760 | 0 | | 31 (8) | 0 | 22 (2) | 0 |
+| concat-text | 2 607 | +633 | | 24 (1) | 1 | 67 (1) | 0 |
+| concat-api | 2 351 | 0 | | 21 (2) | 0 | 23 (0) | 0 |
+| concat-server | 1 393 | +17 | | 10 (3) | 0 | 28 (0) | 0 |
+| concat-perf | 1 092 | 0 | | 2 (1) | 0 | 34 (34) | 0 |
+| concat-cli | 514 | 0 | | 3 (1) | 0 | 2 (2) | 0 |
+| concat-android | 398 | +63 | +92 java | 0 (0) | 10 | 1 (1) | 0 |
+| **Total** | **88 879** | **+1 503** | **~31 500** | **713 (92)** | **69** | **1 304 (158)** | **13** |
+
+The tree grew by 1.7 % in five days, less than the 4.5 % of the week
+before, and for the first time a crate shrank: the Scopes pane and its
+GPU counting went (616d8fa, −1 239 lines in concat-host and −692 in
+concat-render). The growth is the window again (+1 293 Rust, +921 Slint:
+voiceover, VU meters, the font picker, click-to-preview, the publish
+hook, the CJK fallback), concat-project (+751: the placement rule and its
+tests), concat-text (+633: colour emoji, base fonts) and concat-android
+(+63 Rust, +92 Java: the media-store publisher). `studio.rs` is 10 435
+lines (10 029 on the 4th; 46 % of the window's Rust) and was not split;
+`concat-export/src/lib.rs` is 3 015 (2 873), `concat-render/src/gpu.rs`
+3 374 (3 630), `concat-effects/src/shader.rs` 2 412, `concat-text/src/lib.rs`
+2 607 (1 974). The four new `unsafe` sites are concat-host's memory
+sizing (`memory.rs:22, 37`, each argued) and concat-media's count moving
+from 37 to 38 with the audit's own recount; every one of the 69 carries a
+SAFETY line, and one of them is not true as written (finding 10 below).
+
+Other facts: 123 effect packages, unchanged (98 on format 2 with WGSL: 21
+effects, 57 looks, 20 transitions; 25 audio packages on FFmpeg chains);
+14 locale files at 1 011 keys each, 0 missing and 0 stale per
+`scripts/locales.py --check` (ja was translated for real this week,
+3aa6e5c; de, fr, ko and pt-BR still carry 137 to 204 English values, see
+finding 15); 873 commits since 25 August, 54 since the last audit (222
+files, +17 705 / −2 197; 37 by the maintainer, 14 by one contributor
+merged on the 6th, 3 by others); 30 tags, latest `v0.2.6`, 62 commits
+behind `main`; `Cargo.lock` holds 817 packages, one of them now a path
+dependency (`src/patches/i-slint-renderer-skia`, 1.18.1 with one
+function changed). The window carries 2.7 MB of Noto Sans CJK as a
+fallback face from today; the binaries grow by that much.
+
+### 1.2 The checks, run today
+
+| Check | Result |
+|---|---|
+| `cargo fmt --all -- --check` | **clean** (10 files would change on the 4th) |
+| `cargo clippy --workspace --all-targets` | 0 warnings |
+| `cargo test --workspace --no-fail-fast` | **711 passed, 0 failed, 1 ignored** (672 passed, 1 failed on the 4th) |
+| `scripts/locales.py --check` | 14 locales, 1 011 keys, 0 missing, 0 stale |
+| `scripts/models.py --check` | 23 models, 3.37 GB, mirrored on `models-v1` |
+| `cargo run -p concat-perf --release -- --check` | 22 of 22 scenarios within budget |
+| `cargo audit` | not installed on this machine; not run |
+| CI on `main` | **red at head, and on every completed push since 4 October 15:16** |
+
+**fmt is green and the window suite no longer races.** The ten fmt sites
+of the 4th were fixed the same day (3121107, 7b5cc44), and the two
+locale-dependent tests now take `i18n::language_lock()` (4c5055e,
+`concat/src/i18n.rs:363-366`), so the window suite passes with the
+default thread count. Every crate passes: the end-to-end export suite (11
+tests, 18 s) and the parity suite among them.
+
+**CI is red for a new reason.** The Linux engine job passes. The Windows
+test job added on the 6th (9440a67, `ci.yml:247-252`) hangs in
+`concat-host cards::tests::every_card_draws_and_shows_its_package_at_work`
+and is killed at 90 minutes, on every run that got that far (37521843321,
+37624855588, 37890980349). 14 of the 22 push runs since the audit were
+cancelled by the next push (`ci.yml:22-24`). `release.yml:67-72` reuses
+`ci.yml` as the gate, so a tag today would fail before it built anything.
+CI still installs `stable` (1.99) while `src/rust-toolchain.toml` pins
+1.93 (`ci.yml:38, 150, 191`).
+
+**The perf table**, release build, every scenario inside its budget. The
+4 October reading is in the fourth column.
+
+| Scenario | Measured | Budget | 4 Oct |
+|---|---:|---:|---:|
+| plan one frame of 200 clips on 4 tracks | 0.56 µs | ≤ 200 µs | 0.54 µs |
+| 200 clip additions and 200 undos | 0.97 ms | ≤ 150 ms | 0.71 ms |
+| ripple delete of 200 clips out of 400 | 0.12 ms | ≤ 20 ms | 0.13 ms |
+| save and open a 200-clip document | 1.80 ms | ≤ 60 ms | 1.67 ms |
+| choose the visible clips of 200 for one publish | 0.25 µs | ≤ 50 µs | 0.21 µs |
+| read an hour's waveform across 2048 columns | 4.92 µs | ≤ 2000 µs | 4.23 µs |
+| decode 1080p h264 in software | 568 fps | ≥ 120 | 809 fps |
+| decode 1080p h264 on the hardware (VideoToolbox) | 203 fps | ≥ 120 | 175 fps |
+| decode 4K h264, the app's choice (software) | 98 fps | ≥ 30 | 115 fps |
+| decode 4K HEVC 10-bit, the app's choice (VideoToolbox) | 71 fps | ≥ 30 | 92 fps |
+| decode 4K HEVC 10-bit in software | 26 fps | ≥ 24 | 31 fps |
+| decode 3 streams of 4K HEVC 10-bit at once | 32 fps | ≥ 24 | 45 fps |
+| decode 4K HLG tone-mapped on the CPU, 960×540 | 17 fps | ≥ 15 | 22 fps |
+| decode 4K HLG deep for the GPU, 960×540 | 103 fps | ≥ 30 | 127 fps |
+| scrub forward over 90 frames, cold | 1.36 ms/frame | ≤ 25 | 0.95 |
+| scrub back over covered ground | 0.51 µs/frame | ≤ 200 | 0.43 |
+| decodes when an effect knob is turned | 0 | ≤ 0 | 0 |
+| compose 1080p, 3 layers, a look, on the GPU | 3.33 ms | ≤ 25 | 1.92 ms |
+| Gaussian blur over 4K, radius 10, on the GPU | 6.42 ms | ≤ 33 | 6.34 ms |
+| Gaussian blur over 4K, radius 50, on the GPU | 11.12 ms | ≤ 33 | 9.77 ms |
+| export a 4 s 720p cut of two overlapping clips | 86 fps | ≥ 30 | 157 fps |
+| export the same cut as HDR: HLG, HEVC 10-bit | 64 fps | ≥ 30 | 82 fps |
+
+Read this table as a floor, not a trend. It ran while four reviewers
+read the tree and two cargo builds were in flight on the same machine,
+and the two rows that dropped most (software h264 decode, the 720p
+export) are the two that most want every core. The code on the decode
+path changed in one place this week (the still's cut size, 89f5ddd,
+which touches no video row). The software HEVC row at 26 fps against a
+budget of 24 is the one to watch: a quiet-machine run before the next
+audit should put it back near 31.
+
+---
+
+## 2. Scorecard for the whole app
+
+| Aspect | 4 Oct | Today | One line |
+|---|:-:|:-:|---|
+| Code quality | 6 | 6 | fmt green, clippy clean, three `expect`s in 22.5k lines of window code; against that, more English in Rust strings, docs drifting onto the wrong items, and one SAFETY line that is not true. |
+| Design architecture | 8 | 8 | Held: the placement rule moved into the model where the window, API and CLI share it; the Hub's panics are one caller's error; the sibling compositor seam carries trials. |
+| Design philosophy | 6 | 6 | `[[replaces]]` fenced and `matches_category` made data-driven (two rules restored); the API fell further behind the window (voiceover, meters, fonts, preview); shapes still vanish under 0.2.5. |
+| Maintainability | 5 | 5 | `studio.rs` 10 435 lines in one `impl` on a 98-field struct; `run()` 1 600 lines; a vendored Slint crate to carry across upgrades; four Slint files over 1 800 lines. |
+| User likeability | 7 | 7 | A phone can export and find the file; stills keep their shape; Detach means detached; voiceover and meters; colour emoji. Against that, the Windows text fix is unseen on Windows, and the export sheet overwrites without asking. |
+| Performance | 6 | 6 | Playback publishes only the picture now and asks for frames on time; but prefetch pins frames outside any budget, package reloads trial shaders on the UI thread, and "Relink all" walks a folder on it. |
+| Scalability | 5 | 5 | Unchanged: the fd leak per API connection, the one Hub thread, the per-sample mixer scan, the per-edit bin clone. |
+| Security | 4 | 4 | The hijack is closed and model downloads are pinned and digested; but the Android release key reaches pull-request builds, 0.2.6 was built from `main` not its tag, FFmpeg is fetched from a moving release with no digest, and the update chain is as it was. |
+| Testing | 6 | 6 | 713 tests, +37 on +1 500 lines, and the suite is green and race-free locally; CI never finishes on Windows; the week's Android, record and publish code has no tests. |
+| Documentation | 6 | 6 | 0.2.6 has its section; the week since has none; four gpu.rs docs describe a CPU fallback that no longer exists; README still sells an MCP transport. |
+| CI and release | 3 | 3 | fmt is no longer the blocker, a hanging test is; the release workflow builds `main` on a hand start; the key and password reach every build step. |
+
+---
+
+## 3. Scores per crate
+
+Columns: code quality, maintainability, scalability, performance,
+architecture, design philosophy, security, testing. A dash means the
+scale does not apply. Arrows are against 4 October.
+
+| Crate | CQ | Maint | Scale | Perf | Arch | Phil | Sec | Test | Note |
+|---|:-:|:-:|:-:|:-:|:-:|:-:|:-:|:-:|---|
+| concat-core | 8 | 8 | 6 | 7 ↑ | 8 | 8 | 6 | 7 | `FrameRate::checked` in lowest terms with a test; dead `Project` and `source_duration` remain; `reduce` still panics on file-derived rates and `Neg` on `i64::MIN`. |
+| concat-project | 8 | 7 | 6 | 6 | 8 ↑ | 7 | 6 | 8 ↑ | Placement is a model rule with 10 tests; 0.2.4 fields are dropped with a notice; a speed curve can still grow a clip over its neighbour, and a 1e300 start loads. |
+| concat-media | 7 | 6 ↓ | 5 | 7 | 8 | 7 | 6 | 7 | The stream-start fix landed with a fixture; every `unsafe` argued; the mux writes the final path directly; pinned prefetch frames have no budget; `cover` means two things for stills now. |
+| concat-render | 7 | 5 | 6 | 7 | 8 | 7 | 5 ↓ | 7 | Scopes gone (−692 lines); no uncaptured-error handler and no texture-limit check, so a 10 000-px frame panics the thread; four docs describe a CPU fallback that is gone. |
+| concat-effects | 8 | 7 ↓ | 6 | 5 ↓ | 8 | 8 ↑ | 6 | 8 | `Catalogue::add` refuses every take-over with a reason and tests; trials at Default, Min and Max; but they run on the UI thread's timer, the catalogue is leaked per reload, and `breaks()` miscounts a `switch` break. |
+| concat-export | 6 | 4 | 6 | 5 | 7 ↓ | 7 | 6 | 6 ↓ | Folder made, still fixed, both with tests; the audio mux is not atomic; frames that fail in the pool path vanish silently while the paced path aborts; `lib.rs` 3 015 lines. |
+| concat-host | 7 | 6 | 5 | 6 | 6 | 6 | 4 | 6 | Hub `catch_unwind` landed; memory-sized caches; voiceover; VU meters; the update chain, the cache deletion and the HDR proxy name as they were; `Server::stop` blocks the UI on a running API export. |
+| concat (Rust) | 6 ↓ | 4 | 5 | 6 | 5 ↓ | 6 | 6 | 3 ↓ | Rate ladder, volume flush, art caches, locale races fixed; the CJK face shipped once with half its coverage; dialogs open under a `RefCell` borrow; `studio.rs` grew 406 lines; 71 tests for 22.5k lines. |
+| concat (Slint) | 7 | 6 | 6 | 7 | 7 | 6 | – | – | Confirm sheet handles Escape; everything else of the 4th holds: 2 `accessible-*` properties, 158 `TouchArea`s, 15 `FocusScope`s, the category pills' English list on the phone. |
+| concat-api | 8 | 7 ↓ | 5 | 5 ↓ | 8 | 5 ↓ | 5 ↓ | 7 | One test line in the week while the window gained four operations; reads unconfined and caller strings reach FFmpeg's opener; export jobs have no panic guard. |
+| concat-server | 7 | 8 | 5 | 6 | 8 | 8 | 5 ↓ | 6 ↓ | `catch_unwind` on the Hub; the pre-auth fd leak, EMFILE spin and pre-auth seats as they were; a caller that stops reading pins its seat for good. |
+| concat-cli | 7 | 8 | – | – | 7 | 6 | 6 | 2 ↓ | No commits; no logger; `serve` parks with no signal handling, token on argv and stdout. |
+| concat-speech | 7 | 5 | 6 | 7 | 6 | 7 | 8 ↑ | 6 | No commits; downloads pinned to commit URLs with digests, staged and renamed once; the stale child-process doc and the silent DirectML fallback remain. |
+| concat-vision | 8 | 8 ↑ | 5 | 6 | 9 | 8 | 8 | 7 | Zero churn since 23 September; hashed cache names. |
+| concat-text | 7 ↓ | 6 ↓ | 5 | 6 | 8 ↓ | 8 | 7 | 6 ↓ | Colour emoji paint in their own colours, probed not trusted; the one file is 2 607 lines; 12 MB of embedded faces copied to the heap; PNG strikes decoded per render; the bitmap path never runs in CI. |
+| concat-android | 7 ↓ | 7 | – | 7 | 7 | 7 | 6 | 1 | The publisher: pending entry, copy, publish, original deleted, `[path, why]` back; a provider's runtime exception on import still kills the process; a restored fragment cannot be instantiated; 0 tests. |
+
+---
+
+## 4. Scores per feature
+
+Status: **done**, **partial** (works with a known gap), **thin** (present,
+weak). Rows that changed since the 4th carry a reason; ★ marks a row new
+this week.
+
+| Feature | Where | Status | 4 Oct | Today | Why |
+|---|---|---|:-:|:-:|---|
+| Launcher, new project, recents | `ui/start.slint` | done | 8 | 8 | A folder named with either slash is one recent (7641f00). |
+| Import, bin, drag and drop | `ui/workspace/media-pane.slint` | done | 8 | 8 | ★ A click previews a file without placing it (e43e106); "N selected" still untranslated. |
+| Timeline editing | `ui/timeline/`, `placement.rs` | done | 8 | 8 | ★ A clip never lands on top of another, in the model, 10 tests (faa6da9); a click sends the playhead (2cc3e02); ★ a detached sound moves alone (e11006e); a group dragged past 0 still collapses (finding 11). |
+| Volume line | `lanes.slint`, `studio.rs:6437` | done ↑ | 6 | 7 | The pending title commit is flushed first (5c97f20); untested. |
+| Undo and redo | `editor.rs` | done | 8 | 8 | Every snapshot still clones the bin. |
+| Transitions | `plan.rs`, `concat-export/src/lib.rs:768` | partial | 7 | 7 | The hold still plays keyed effects early. |
+| Effects and filters | `concat-effects/packages/` | done | 8 | 8 | `[[replaces]]` fenced with reasons and tests (ab1c482); shelves are data (f9584ab). |
+| Colour and HDR | `model.rs`, `gpu.rs`, `encode.rs` | done | 7 | 7 | AMF makes ten-bit HEVC as Main 10 (56e94bb). |
+| Scopes | – | removed | 7 | – | The pane and its GPU counting are gone (616d8fa). |
+| Colour grading | `concat.color-wheels`, `grading.slint` | done | 7 | 7 | Unchanged. |
+| Titles and text | `concat-text`, `titles.rs` | done ↑ | 7 | 8 | ★ Colour emoji in their own colours (a03e416); ★ base fonts every title can use, presets as data, a searchable picker that says when a font is missing (97b349b, aee2d61). |
+| Shapes / Stickers | `media-pane.slint`, `clips.rs` | partial | 6 | 6 | Still vanish under 0.2.5. |
+| Keyframes, animations | `model.rs` | done | 7 | 7 | Unchanged. |
+| Crop, transform, blend, masks | `plan.rs` | done | 7 | 7 | Unchanged; shape masks of 0.2.4 still absent (#239). |
+| Cutout, smart brush | `segment.rs` | done | 7 | 7 | Unchanged. |
+| Enhance | `enhance.rs` | thin | 6 | 6 | Copies still land in `cache/`. |
+| Auto-captions | `captions.slint`, `samples.rs` | done ↑ | 7 | 8 | Words sit at the right time on MTS files now (c6d7e17, with a fixture). |
+| Text-to-speech | `tts.rs` | done | 7 | 7 | No change; the provider is still not logged. |
+| ★ Voiceover | `concat-host/src/record.rs`, `panes/voiceover.rs` | partial | – | 6 | Records from the microphone onto the timeline (1370adb); a crashed take has a zero-length header and is lost; two quick takes can land in each other's place. |
+| ★ VU meters | `concat/src/meters.rs` | thin | – | 5 | Beside the timeline (f1f2f3e); the programme meter has no feed and sits at silence. |
+| Templates | `templates.rs` | done | 7 | 7 | Poster still copied under a name nothing reads. |
+| LUT import | `cube.rs` | done | 8 | 8 | Unchanged. |
+| Custom and community packages | `catalogue.rs` | done ↑ | 6 | 7 | Trials at three settings on the sibling compositor (ab1c482); still on the UI thread, still skipped with no sibling. |
+| Proxies | `proxy.rs` | partial | 5 | 5 | The encoder is dropped before the rename (543443a); names use `DefaultHasher`. |
+| Export | `export.slint`, `concat-export` | done | 7 | 7 | ★ Makes its folder (38e45a9); the mux can leave a broken file at the final path; the sheet overwrites without asking. |
+| ★ Export on a phone | `platform.rs:599`, `ConcatFiles.java:76` | partial | – | 6 | The file goes into Movies/Concat through the media store (63f2633), Browse is gone; unseen on a real phone; a 0-row update hides the file. |
+| Hardware encode | `encode.rs:325` | done | 6 | 6 | Unchanged. |
+| Playback and audio | `playback.rs`, `samples.rs` | done ↑ | 5 | 7 | Sound at the stream start (c6d7e17); the run-on clock is one word (02bb564); the full window decoded ahead (e5931a6); the mixer scan and the realtime frees remain. |
+| ★ Monitor stills | `pool.rs:774` | done | – | 7 | A still keeps its shape (89f5ddd, pixel test); still stretched when a clip has no dimensions. |
+| Hardware decode | `hardware.rs` | done | 7 | 7 | Unchanged. |
+| Remote API | `concat-api`, `concat-server` | partial ↓ | 6 | 5 | Nine window operations the API cannot name; `stop` blocks the window on a running job. |
+| Self-update | `updates.rs` | done | 5 | 5 | Unchanged. |
+| Logs | `logs.rs` | done | 7 | 7 | Unchanged. |
+| Keyboard menus, platform keys | `app.slint`, `platform.rs` | partial | 6 | 6 | Unchanged. |
+| Save Video Frame As, Save Audio As | `studio.rs:5768`, `6364` | done | 7 | 7 | Dialogs still open under the studio borrow (finding 7). |
+| Phone shell | `ui/phone/`, `concat-android` | partial ↑ | 6 | 7 | Exports work and are findable; stills right; the category pills' English list is still shown there. |
+| Relink missing media | `relink.slint`, `panes/relink.rs` | done ↓ | 8 | 6 | "Relink all" walks the folder on the UI thread and follows symlinks with no loop guard. |
+| Themes and accent colours | `ui/theme/` | done | 8 | 8 | Unchanged. |
+| Languages | `concat/locales/`, `fonts.rs` | partial ↑ | 6 | 7 | ★ A CJK fallback face covers every character the four CJK locales use, held by a test; ja translated for real; de, fr, ko, pt-BR still carry 137-204 English values. |
+| ★ Windows text | `src/patches/i-slint-renderer-skia` | partial | – | 5 | Pixel-snapped glyphs at 1x (3989e59); not yet seen on a Windows screen. |
+| Accessibility | the whole UI | thin | 2 | 2 | Unchanged. |
+| Windows data folders | `dirs.rs:95` | done | 6 | 6 | Unchanged. |
+
+---
+
+## 5. The 4 October findings, re-verified
+
+Numbers are the 4 October audit's (its section 6), with the 28 September
+items it carried marked S#.
+
+| # | Finding | Today | Evidence |
+|---|---|---|---|
+| 1 | `main` red at fmt; nothing behind it ran | **Fixed, then red again** | fmt green since 3121107 and 7b5cc44; the Windows test job (9440a67) hangs in `cards::tests::every_card_draws_and_shows_its_package_at_work` and is killed at 90 min; last green push run 37212363814, 4 Oct 15:16. CI still on `stable` (`ci.yml:38`). |
+| 2 | `[[replaces]]` can hijack a live built-in; keys dropped; silent | **Fixed** | `Catalogue::add` refuses an installed, bare or stood-in-for id (`catalogue.rs:1021-1080`); `upgrade` leaves answered links alone (`:1127-1140`); `replacing` carries keys (`:589-614`); `Session::open` records rewrites (`session.rs:109-119`); tests at `catalogue.rs:1320, 1356`. Residue: a package may still claim any id this catalogue lacks (finding 22). |
+| 3 | Preview sound and transcript ignore the stream start | **Fixed** | c6d7e17, 18 minutes after the audit: `samples.rs:177-190` seeks at `start + origin`, the trim is offset, `fixtures/tone-at-1s.ts` added; `playback.rs:803-808` salts the decode key to retire the wrong spans. |
+| 4 | Locales hold English verbatim | **Mostly unchanged** | ja 137 → 7 (3aa6e5c); de 204 → 199, fr 207 → 204, ko 137, pt-BR 179 → 175. `locales.py` still compares key sets only (`scripts/locales.py:140-158`). |
+| 5 | Shapes vanish under 0.2.5; unknown kinds rewritten | Unchanged | `wire::clip_kind` falls back to `Video` (`model.rs:1172-1175`); `DOCUMENT_VERSION` is 1 (`doc.rs:41`). |
+| 6 | Install trial at defaults only; a timeout kills the monitor | **Partly fixed** | Trials at Default, Min and Max (`catalogue.rs:479-484`) on `monitor.sibling()` (`studio.rs:7236-7249`); the sibling shares the device (`gpu.rs:727-729`), so a real hang still takes the monitor; with no sibling the package installs untried (`studio.rs:7243-7245`); `preview.rs:222-227` still answers "lost" for good. |
+| 7 | The dissolve hold plays keyed effects early | Unchanged | `pre_roll` clears placement keys only (`concat-export/src/lib.rs:768-805`). |
+| 8 | Export rate is a fixed ladder | **Fixed** | a2ba094: the timeline's rate first, `rates_around` de-duplicates (`panes/export.rs:264-302`), test at `:663-677`. |
+| 9 | Volume drag drops typed title words | **Fixed** | 5c97f20: `studio.rs:6437-6443` flushes the pending commit first. No test. |
+| 10 | Art caches never released; ungated workers; export on close | **Partly fixed** | `forget_art` on open and close (`studio.rs:2093-2102`, 2433bab); `spawn_at` epoch-gated (`host.rs:312-322`); `save` still on the ungated `spawn` (`studio.rs:2437-2447`); `close_project` cancels cutouts, enhancers and reversers, not the exporter (`:6992-6995`). |
+| 11 | A full publish per monitor frame | **Partly fixed** | `spawn_frame` sets only the picture during playback (ee28f25, `host.rs:226-254`); every other full publish rebuilds both menus, `export.data()` and `settings.data()` (`studio.rs:9201-9207`). |
+| 12 | No keyboard reach; Escape closes nothing | Unchanged (slightly better) | `dialogs/confirm.slint:46` handles Escape; `Modal` and `Button` still have no `FocusScope`; one `accessible-label` in `ui/`. |
+| 13 | Strings that bypass i18n | **Partly fixed, partly worse** | The desktop dropped the category pills (79eafc7) but the phone still shows their English list (`media-pane.slint:1421-1430`, `phone/editor.slint:903, 965`); "{n} selected", "still", "Empty", "% of height", "Merge selected" unchanged; new Rust-side English in finding 15. |
+| 14 | Emoji paint as boxes on macOS | **Fixed** | a03e416: `own_colours` counts PNG, BGRA and simple `COLR` strikes (`concat-text/src/lib.rs:630-646`), `mark` draws them (`:997-1049`). The test returns early where no colour face exists, and CI installs none (finding 24). |
+| 15 | No Unreleased section in CHANGELOG | **Fixed, then recurred** | `## 0.2.6` written (cc19703); voiceover, meters, emoji, Android publishing, base fonts, the CJK fallback, the detach change and the Windows text patch have no section (`CHANGELOG.md:10`). |
+| 16 | Code grew without tests | Mixed | +37 tests on +1 503 lines: placement 10, catalogue 2, export 2, fonts 3, rates 1, elsewhere small; the window is at 71 tests for 22.5k lines; concat-android 0 on +155 lines; record.rs tests only its helpers. |
+| 17 | README sells an MCP transport | Unchanged | `README.md:62, 79, 114`; `concat-api/src/lib.rs:7`. |
+| 18 | The CLI installs no logger | Unchanged | `concat-cli/Cargo.toml` has no `log`; `logs::open_console` exists unused (`logs.rs:97`). |
+| 19 | The API is behind the window | **Worse** | Voiceover, VU meters, the font picker, presets as data and click-to-preview are window-only; the API gained one test line (3156ddb); `message.rs:24` still promises parity. |
+| 20 | Small correctness in concat-project | Partial | `has_non_finite` lists 8 of 11 `TextStyle` floats (`commands/mod.rs:931-940`) while `tidy` sanitises all 11; `"concat": "0.1.0"` still written (`doc.rs:320`). |
+| 21 | `matches_category` hard-codes nine ids | **Fixed** | f9584ab: categories and shelves from the manifest (`catalogue.rs:425-460`). |
+| 22 | concat-media lows | Unchanged | No fallback after a hardware encoder opens; Media Foundation labelled hardware; `sws_setColorspaceDetails` result ignored; a fresh reader seeks twice (`pool.rs:367, 981-984`); AMF handed `qp_b`. |
+| 23 | Host lows | Unchanged | Silent data-folder move (`dirs.rs:113-122`); any exe under Program Files is an MSI install (`updates.rs:289-299`); poster copied as `preview.jpg` (`templates.rs:356`); the dirs test runs against the real `%APPDATA%`. |
+| 24 | Window lows | Unchanged, docs worse | Extension swapped after the overwrite prompt (`studio.rs:5774-5783, 6370-6379`); JPEG on the UI thread in `freeze_at_playhead` (`6582-6595`); token from `RandomState` (`settings.rs:855-863`); docs stacked on the wrong items, now also on `forget_art` (`studio.rs:2082-2092`). |
+| 25 | UI lows | Unchanged | Menu look-ahead 4 rows; `in-chain` unrolled 8 deep; `IconButton.label` a tooltip, not `accessible-label`. |
+| 26 | gRPC has none of the JSON caps | Unchanged | `grpc.rs:70, 129-175`. |
+| 27 | Chatterbox on phones; DirectML silent; `DirectML.dll` not staged | Unchanged | `concat/Cargo.toml:130`; `chatterbox.rs:305-313`; no `DirectML` in `build-app.yml`; `tts.rs:7` still says whisper is a child process. |
+| 28 | Windows signing secrets undeclared; password on argv | Unchanged | `build-app.yml:37-53, 716`. Repo secrets are the two Android ones only: the 0.2.6 Mac builds are ad-hoc signed, the Windows installers unsigned. |
+| S1 | The update trusts a digest beside the package; quarantine stripped | Unchanged | `updates.rs:45, 418, 477, 504, 551, 597`. |
+| S2 | The Remote API is rooted at home; no root without HOME; open-then-save | Unchanged | `concat-server/src/lib.rs:80-86`; `concat-api/src/lib.rs:244-246, 454-456`; `settings.rs:573-577`. |
+| S3 | Every JSON connection leaks an fd; seats before auth; accept spins | Unchanged | `json.rs:100-122`; `lib.rs:284-288`. |
+| S4 | Clear cache deletes reversed and enhanced media | Unchanged | `reverse.rs:88`, `enhance.rs:71`, `projects.rs:341-350`. |
+| S5 | 0.2.4 reversed or animated clips open silently changed | **Fixed** | b00ffab: `Editor::drop_retired_fields` strips them and names the clips. |
+| S6 | The embedded API opens a second GPU device | Unchanged | `concat-api/src/lib.rs:179`; `concat-export/src/lib.rs:1247-1250`. |
+| S8 | HDR proxy name and contents disagree | Unchanged | `proxy.rs:59-87, 208`; `studio.rs:2802-2829`. |
+| S9 | Hub: no `catch_unwind`, heavy work inline, slow subscriber dropped | **Partly fixed** | `catch_unwind` (67e4f9d, `hub.rs:91-104`; no effect under `--profile app`, 848d3c5); `pixels` still composites on the hub thread; the silent drop remains. |
+| S10 | Downgrade is one click | Unchanged | `settings.rs:461-468`. |
+| S11 | No ceiling on frame rate or size | **Partly fixed** | `FrameRate::checked` (e9f09df, `time.rs:351-358`) for documents and the export; file rates unbounded (`probe.rs:201`); size only `> 0`; a vast clip start panics the export (finding 9). |
+| S12 | Every undo snapshot clones the bin | Unchanged | `editor.rs:193`. |
+| S13 | The export is serial with a readback per frame; the mixer scans every clip per sample | Unchanged | `concat-export/src/lib.rs:1320-1475`; `playback.rs:1140-1170`. |
+| S14 | Font by absolute path; a missing font silent | Partial | The picker says when a family is missing (aee2d61); `fonts.add_file` result still dropped (`titles.rs:361`). |
+| S16, S17 | Server and host hygiene | Unchanged | Socket permissions, `connections()` counting subscribers, no `project.create` checks; two TLS stacks. |
+| S18 | Dead `core::Project`; `ui/demo/` compiled in | Unchanged | `timeline.rs:499-514`; `app.slint:21`. |
+
+Of 42 items: 11 fixed, 7 partly, 1 fixed-then-recurred, 21 unchanged, 2
+worse. The 4 October audit's recommended order (its section 8) was taken
+up in part: step 1 (fmt, locale isolation, the 0.2.6 section) in full;
+step 2 (`[[replaces]]`, keys, the open notice, trials at Max on a
+sibling) in full; step 3 (the stream start) in full; step 5's rate ladder
+and step 6's volume flush and art caches; steps 4, 7 and 8 not at all.
+
+---
+
+## 6. New findings, by severity
+
+Numbers continue from the re-verified table. Each names where to look.
+
+### High
+
+**1. A hand-started release builds `main`, not the tag it publishes.**
+`build-app.yml:152` and `mobile.yml:58, 173` check out with no `ref`;
+`release.yml:74-82` passes the build jobs no tag, while CI (`:67-72`) and
+`publish` (`:100-104`) do check the tag out. The v0.2.6 release was run
+37483649529, a `workflow_dispatch` at head `7b5cc44`; the tag `v0.2.6`
+resolves to `76c02c7`, 35 commits earlier. The shipped 0.2.6 binaries
+carry 35 commits the tag, the CHANGELOG section and the CI gate on the tag
+never saw. Fix: `ref: ${{ inputs.tag || github.ref }}` in both build
+workflows, passed from `release.yml`. (verified)
+
+**2. `main` has not been green for five days, and the gate is blocked by
+a hanging test.** The Windows job hangs in
+`concat-host cards::tests::every_card_draws_and_shows_its_package_at_work`
+and is killed at 90 minutes (runs 37521843321, 37624855588,
+37890980349); `release.yml:67-72` reuses `ci.yml`, so no tag can pass.
+The test draws every package on a GPU the runner does not have; it should
+skip where `WgpuCompositor::new()` is `None`, or run under a timeout, and
+the job should have one too. (verified)
+
+**3. The Android release key reaches pull-request builds and every
+dependency's build script.** `mobile.yml:36` runs on `pull_request` (a
+same-repo branch gets secrets) and on `workflow_dispatch` from any branch;
+`:113-130` decodes `ANDROID_KEYSTORE` into `$RUNNER_TEMP` and writes the
+password into `$GITHUB_ENV`, so `cargo apk build` (`:133-138`) and the
+build scripts of several hundred crates can read both; the signed APK of
+unmerged code is uploaded as an artifact (`:162-166`). Sign only on
+`release.yml` runs, and pass the password to the one step that signs.
+(verified)
+
+**4. An export with sound can leave a broken file at the chosen path and
+destroy the file that was there.** `audio::mux` opens the final `output`
+directly (`concat-media/src/audio.rs:720-721`; `format::output`
+truncates); on failure `render_on` removes `silent` and `mixed` only
+(`concat-export/src/lib.rs:992-996`). A mux failure (disk full, a read
+error) leaves a truncated mp4 where the user's previous export was. Only
+the no-audio path is atomic (`rename`, `:980`). The 4 October audit's
+section 7 claimed the export "cannot write a partial output"; that holds
+for the picture, not the sound. Mux into a third scratch name and
+rename. (verified)
+
+**5. The CJK fallback face shipped this morning covered half of
+Traditional Chinese and none of Japanese's own characters.** eb18dbd's
+subset was built from a Big5 sweep that walked only the `0x40-0x7E` trail
+bytes and no JIS set: 218 of the 972 characters in `zh-TW.json` and 121
+of the 673 in `ja.json` had no glyph (個 國 們 來; 両 働 円 図). The
+reviewer read the font's cmap; the test checked registration, not
+coverage. Fixed at the head: the subset holds GB 2312, Big5 level 1, JIS
+X 0208, the Hangul syllables and every character in the four locale files
+(2.7 MB), and `fonts::tests::the_cjk_face_covers_every_locale` reads the
+character map against the locale files. Kept here as a finding because it
+is the pattern of the week: a fix landed with a test that proved the
+wrong thing. (verified, fixed)
+
+### Medium
+
+**6. Native dialogs open while the `Studio` `RefCell` is mutably
+borrowed.** `handler!` holds `shell.studio.borrow_mut()` across the
+handler (`concat/src/lib.rs:446-456`); `ExportMsg::Browse`
+(`panes/export.rs:190-195`), `RelinkMsg::RelinkAll` (`relink.rs:55`) and
+`StartMsg::Browse` (`start.rs:142-144`) call `rfd` synchronously inside
+it, and `on_ui` closures (`host.rs:350-356`) open `save_file`
+(`studio.rs:5768, 6364`). `studio.rs:5755-5760` records that on macOS
+these dialogs pump Slint's timers, and the transport timer
+(`studio.rs:2645-2647`) and the meters timer (`meters.rs:79`) both
+`borrow_mut()`. A timer that fires during the dialog panics with
+`BorrowMutError`; Export → Browse while playing is the likely path.
+(reasoned, not reproduced)
+
+**7. The export sheet overwrites an existing file without asking and
+does not sanitise the name.** `panes/export.rs:427-431` builds
+`"{folder}/{name.trim()}.mp4"`; since 38e45a9 a name with `/` silently
+creates subfolders; an empty name writes a hidden `.mp4`; a same-name
+export replaces the previous file through `rename` or `mux`; no
+`exists()` check anywhere in the window; the path shown uses the
+untrimmed name (`:524-525`). (verified)
+
+**8. A frame wider or taller than 8192 panics wgpu, and nothing bounds
+it.** Devices are requested with `DeviceDescriptor::default()`
+(`gpu.rs:702`, limit 8192); no `on_uncaptured_error` handler is installed,
+so wgpu's default handler panics; the only cap is the API's `MAX_SIDE`
+(`concat-api/src/lib.rs:75, 885`); `render_on` and `preview_sources`
+never check the size (`concat-export/src/lib.rs:882-946`) and a document's
+`is_sane` is `> 0` (`model.rs:1953-1957`). A 10 000-px timeline from the
+window panics the export or preview thread. (verified)
+
+**9. A document with a vast clip start panics the export.** `Clip::tidy`
+floors `start` at 0 only (`model.rs:1474-1475`), so `"start": 1e300`
+loads; `quantise` saturates to `i64::MAX` (`resolve.rs:446-447`),
+`time_of_frame` multiplies by the rate, and `Rational::reduce` panics
+"rational overflowed i64" (`time.rs:100`). The same `reduce` is reached by
+file-derived rates, which `probe.rs:201` builds with no `MAX_TERM` check,
+against the crate's own rule at `time.rs:103-106`. (reasoned)
+
+**10. A SAFETY comment on `set_var` is not true as written.**
+`platform.rs:347-350` says the process is single-threaded there, but
+`Gpu::acquire()` (`:333`, `gpu.rs:58-66`) has already created a wgpu
+instance, adapter and device, and logging is open (`main.rs:13`). The
+branch runs only for software adapters (llvmpipe on Linux), which start
+threads that read the environment. Set the variable before `acquire`, or
+pass the setting through configuration. (verified)
+
+**11. Dragging a group past the timeline's start collapses the group or
+refuses the move.** The drag clamps each clip to 0 on its own
+(`studio.rs:4183`) and so does `resolve_moves` (`placement.rs:87`) before
+the group's shape is checked. Two adjacent clips (A at 1 s, B at 3 s, 2 s
+each) dragged left by 2 s become A [0,2) and B [1,3), overlap, and
+`resolve_moves` returns `None` (`:97-105`): the clips snap back. On
+different lanes they are reshaped instead of shifting by `−earliest`. No
+test. (reasoned)
+
+**12. A speed curve can grow a clip over its neighbour.**
+`SetClipSpeedCurve` lengthens the clip (`commands/properties.rs:285-306`)
+with none of the ripple faa6da9 gave `SetClipSpeed` (`:108-121`); the
+"no clip ever covers another" rule (`placement.rs:4-10`) is broken by one
+command. (verified)
+
+**13. Package reloads trial shaders on the window thread and leak a
+catalogue each time.** `reload_packages` runs every trial synchronously
+in the 2-second watch timer: three passes of up to 3 s per user package
+(`studio.rs:7226, 7238-7254, 7290-7320`); `install_with` rebuilds and
+`Box::leak`s a fresh catalogue on every reload (`catalogue.rs:962, 978`),
+each holding every built-in's stitched WGSL as `Arc<str>` (`shader.rs:922,
+936-945`), not the "few kilobytes" its doc claims (`catalogue.rs:946-947`).
+Also: `breaks()` counts a `break` inside a `switch` as leaving the loop
+(`shader.rs:1128-1136`), so `loop { switch x { default { break; } } }`
+passes `bounded`. (verified)
+
+**14. "Relink all" walks the chosen folder on the UI thread and follows
+symlinks with no loop guard.** `panes/relink.rs:73-92` is an unbounded
+`read_dir` walk inside `update`, while the studio is borrowed;
+`path.is_dir()` follows symlinks, so a link to an ancestor never ends.
+The "first match wins, closest to the root" comment (`:85-86`) is false
+below the top level: a LIFO stack walks depth-first. The toast is English
+(`:130-136`). (verified)
+
+**15. User-visible strings are hard-coded in Rust, and the new panes add
+more.** Menu rows `studio.rs:9362` "Freeze frame", `9766-9768` "Sort by:
+Added/Name/Type"; toasts `3492`, `6564`, `6979-6980`; `panes/relink.rs:131`;
+`panes/export.rs:534-536` "{clips} clips · {titles} titles", `:301`
+"{name} fps", `:614` "10-bit". `locales.py` only sees `t()` keys, so none
+reaches a translator. With the 4 October's list (`media-pane.slint:2293,
+598`, `text-panel.slint:176`, `controls.slint:100`, `tray.slint:319`) and
+the phone's category pills, that is about fifteen strings in five
+languages' worth of boxes. (verified)
+
+**16. `Server::stop` blocks the window until every running API export
+has finished.** `shut` closes the Hub and joins the dispatcher
+(`concat-server/src/lib.rs:293-296`), the dispatcher runs `api.finish()`
+(`hub.rs:107`), which joins the export threads
+(`concat-api/src/lib.rs:285-287, 740-744`) and cancels none; the Remote
+page calls `server.stop()` on the UI thread (`settings.rs:557-558`).
+Turning Remote off during an API export freezes the window for the rest
+of it. Related: API export jobs run on a bare thread with no
+`catch_unwind` (`:760-788`), so a panic ends the job with no event and a
+socket client waits forever; audio decode workers (`playback.rs:675-718`)
+likewise die on a panic and leave their span stuck, and with
+`DECODE_WORKERS = 2` two such panics end audio for the session. (verified)
+
+**17. API reads are unconfined, and caller strings go straight to
+FFmpeg's opener.** `media.probe`, `media.import` and template fills pass
+caller strings to `concat_media::probe` and `Decoder`
+(`concat-api/src/lib.rs:342-344, 462-465, 486-490`), which call
+`ffmpeg::format::input(path)` (`probe.rs:93`, `decode.rs:606`) with no
+protocol or format whitelist. A token holder can name URLs or
+`concat:`/`subfile:` paths, or render any readable file FFmpeg can demux
+and read it back as PNG through `preview.frame` (`:626-640`). Whether the
+linked FFmpeg has network protocols on was not verified. Related: a
+caller that stops reading pins its seat until the server stops, since the
+outbox writer has no write timeout (`json.rs:305-311, 331-338`). (verified
+to the opener; protocols unverified)
+
+**18. Frames that fail in the export's pool path vanish silently, while
+the paced path aborts.** `if let Ok(frame) = sought.frame_at(...)`
+(`concat-export/src/lib.rs:1333-1358`) has no `else` and no log, so a
+reversed clip, a speed-curve clip or a dissolve hold that fails to decode
+exports as a missing layer; `Decoder::open(...)?` and `next_frame()?`
+(`:1400, 1408`) end the export. One policy is needed; either is
+defensible, both at once is not. Related: the still fix of 89f5ddd holds
+only when a clip carries dimensions; without them both callers fall back
+to the frame size (`:1329-1332, 1367-1370, 1817-1820`) and the stretch of
+#229 returns for API requests and older documents. (verified)
+
+**19. Prefetch "pinned" frames sit outside the pool's byte budget, and
+nothing bounds them.** Released only when the cursor passes them
+(`prefetch.rs:292-295`), not capped, not cleared on `clear()`; a backward
+seek during forward play leaves everything pinned ahead in place. Deep
+4K frames are about 66 MB each, so a few seeks pin gigabytes the
+256 MB-1 GB budget (`pool.rs:577-584`) never sees. (verified)
+
+**20. A crashed voiceover take is lost although its samples are on
+disk.** `record.rs:279, 283-298` writes the WAV header with data size 0
+and fixes it only in `finish`; a kill, a crash or a failed `write`
+(`:159`) leaves a file whose header says 0 samples, which the reader
+honours (`playback.rs:197-201`). Writing the `0xFFFFFFFF` placeholder that
+`playback.rs:180-183` already accepts would keep the take playable.
+Related: `landing` is pane state read when the asynchronous probe returns
+(`panes/voiceover.rs:89, 141`), so two quick takes can land in each
+other's place. (verified)
+
+**21. Unverified downloads go into shipped binaries, and mutable action
+tags run with write access.** FFmpeg comes from BtbN's moving `latest`
+release (`ci.yml:31`, `build-app.yml:57, 180`) and is copied into every
+desktop bundle; sherpa-onnx, ONNX Runtime and the mobile FFmpeg
+(`ci.yml:76, 96`, `sherpa-mobile.sh:38, 56`, `ffmpeg-mobile.sh:38`) are
+fetched with no digest; actions are pinned by tag, including
+`softprops/action-gh-release@v3` with `contents: write`
+(`release.yml:88-89, 139`); `release.yml:48` pastes `${{ inputs.tag }}`
+into a shell script. The default token being read-only is the one good
+line here. (verified)
+
+**22. The Android bridge has three ways to lose an import or a crash
+path.** `copy` catches `IOException` only (`ConcatFiles.java:277`) on a
+bare thread, so a provider's `SecurityException` or
+`IllegalArgumentException` kills the process and `filesPicked` never
+comes; the headless `Fragment` lives in an `InMemoryDexClassLoader`
+(`lib.rs:166-182`), so a process killed while the picker is open fails
+to restore it ("Unable to instantiate fragment"); `publishVideo` ignores
+`resolver.update`'s row count (`:115`) and then deletes the original
+(`:132`), so a 0-row update leaves the only copy pending, hidden and
+later purged. `files_picked` is `extern "system"` with no `catch_unwind`
+(`lib.rs:280-282`). (reasoned for the restore; the rest verified)
+
+### Low
+
+**23. Doc drift, again.** gpu.rs says in four places that a dead
+compositor falls back to the CPU (`gpu.rs:623-626, 1165-1166, 1502-1504,
+3161-3164`); the CPU compositor is gone and `render` returns
+`Frame::black` (`:3241-3251`). `studio.rs:2082-2092` stacks two docs on
+`forget_art` and leaves `row_track` and `ask_remove_track` undocumented.
+`FrameRequest::cover`'s doc (`pool.rs:64-68`) no longer describes stills.
+`catalogue.rs:946-947` claims a few kilobytes. `ARCHITECTURE.md:240, 260`
+still name a quarter-size proxy and a hardware-decode switch.
+`concat.iss:66-70` claimed the vendored translations were all 6.7.1
+files; the Traditional Chinese one is a 6.1 file with 276 of 296
+messages (corrected at the head).
+
+**24. Tests that prove the wrong thing or never run.** The emoji test
+returns early where no colour face exists and CI installs none
+(`ci.yml:53-56`); `a_still_keeps_its_shape_on_the_monitor` `expect`s a
+GPU, so a machine with FFmpeg and no adapter fails rather than skips;
+`platform.rs`'s tests use `edge_at` and `ResizeDirection`, which are
+`cfg(not(android))`, so `cargo test --target aarch64-linux-android` does
+not compile (`platform.rs:82, 93, 760-793`); device-loss recovery is
+tested by calling `recovered()` directly, never through
+`render_picture`; `concat-server` has no test for fd release or a slow
+reader; `concat-cli` none for `api` or `serve`; `concat-android` none.
+
+**25. The Rational edges.** `Neg` and `ceil` overflow for `num ==
+i64::MIN`, which `checked_reduce` lets through (`time.rs:116-121,
+155-157, 250-256`); `AddClipAtFirstFree` accepts a negative start
+(`commands/clips.rs:49-62`) while every other add clamps; `record.rs:287,
+315` overflow the RIFF size after about 12 hours of mono 48 kHz; proxy
+names use `DefaultHasher` (`proxy.rs:66`) against the reasoning at
+`playback.rs:783-785`; a proxy job that panics is never retried or swept
+(`proxy.rs:136-149`).
+
+**26. HDR side data sized by a Rust mirror of structs FFmpeg says are
+not ABI.** `size_of::<MasteringDisplay>()` and `size_of::<ContentLight>()`
+at `encode.rs:532-537, 1073-1079, 1281-1287` against structs at `:751,
+798`; `av_mastering_display_metadata_alloc_size` and
+`av_content_light_metadata_alloc` exist for this. The SAFETY comments are
+true only while the mirror matches the linked FFmpeg.
+
+**27. Realtime audio does work it should not.** The mix callback drops
+the previous `Vec<ActiveClip>` on `SetClips` (`playback.rs:1107`), which
+can `munmap` on the audio thread; samples are read from the mmap
+(`:169-174`) so a cold page faults inside the callback; the recorder
+allocates per input callback (`record.rs:222-227`); a seek while playing
+can stamp the old position for one buffer (`:521-527, 1195`). The mmap's
+SAFETY (`:159`) holds within one process only: a sync tool truncating a
+project folder's PCM cache is a SIGBUS.
+
+**28. Blocking work on the UI thread, beyond finding 14.**
+`clear_project_cache` deletes the cache folder inline (`studio.rs:6978`);
+`open_project` runs `proxy::sweep` inline (`:6849-6862`);
+`adopt_reversed`/`adopt_enhanced` probe with FFmpeg inline (`:6052,
+6077`); `freeze_at_playhead` decodes and encodes inline (`:6582-6595`);
+`Fonts::new` copies 12 MB of embedded faces to the heap
+(`concat-text/src/lib.rs:323-325`) and PNG emoji strikes are decoded on
+every render (`:1005-1011, 1058`).
+
+**29. Hygiene.** `wayland_drop::receive` sets CLOEXEC after `pipe()`
+rather than with `pipe2` (`wayland_drop.rs:341-350`) and grows `bytes`
+without bound (`:365-377`); `i18n::fill` substitutes placeholders in
+sequence, so an argument containing `{1}` is replaced again
+(`i18n.rs:337-343`); `english().by_text` maps duplicate values to an
+arbitrary key (`:94-101`); `std::mem::take` routing lets a re-entrant read
+see a blank pane (`studio.rs:7085-7138`); the crate uses
+`slint::private_unstable_api` for focus loss and drags
+(`platform.rs:156`, `lib.rs:23`) on a caret version, now beside a vendored
+renderer; `Config.socket` is unlinked before the bind whatever it names
+(`concat-server/src/lib.rs:195`); the token goes on argv and stdout
+(`concat-cli/src/main.rs:84-85, 228-232`); `serve` parks with no signal
+handling (`:247-249`); `project.create` accepts any size (`concat-api/src/
+lib.rs:377-393`); a user package may still claim any id this catalogue
+lacks (`catalogue.rs:1047-1072`); `JObject::from_raw` wraps a global
+reference where jni 0.22 asks for a local one (`concat-android/src/
+lib.rs:139`), harmless today and unargued.
+
+---
+
+## 7. What is good, and should stay that way
+
+- **The placement rule is a model rule.** `concat-project/src/placement.rs`
+ decides where a clip lands, for the window, the API and the CLI alike,
+ with ten tests; the drag asks it as it goes so the echo shows where the
+ drop will land (faa6da9).
+- **`Catalogue::add` refuses every take-over with a reason**, the built-in
+ author is reserved, a LUT must be a plain `.cube` beside its manifest,
+ and `replacing` carries keyframes through the knob expression and clamps
+ them (`catalogue.rs:1021-1080, 552-622, 727-744`; `manifest.rs:533-537`).
+- **Model downloads are pinned to commit URLs with digests**, an empty
+ digest is refused, archives are verified before `unpack_in` into a
+ staging folder and renamed once (`chatterbox.rs:120-178`,
+ `transcribe.rs:118`, `concat-vision/src/models.rs:83-101`,
+ `concat-host/src/models.rs:295-301`, `tts.rs:522-580`).
+- **Rational time is done carefully**: i128 intermediates, `checked_new`
+ for file values, `FrameRate::checked` judged in lowest terms with a test
+ of 60000000/2002000 (`time.rs:100-122, 351-358, 445-456`).
+- **Hardware decode falls back at all three stages** (open, copy-back,
+ send) and `resume_in_software` picks up after the last delivered pts
+ (`decode.rs:640-647, 769-794, 830-843, 873-907`).
+- **The prefetcher cannot be wedged by a panic**: a `Finished` drop guard
+ plus `catch_unwind`, and the queued-vs-pinned read documented under one
+ lock order (`prefetch.rs:288-296, 415-450`).
+- **Constant-time token compare shared by both transports**, minted from
+ `getrandom`, bounded line reads before auth, a 10 s auth timeout, with
+ tests (`token.rs:16-36, 52-64`; `json.rs:35-40, 256-263, 385-414`).
+- **Atomic project save** (temp, `sync_all`, rename) and a session that
+ refuses a newer or unreadable document (`projects.rs:171-195`;
+ `session.rs:80-104`). The export's picture path is atomic the same way;
+ the sound path should be (finding 4).
+- **The epoch gate covers art now**, `spawn_frame` publishes only the
+ picture during playback, and `forget_art` drops every per-project cache
+ on open and close (`host.rs:197-254, 312-322`; `studio.rs:2093-2102`).
+- **`platform.rs` keeps platform differences in one file with the reason
+ and issue at each branch**, and the phone's publish hook is confined to
+ it, off the UI thread, a no-op on a desk (`platform.rs:336-351, 439-461,
+ 599-665`).
+- **`COLR` glyphs are probed, not trusted**: anything beyond solid layers
+ falls back to the outline; a strike that lies about its size is
+ rejected (`concat-text/src/lib.rs:630-713, 1056-1071`).
+- **Very few panics in the window**: three invariant `expect`s in 22.5k
+ lines, and a startup failure reaches the user through a native dialog
+ and the log (`lib.rs:126-130`).
+- **The fixes of the day each carry a test that fails without them**: the
+ still's shape reads the stage either side of the picture; the export
+ folder test asserts the folder whatever the GPU does; the CJK face is
+ held to the locale files' characters.
+
+---
+
+## 8. Where we stand
+
+The 4 October audit ended with eight recommended steps. Five days later:
+
+| Step (4 Oct) | Landed |
+|---|---|
+| 1. fmt, toolchain in CI, isolate the locale tests, write 0.2.6 | fmt and the locale lock, the 0.2.6 section; CI still on `stable`; 0.2.6 then built from `main` (finding 1) |
+| 2. `[[replaces]]` fence, keys through `replacing`, the open notice, trials at Max on a sibling | all four (ab1c482) |
+| 3. `AudioDecoder::open` takes the stream start, MTS fixture | done, 18 minutes after the audit (c6d7e17) |
+| 4. `DOCUMENT_VERSION` for shapes; `extra` for unknown kinds; `ClipPatch.shape`; round-trip all commands | nothing |
+| 5. locale check for English values; the six literals through `I18n`; export rate from the timeline; freeze keys at the hold | the rate (a2ba094); the rest open, and more literals arrived |
+| 6. Flush in `clip_volume`; gate art and save; publish-lanes-only frames | the flush and art (5c97f20, 2433bab, ee28f25); `save` still ungated |
+| 7. `FocusScope` on `Button`, Escape on `Modal`, `accessible-label` | Escape on the confirm sheet only |
+| 8. The 28 September list: sign the update, the Remote page's root and fd leak, processed media out of `cache/`, migration notices, the export pipeline, the API verbs | nothing; the API gap grew |
+
+Half the list was taken up, and taken up well: every item that landed
+has a test or a fixture, and two of the three headline findings of the
+4th are closed. What did not move is the same layer that has not moved
+since 28 September: the update chain, the server's seats and fds, the
+API's reach, the document's version. The week's new risk is in the
+release pipeline rather than the code: a release that is not what its
+tag says, a gate that cannot pass, and a signing key that every
+pull-request build can read. Those three are an afternoon.
+
+The fixes made during the audit followed the same shape as the week's:
+reported, reproduced where a machine allowed, fixed in one place with a
+test that fails without the fix, and explained to the reporter. One of
+them (the CJK face) was wrong on first landing and caught by this audit's
+own reviewer within hours, which is the argument for the audit cadence
+as much as for the reviewer.
+
+**Recommended order.** Each line is an hour to a few days, and each
+closes a finding above.
+
+1. `ref:` the tag in `build-app.yml` and `mobile.yml`; sign Android only
+ on release runs, password to the signing step alone; skip or time out
+ the cards test where there is no GPU, and give the Windows job a
+ timeout; `rust-toolchain.toml` into CI. Then tag 0.2.7 from a green
+ `main`. (1, 2, 3)
+2. Mux into a third scratch name and rename; one failure policy for the
+ export's two decode paths; a size ceiling in `is_sane` and in
+ `render_on`, with an `on_uncaptured_error` handler on every device;
+ bound `Clip::tidy` and probed rates. (4, 8, 9, 18)
+3. The export sheet: refuse `/` and an empty name, ask before
+ overwriting, show the trimmed path. Dialogs on the next loop turn
+ everywhere the studio is borrowed. (6, 7)
+4. Trials off the UI thread with one catalogue per reload; the relink
+ walk on a worker with a visited set; the cache clear and the sweep on
+ workers. (13, 14, 28)
+5. `Server::stop` cancels jobs first and runs off the UI; `catch_unwind`
+ on API jobs and decode workers; a protocol whitelist in front of
+ FFmpeg's opener; a write timeout on the outbox. (16, 17)
+6. The pinned-frame budget; the WAV placeholder header; the group clamp
+ by `−earliest`; ripple in `SetClipSpeedCurve`. (19, 20, 11, 12)
+7. The fifteen literals through `I18n`; a `locales.py` that flags English
+ values; the Rust-side strings as keys. (15, and the 4th's #4, #13)
+8. Digests for FFmpeg, sherpa and ONNX downloads; actions pinned by
+ SHA; `inputs.tag` through `env:`. (21)
+9. Look at Windows text at 100 % (3989e59) and a phone's export (63f2633)
+ on real hardware; neither has been seen. Then the 28 September list, in
+ its order.
+
+After those, phase 4 of the HDR plan (a true HDR preview), then phase 5,
+in the plan's order.
+
+---
+
+## 9. Caveats
+
+Scores are judgements over code, calibrated against the 4 October scores
+but not measured against users or another editor. Every crate was read
+in full by one of four reviewers; the headline findings were re-read by
+hand. Findings marked (verified) were read at the line and, where a
+command could show it, run; (reasoned) means the path was followed
+through the code and not executed. The perf table ran on a loaded
+machine and is a floor. The app was not launched on a desk; the 0.2.6
+APK ran on an emulator only as far as its window's first second, which
+was enough to read the encoder probe and not enough to drive the editor.
+Two of the day's fixes, Windows text and the phone's Movies publishing,
+have not been seen on the hardware they are for. `cargo audit` was not
+run.