The truly free, open-source, local-first, cross-platform CapCut replacement. Scriptable through a JSON-RPC API & MCP.
Rust ffmpegfree-video-editormodel-context-protocolnon-linear-editoroffline-firstopen-source-video-editorself-hostedvideo-editingvideo-editing-automationvideo-editing-softwarevideo-editing-toolsvideo-editorvoice-cloningyoutube-automationyoutube-shorts
fix(media): FFmpeg's log goes through the log facade, not standard error
Jareer54e55ea359c4
diff --git a/src/crates/concat-media/src/ffi.rs b/src/crates/concat-media/src/ffi.rsindex a24f2184..4a5a4709 100644--- a/src/crates/concat-media/src/ffi.rs+++ b/src/crates/concat-media/src/ffi.rs@@ -11,6 +11,7 @@ use std::sync::Once;use concat_core::time::Rational;use ffmpeg_the_third as ffmpeg;+use libc::{c_char, c_int, c_void};use crate::error::Error;@@ -20,13 +21,67 @@ pub fn init() {static ONCE: Once = Once::new();ONCE.call_once(|| {let _ = ffmpeg::init();- // Errors only: a GUI has no terminal, and FFmpeg's warnings are- // noise about files we are about to describe precisely in our own- // error messages.- ffmpeg::util::log::set_level(ffmpeg::util::log::Level::Error);+ // Warnings and up are formatted; where they go is `relay`'s+ // business, and by default that is nowhere a person sees.+ ffmpeg::util::log::set_level(ffmpeg::util::log::Level::Warning);+ // SAFETY: `relay` has the signature av_log_set_callback wants and+ // is `extern "C"`; it stays valid for the life of the process.+ unsafe { ffmpeg::sys::av_log_set_callback(Some(relay)) };});}+/// FFmpeg's log, through the `log` facade instead of standard error.+///+/// Left to itself FFmpeg prints on stderr, which a packaged GUI build has+/// wired to nowhere and a terminal run has wired to the person's screen:+/// a seek into long-GOP H.264 prints "mmco: unref short failure" once per+/// reference frame it cannot find, at FFmpeg's *error* level, twenty lines+/// for a scrub, about a picture that then decodes fine. Those are not+/// errors anyone acts on; the failures that matter come back through+/// `Result`s and are described precisely there. So a panic or a fatal+/// line is an error, and everything else is debug - off the console and+/// out of the file by default, and in the file the one time somebody+/// raises the level to read what FFmpeg saw.+unsafe extern "C" fn relay(+ context: *mut c_void,+ level: c_int,+ format: *const c_char,+ args: ffmpeg::sys::va_list,+) {+ let mut line = [0 as c_char; 1024];+ let mut print_prefix: c_int = 1;+ // SAFETY: the buffer is ours and its length is passed with it; the+ // context, format and arguments are what FFmpeg handed this callback+ // for exactly this call, and the formatter consumes the va_list once.+ let written = unsafe {+ ffmpeg::sys::av_log_format_line2(+ context,+ level,+ format,+ args,+ line.as_mut_ptr(),+ line.len() as c_int,+ &mut print_prefix,+ )+ };+ if written <= 0 {+ return;+ }+ line[line.len() - 1] = 0;+ // SAFETY: NUL-terminated by the formatter, and by the line above if the+ // message was longer than the buffer.+ let text = unsafe { CStr::from_ptr(line.as_ptr()) }.to_string_lossy();+ let text = text.trim_end();+ if text.is_empty() {+ return;+ }+ if level <= ffmpeg::sys::AV_LOG_FATAL {+ log::error!(target: "ffmpeg", "{text}");+ } else {+ log::debug!(target: "ffmpeg", "{text}");+ }+}+/// The version of FFmpeg this binary is linked against.////// The first thing worth checking when something behaves oddly: it proves