Skip to content

The truly free, open-source, local-first, cross-platform CapCut replacement. Scriptable through a JSON-RPC API & MCP.

ci: Windows runs the tests, and a release tests the tag it builds

Jareer9440a67fa2a6
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f3ad55f0..473a9ec3 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -8,11 +8,19 @@ on:
pull_request:
workflow_dispatch:
# release.yml runs this before it builds anything: a tag on a red tree
- # is not a release.
+ # is not a release. It names the tag, because a release started by hand
+ # runs on main, and main is not what it builds.
workflow_call:
+ inputs:
+ ref:
+ description: The ref to test, when it is not the one this runs on
+ type: string
+ default: ""
+# Keyed on what is tested, so a release testing its tag and a push to
+# main never cancel each other.
concurrency:
- group: ci-${{ github.ref }}
+ group: ci-${{ inputs.ref || github.ref }}
cancel-in-progress: true
jobs:
@@ -25,6 +33,8 @@ jobs:
ORT_VERSION: 1.28.0
steps:
- uses: actions/checkout@v7
+ with:
+ ref: ${{ inputs.ref }}
- uses: dtolnay/rust-toolchain@stable
with:
components: clippy, rustfmt
@@ -135,6 +145,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
+ with:
+ ref: ${{ inputs.ref }}
- uses: dtolnay/rust-toolchain@stable
with:
components: clippy
@@ -150,26 +162,32 @@ jobs:
-- -D warnings
working-directory: src
- # The window and the engine compiled where they ship. Linux is the job
+ # The window and the engine built where they ship. Linux is the job
# above; macOS and Windows used to be compiled only by a release tag,
- # which is where a broken platform path was found. A check, not the
- # tests: the dependencies are the same as build-app.yml's, and what this
- # catches is code that does not build on the platform.
+ # which is where a broken platform path was found. Windows runs the
+ # tests, because it is a primary desktop and its own failures (files
+ # held open, FFmpeg's filter threads) only show there; macOS is checked,
+ # not tested, and is tested where it is developed. No GPU on either
+ # runner: the GPU tests skip rather than fail.
desktop:
- name: Compiles on ${{ matrix.os }}
+ name: ${{ matrix.verb }} on ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
include:
- os: macos-15
sherpa: osx-arm64
+ verb: Compiles
- os: windows-2022
sherpa: win-x64
+ verb: Tests
runs-on: ${{ matrix.os }}
env:
FFMPEG_WINDOWS: https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n8.1-latest-win64-gpl-shared-8.1.zip
steps:
- uses: actions/checkout@v7
+ with:
+ ref: ${{ inputs.ref }}
- uses: dtolnay/rust-toolchain@stable
- name: FFmpeg (macOS)
if: runner.os == 'macOS'
@@ -208,9 +226,12 @@ jobs:
python3 -c "import tarfile; t = tarfile.open('sherpa.tar.bz2'); t.extractall('sherpa', **({'filter': 'data'} if hasattr(tarfile, 'data_filter') else {}))"
test -d "sherpa/$stem/lib"
if [ "$RUNNER_OS" = "Windows" ]; then
- mkdir -p sherpa-libs
+ mkdir -p sherpa-libs sherpa-dlls
cp "sherpa/$stem/lib/"*.lib sherpa-libs/
+ # The DLLs too: the test binaries load them as they start.
+ cp "sherpa/$stem/lib/"*.dll sherpa-dlls/
echo "SHERPA_ONNX_LIB_DIR=$(pwd -W)\\sherpa-libs" >> "$GITHUB_ENV"
+ echo "$(pwd -W)\\sherpa-dlls" >> "$GITHUB_PATH"
else
echo "SHERPA_ONNX_LIB_DIR=$PWD/sherpa/$stem/lib" >> "$GITHUB_ENV"
fi
@@ -219,4 +240,13 @@ jobs:
workspaces: src
key: check-${{ matrix.os }}
- run: cargo check --workspace --all-targets
+ if: runner.os != 'Windows'
+ working-directory: src
+ # One job at a time and no debug info, as on Linux. The timeout is
+ # for a hang: concat-media's tests once hung here for good.
+ - run: cargo test --workspace -j 1
+ if: runner.os == 'Windows'
+ timeout-minutes: 90
working-directory: src
+ env:
+ CARGO_PROFILE_DEV_DEBUG: "0"
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index b8a18644..407f5701 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -62,10 +62,14 @@ jobs:
echo "version=$version" >> "$GITHUB_OUTPUT"
# The engine's tests and lints, on the tagged commit: a tag on a red
- # tree is not a release.
+ # tree is not a release. Named, because a run started by hand is on
+ # main, and without the tag CI would test main instead.
engine:
name: CI
+ needs: check
uses: ./.github/workflows/ci.yml
+ with:
+ ref: ${{ needs.check.outputs.tag }}
build:
needs: [check, engine]