Skip to content

The truly free, open-source, local-first, cross-platform CapCut replacement. Scriptable through a JSON-RPC API & MCP.

The inspector's Effects tab is one section: filters have no chain to sit in

Jareerf968fc317284
diff --git a/engine/crates/concat/locales/en.json b/engine/crates/concat/locales/en.json
index c7f8efff..bfe845a2 100644
--- a/engine/crates/concat/locales/en.json
+++ b/engine/crates/concat/locales/en.json
@@ -300,7 +300,6 @@
"New project": "New project",
"Next frame": "Next frame",
"No effect on this clip yet. Pick one from the Library's Effects page.": "No effect on this clip yet. Pick one from the Library's Effects page.",
- "No filter on this clip yet. Pick one from the Library's Filters page.": "No filter on this clip yet. Pick one from the Library's Filters page.",
"No templates yet. Mark media as slots, then save this project as a template.": "No templates yet. Mark media as slots, then save this project as a template.",
"No voice to read with": "No voice to read with",
"No {0} matches that.": "No {0} matches that.",
diff --git a/engine/crates/concat/src/studio.rs b/engine/crates/concat/src/studio.rs
index c0ebd039..5b0f7f55 100644
--- a/engine/crates/concat/src/studio.rs
+++ b/engine/crates/concat/src/studio.rs
@@ -2224,20 +2224,10 @@ impl Studio {
// Show it: the applied chain is where the knobs are, and a card
// that did something with no visible result reads as a card that
// did nothing.
- let is_look = Catalogue::builtin()
- .packages()
- .find(|package| package.answers_to(id))
- .is_some_and(|package| package.kind() == PackageKind::Filter);
self.inspector_jump = (
self.inspector_jump.0 + 1,
if video { "Effects" } else { "Audio" },
- if !video {
- "Sound"
- } else if is_look {
- "Filters"
- } else {
- "Effects"
- },
+ if video { "Effects" } else { "Sound" },
);
}
diff --git a/engine/crates/concat/ui/inspector/clip-inspector.slint b/engine/crates/concat/ui/inspector/clip-inspector.slint
index 95c0db95..adf45431 100644
--- a/engine/crates/concat/ui/inspector/clip-inspector.slint
+++ b/engine/crates/concat/ui/inspector/clip-inspector.slint
@@ -37,8 +37,8 @@ import {
} from "../timeline/model.slint";
// The editor's clip inspector: one panel, three tabs. Adjust is direct
-// controls; Filters and Effects differ only in their catalogue, so both are
-// PresetStack with different data.
+// controls; Effects and Audio are each a PresetStack over their chain. A
+// filter is a layer on the lanes and gets FilterPanel, not a chain.
/// One parameter a preset exposes. `value` doubles as the default in the
/// catalogue: applying a preset copies the row, and double-click restores
diff --git a/engine/crates/concat/ui/workspace/config-pane.slint b/engine/crates/concat/ui/workspace/config-pane.slint
index 459dc11d..4004d503 100644
--- a/engine/crates/concat/ui/workspace/config-pane.slint
+++ b/engine/crates/concat/ui/workspace/config-pane.slint
@@ -20,8 +20,8 @@ import {
//
// - Nothing selected: the Details panel — the project's facts, read-only,
// with Modify pinned to the foot.
-// - Something selected: the clip inspector — Adjust, Filters and Effects,
-// or Text alone for a title.
+// - Something selected: the clip inspector — Video, Audio and Effects, or
+// Text alone for a title, or the layer panel for a filter on the lanes.
// One fact: muted label left, value right. The value wraps rather than
// elides — a folder path you cannot read is a path you have to go find.
@@ -129,14 +129,13 @@ export component ConfigPane inherits Rectangle {
// ── the clip inspector's chains, owned by Rust ───────────────────────
//
// The library shelves come from the effect catalogue, the applied lists
- // from the selected clip. Two chains: the picture's, which the Filters
- // and Effects tabs both edit, and the sound's, which Audio edits. A
- // `audio` flag on every callback says which.
+ // from the selected clip. Two chains: the picture's, which Effects
+ // edits, and the sound's, which Audio edits. A `audio` flag on every
+ // callback says which. A filter is neither: it is a layer on the lanes,
+ // with a panel of its own.
in property <[CatalogueEntryData]> catalogue-effects;
- in property <[CatalogueEntryData]> catalogue-filters;
in property <[CatalogueEntryData]> catalogue-audio;
in property <[string]> effect-groups;
- in property <[string]> filter-groups;
in property <[string]> audio-groups;
in property <[AppliedEntryData]> applied-visual;
in property <[AppliedEntryData]> applied-audio;
@@ -234,7 +233,7 @@ export component ConfigPane inherits Rectangle {
: ["Basic", "Speed", "Animation", "Adjust"])
: root.heading == "Audio"
? (root.is-audio ? ["Sound", "Speed"] : ["Sound"])
- : root.heading == "Effects" ? ["Filters", "Effects"]
+ : root.heading == "Effects" ? ["Effects"]
: root.heading == "Text" ? ["Text", "Animation"]
: ["Layer"];
/// The sections as the dropdown shows them; see `tabs-shown`.
@@ -243,7 +242,7 @@ export component ConfigPane inherits Rectangle {
: [I18n.t("Basic"), I18n.t("Speed"), I18n.t("Animation"), I18n.t("Adjust")])
: root.heading == "Audio"
? (root.is-audio ? [I18n.t("Sound"), I18n.t("Speed")] : [I18n.t("Sound")])
- : root.heading == "Effects" ? [I18n.t("Filters"), I18n.t("Effects")]
+ : root.heading == "Effects" ? [I18n.t("Effects")]
: root.heading == "Text" ? [I18n.t("Text"), I18n.t("Animation")]
: [I18n.t("Layer")];
@@ -279,9 +278,7 @@ export component ConfigPane inherits Rectangle {
if (root.jump-tab == "Video") { root.tab = 0; }
else if (root.jump-tab == "Audio") { root.tab = root.is-audio ? 0 : 1; }
else if (root.jump-tab == "Effects") { root.tab = root.tabs.length - 1; }
- if (root.jump-section == "Effects") { root.pick-section(1); }
- else if (root.jump-section == "Filters") { root.pick-section(0); }
- else { root.pick-section(0); }
+ root.pick-section(0);
}
changed jump-token => { root.jump(); }
init => { root.jump(); }
@@ -604,30 +601,8 @@ export component ConfigPane inherits Rectangle {
}
}
- // Filters and Effects share one chain — a look and a blur
- // are links of the same picture chain, in one order — and
- // differ only in which shelves they offer.
- if root.showing == "Filters": PresetStack {
- noun: I18n.t("filter");
- library-title: I18n.t("Filters");
- library: false;
- empty-note: I18n.t("No filter on this clip yet. Pick one from the Library's Filters page.");
- shelf: 0;
- group-labels: root.filter-groups;
- catalogue: root.catalogue-filters;
- applied: root.applied-visual;
- params: root.visual-params;
-
- add(id) => { root.chain-add(false, id); }
- toggle(index) => { root.chain-toggle(false, index); }
- move-by(index, delta) => { root.chain-move-by(false, index, delta); }
- remove(index) => { root.chain-remove(false, index); }
- set-param(index, key, value) => {
- root.chain-set-param(false, index, key, value);
- }
- commit => { root.clip-commit(); }
- }
-
+ // The picture's chain. Filters are not in it: a filter is a
+ // layer on the lanes, edited in its own panel.
if root.showing == "Effects": PresetStack {
noun: I18n.t("effect");
library-title: I18n.t("Effects");
diff --git a/engine/crates/concat/ui/workspace/seat.slint b/engine/crates/concat/ui/workspace/seat.slint
index a85d995e..7345f9b2 100644
--- a/engine/crates/concat/ui/workspace/seat.slint
+++ b/engine/crates/concat/ui/workspace/seat.slint
@@ -197,10 +197,8 @@ export component Seat inherits Rectangle {
remove-effect(id) => { Editor.remove-effect(id); }
catalogue-effects: Editor.catalogue-effects;
- catalogue-filters: Editor.catalogue-filters;
catalogue-audio: Editor.catalogue-audio;
effect-groups: Editor.effect-groups;
- filter-groups: Editor.filter-groups;
audio-groups: Editor.audio-groups;
applied-visual: Editor.applied-visual;
applied-audio: Editor.applied-audio;