Building 70 Projects ranging from beginner to advanced so anyone can β learn from, build upon, use as a reference, or even copy directly. Owned by my cybersecurity company π
Go aicertificationcloud-engineeringcybercybersecuritycybersecurity-analystcybersecurity-certificationcybersecurity-certificationscybersecurity-educationcybersecurity-jobscybersecurity-portfoliocybersecurity-projectscybersecurity-toolsgrchackinglearningpentestingproject-repositoryprojetcspython
fix(lisdex): B6 - every parallel campaign printed a false "fuzzes nothing" alarm
CarterPerez-devb4b508a89fae
diff --git a/PROJECTS/advanced/zero-day-vulnerability-scanner/crates/lisdex-fuzz/src/runner.rs b/PROJECTS/advanced/zero-day-vulnerability-scanner/crates/lisdex-fuzz/src/runner.rsindex fd826d99..acebb4db 100644--- a/PROJECTS/advanced/zero-day-vulnerability-scanner/crates/lisdex-fuzz/src/runner.rs+++ b/PROJECTS/advanced/zero-day-vulnerability-scanner/crates/lisdex-fuzz/src/runner.rs@@ -286,7 +286,7 @@ pub fn read_stats(findings: &Path) -> Result<FuzzerStats, RunnerError> {}pub fn read_stats_text(findings: &Path) -> Result<String, RunnerError> {- let path = findings.join(DEFAULT_INSTANCE).join(STATS_FILE_NAME);+ let path = primary_instance(findings)?.join(STATS_FILE_NAME);Ok(std::fs::read_to_string(path)?)}@@ -465,9 +465,11 @@ pub fn run(options: &AflOptions) -> Result<RunOutcome, RunnerError> {}let status = command.status()?;let measured = read_stats(&options.findings).map_err(|cause| match cause {- RunnerError::Io(_) if !status.success() => RunnerError::AflFailed {- status: status.to_string(),- },+ RunnerError::Io(_) | RunnerError::NoInstance { .. } if !status.success() => {+ RunnerError::AflFailed {+ status: status.to_string(),+ }+ }other => other,})?;Ok(RunOutcome {@@ -880,4 +882,52 @@ mod tests {let findings = scratch("empty");assert!(discover_crash_inputs(&findings).unwrap().is_empty());}++ fn instance_with_stats(findings: &Path, name: &str, body: &str) {+ let dir = findings.join(name);+ std::fs::create_dir_all(&dir).unwrap();+ std::fs::write(dir.join(STATS_FILE_NAME), body).unwrap();+ }++ #[test]+ fn stats_are_readable_from_a_parallel_campaign_that_has_no_default_instance() {+ let findings = scratch("parallel-stats");+ instance_with_stats(&findings, MAIN_INSTANCE, "execs_done : 41\n");+ instance_with_stats(&findings, "secondary1", "execs_done : 7\n");+ assert!(+ !findings.join(DEFAULT_INSTANCE).is_dir(),+ "the fixture must isolate the signal: a parallel campaign names its instances main and secondaryN, and never creates default"+ );++ let text = read_stats_text(&findings).expect(+ "a campaign run with --jobs > 1 writes no default/ directory, so reading stats from a hardcoded default path fails on every parallel run - which is how lisdex is documented to be run",+ );+ assert!(+ text.contains("41"),+ "and it must read the MAIN instance, not a secondary"+ );+ }++ #[test]+ fn a_single_instance_campaign_still_reads_its_default_directory() {+ let findings = scratch("single-stats");+ instance_with_stats(&findings, DEFAULT_INSTANCE, "execs_done : 99\n");+ let text = read_stats_text(&findings).unwrap();+ assert!(+ text.contains("99"),+ "afl-fuzz with no -M/-S writes default/, and that path must keep working"+ );+ }++ #[test]+ fn stats_from_an_empty_findings_directory_are_an_error_not_a_silent_default() {+ let findings = scratch("no-instance");+ assert!(+ matches!(+ read_stats_text(&findings),+ Err(RunnerError::NoInstance { .. })+ ),+ "no instance wrote stats, and inventing a reading from that is worse than saying so"+ );+ }}