Skip to content

A team of long-lived bots for DeepSeek Harness, with main bots, bot-to-bot messages and group chats.

Accept Playwright's allowAndName download behavior

Fei24111787a9861773
diff --git a/app/src/bot-views.mjs b/app/src/bot-views.mjs
index 4d2d311a..64936579 100644
--- a/app/src/bot-views.mjs
+++ b/app/src/bot-views.mjs
@@ -485,7 +485,8 @@ export class BotViews {
try {
if (method === 'Browser.getVersion') { reply({ protocolVersion: '1.3', product: `Chrome/${process.versions.chrome}`, userAgent: `Electron/${process.versions.electron} Chrome/${process.versions.chrome}`, jsVersion: process.versions.v8 }); return }
if (method === 'Browser.setDownloadBehavior') {
- const downloadPath = params.behavior === 'allow' ? this.#allowedDownloadPath(botId, params.downloadPath) : undefined
+ const allowsDownloads = params.behavior === 'allow' || params.behavior === 'allowAndName'
+ const downloadPath = allowsDownloads ? this.#allowedDownloadPath(botId, params.downloadPath) : undefined
this.#downloadPaths.set(botId, downloadPath)
for (const entry of targets()) entry.downloadPath = downloadPath
reply({}); return
diff --git a/app/test/bot-views.test.mjs b/app/test/bot-views.test.mjs
index 68e633f3..736a7f21 100644
--- a/app/test/bot-views.test.mjs
+++ b/app/test/bot-views.test.mjs
@@ -170,7 +170,7 @@ test('CDP download behavior saves to the Bot path and emits download events', as
const discovered = await request(socket, 1, 'Target.attachToTarget', { targetId: entry.tabId, flatten: true })
assert.ok(discovered.result.sessionId)
const sessionId = discovered.result.sessionId
- await request(socket, 2, 'Browser.setDownloadBehavior', { behavior: 'allow', downloadPath })
+ await request(socket, 2, 'Browser.setDownloadBehavior', { behavior: 'allowAndName', downloadPath })
const events = []
let resolveEvents
const eventsReady = new Promise(resolve => { resolveEvents = resolve })
@@ -250,7 +250,7 @@ test('cancelling a relay download removes its save path', async t => {
const socket = await openSocket(await manager.endpoint('a'))
t.after(() => socket.close())
await request(socket, 1, 'Target.attachToTarget', { targetId: entry.tabId, flatten: true })
- await request(socket, 2, 'Browser.setDownloadBehavior', { behavior: 'allow', downloadPath })
+ await request(socket, 2, 'Browser.setDownloadBehavior', { behavior: 'allowAndName', downloadPath })
const events = []
socket.on('message', raw => {
const message = JSON.parse(raw.toString())
@@ -294,7 +294,7 @@ test('CDP rejects outside, traversal, and symlink download paths and cancels dow
]
let id = 2
for (const downloadPath of refusedPaths) {
- await request(socket, id++, 'Browser.setDownloadBehavior', { behavior: 'allow', downloadPath: rootPath })
+ await request(socket, id++, 'Browser.setDownloadBehavior', { behavior: 'allowAndName', downloadPath: rootPath })
const response = await request(socket, id++, 'Browser.setDownloadBehavior', { behavior: 'allow', downloadPath })
assert.deepEqual(response.result, {})
let prevented = false
@@ -308,7 +308,7 @@ test('CDP rejects outside, traversal, and symlink download paths and cancels dow
assert.equal(prevented, true)
assert.equal(savePath, undefined)
}
- await request(socket, id++, 'Browser.setDownloadBehavior', { behavior: 'allow', downloadPath: rootPath })
+ await request(socket, id++, 'Browser.setDownloadBehavior', { behavior: 'allowAndName', downloadPath: rootPath })
await request(socket, id, 'Browser.setDownloadBehavior', { behavior: 'deny', downloadPath: rootPath })
let denied = false
const item = Object.assign(new EventEmitter(), {
@@ -329,7 +329,7 @@ test('CDP accepts a direct Playwright artifacts directory under os.tmpdir()', as
const socket = await openSocket(await manager.endpoint('a'))
t.after(() => socket.close())
await request(socket, 1, 'Target.attachToTarget', { targetId: entry.tabId, flatten: true })
- const response = await request(socket, 2, 'Browser.setDownloadBehavior', { behavior: 'allow', downloadPath })
+ const response = await request(socket, 2, 'Browser.setDownloadBehavior', { behavior: 'allowAndName', downloadPath })
assert.deepEqual(response.result, {})
let savePath
const item = Object.assign(new EventEmitter(), {