Skip to content

A team of long-lived bots for DeepSeek Harness, with main bots, bot-to-bot messages and group chats.

Merge dev into fix/200-room-commit

Fei24112c0f019e95d7
diff --cc ds-bot/src/host/groups.js
index e77ae53b,3750a7ce..77384028
--- a/ds-bot/src/host/groups.js
+++ b/ds-bot/src/host/groups.js
@@@ -363,16 -416,12 +425,17 @@@ export function install(rt)
round.replies.push({ kind: 'failed', botId: member.id, name: member.name, color: member.color, code: 'SESSION', text: String(error?.message ?? error).slice(0, 300), time: Date.now() })
continue
}
+ if (session === undefined) {
+ round.speaking = null
+ slot.status = 'left'
+ continue
+ }
+ await loadGroupLines(room)
const prompt = roomPrompt(room, member, round)
round.shown?.push(member.id)
- const text = session.brief === undefined ? prompt : `${session.brief}\n\n${prompt}`
+ const text = session.brief === undefined ? prompt.text : `${session.brief}\n\n${prompt.text}`
const said = []
- const reply = await roomTurn(room, member, session.id, text, slot.note ?? 'your turn', signal, round, slot.by, said)
+ const reply = await roomTurn(room, member, session.id, { text, files: prompt.files }, slot.note ?? 'your turn', signal, round, slot.by, said)
round.speaking = null
const final = typeof reply === 'string' && !isPass(reply) ? reply : undefined
if (reply?.failure !== undefined) {
diff --cc ds-bot/src/host/store.js
index f80f3aba,a0bdc8ab..f97eb789
--- a/ds-bot/src/host/store.js
+++ b/ds-bot/src/host/store.js
@@@ -160,16 -160,24 +160,34 @@@ export function install(rt)
room.notice ??= ''
migrated = true
}
+ // A Bot deleted while a group was made or changed could stay listed in it, even as its
+ // admin; it leaves the group now.
+ for (const room of Object.values(state.rooms)) {
+ const members = room.members.filter(id => state.bots[id])
+ const admin = members.includes(room.admin) ? room.admin : null
+ if (members.length === room.members.length && admin === room.admin) continue
+ room.members = members
+ room.admin = admin
+ migrated = true
+ }
+ // Teams from before #206 kept every long message whole in this file, written whole on
+ // every save. A message between Bots is whole in its recipient's Session; a group
+ // line's whole text moves to a file of its own, which only the writing host makes.
+ const writer = holder === undefined && stuck === undefined
+ for (const entry of state.exchanges) {
+ if (typeof entry.text !== 'string' || entry.text.length <= TEXT_KEPT || entry.length !== undefined) continue
+ entry.length = entry.text.length
+ entry.text = headOf(entry.text, TEXT_KEPT)
+ migrated = true
+ }
+ for (const room of writer ? Object.values(state.rooms) : []) {
+ if (!Array.isArray(room.log)) continue
+ const log = room.log.map(line => (typeof line.text === 'string' && line.length === undefined && typeof line.seq === 'number' ? rt.keepGroupLine(room.id, line, line.text) : line))
+ if (log.some((line, index) => line !== room.log[index])) {
+ room.log = log
+ migrated = true
+ }
+ }
// Unnamed groups from before names followed their members may still list old names.
const stale = Object.values(state.rooms).filter(room => !room.named && room.name !== rt.autoRoomName(room.members))
for (const room of stale) room.name = rt.autoRoomName(room.members)
diff --cc ds-bot/test/rounds.test.js
index 8342899b,196c8ea3..880ab0a5
--- a/ds-bot/test/rounds.test.js
+++ b/ds-bot/test/rounds.test.js
@@@ -348,37 -348,143 +348,178 @@@ test('a message sent between rounds sti
assert.deepEqual(result.replies.map(reply => reply.name ?? 'User'), ['Chief', 'Writer'])
})
+// A member deleted while its group Session is made sits the round out; the Session it was
+// getting belongs to no one, so it is archived instead of left over.
+test('a member deleted while its group Session is made is left out, and the Session is not kept', async (t) => {
+ const { call, emit, userMessage, relay, answer, stop, sent, ctx, rt } = start()
+ t.after(stop)
+ const room = await team(call, sent)
+ const writer = rt.state.rooms[room.id].members.find(id => !rt.isMain(id))
+ const archived = []
+ ctx.workspaceRegistry.archiveSession = async (sessionId) => { archived.push(sessionId) }
+ await emit(room.id, userMessage('Start'))
+ const running = relay(room.id, 'relay')
+ const first = await turnFor(sent)
+
+ let release
+ const gate = new Promise(resolve => { release = resolve })
+ let made
+ const making = new Promise(resolve => { made = resolve })
+ const create = ctx.sessionController.create
+ ctx.sessionController.create = async (options) => {
+ const result = await create(options)
+ made(result.sessionId)
+ await gate
+ return result
+ }
+ await answer(first.sessionId, first.message.source.exchangeId, 'Chief here.', 1)
+ const sessionId = await making
+ assert.equal((await call('delete-bot', { id: writer })).ok, true)
+ release()
+
+ const result = JSON.parse(await running)
+ assert.deepEqual(result.replies.map(reply => [reply.kind ?? 'reply', reply.name]), [['reply', 'Chief']])
+ assert.ok(archived.includes(sessionId))
+ assert.equal(rt.state.rooms[room.id].sessions?.[writer], undefined)
+})
++
+ // #206: state.json is written whole on every save, so a long group line keeps its start
+ // there and its whole text in a file of its own. Members still read it whole.
+ test('a long group line keeps its start in state.json, and members and read_group_chat read it whole', async (t) => {
+ const { call, emit, userMessage, relay, answer, stop, sent, ctx, home, rt } = start()
+ t.after(() => rmSync(home, { recursive: true, force: true, maxRetries: 5 }))
+ const room = await team(call, sent)
+ const long = `${'长'.repeat(9000)}结尾`
+ await emit(room.id, userMessage('Write it all out'))
+ const running = relay(room.id, 'relay')
+ const first = await turnFor(sent)
+ await answer(first.sessionId, first.message.source.exchangeId, long, 1)
+ const second = await turnFor(sent, first)
+ assert.ok(second.message.content[0].text.includes(long), 'the next member reads the line whole')
+ await answer(second.sessionId, second.message.source.exchangeId, 'Thanks.', 2)
+ assert.equal(JSON.parse(await running).replies[0].text, long)
+
+ await rt.save()
+ const saved = JSON.parse(readFileSync(join(home, 'state.json'), 'utf8')).rooms[room.id].log.find(line => line.length !== undefined)
+ assert.equal(saved.text.length, 2000)
+ assert.equal(saved.length, long.length)
+ assert.equal(readFileSync(join(home, 'group-lines', room.id, `${saved.seq}.txt`), 'utf8'), long)
+ const read = ctx.registeredTools.get('read_group_chat')
+ const exec = { agent: { id: first.sessionId } }
+ assert.match(await read.execute({ group: 'R1' }, exec), new RegExp(`cut; ${long.length} characters in all; read_group_chat with seq ${saved.seq} reads it whole`))
+ assert.ok((await read.execute({ group: 'R1', seq: saved.seq }, exec)).endsWith(long))
+ await stop({ keep: true })
+
+ // The log is full (60 lines) when DSH starts again, the long line second oldest.
+ const file = join(home, 'state.json')
+ const onDisk = JSON.parse(readFileSync(file, 'utf8'))
+ const kept = onDisk.rooms[room.id]
+ const fillers = Array.from({ length: 60 - kept.log.length }, (_, at) => ({ who: 'User', text: `line ${at}`, seq: kept.seq + at + 1 }))
+ kept.log = [...kept.log, ...fillers]
+ kept.seq += fillers.length
+ writeFileSync(file, JSON.stringify(onDisk))
+
+ // After a restart the whole line is read back from its file.
+ const again = start({ home })
+ t.after(() => again.stop({ keep: true }))
+ await again.call('state', {})
+ const whole = await again.ctx.registeredTools.get('read_group_chat').execute({ group: 'R1', seq: saved.seq }, exec)
+ assert.ok(whole.endsWith(long))
+
+ // The file goes with the line once the log moves past it, and with the group.
+ await again.emit(room.id, again.userMessage('Next'))
+ const next = again.relay(room.id, 'relay-2')
+ const one = await turnFor(again.sent)
+ await again.answer(one.sessionId, one.message.source.exchangeId, 'One.', 3)
+ const two = await turnFor(again.sent, one)
+ await again.answer(two.sessionId, two.message.source.exchangeId, 'Two.', 4)
+ await next
+ await waitFor(() => (existsSync(join(home, 'group-lines', room.id, `${saved.seq}.txt`)) ? undefined : true))
+ assert.equal(existsSync(join(home, 'group-lines', room.id, `${saved.seq}.txt`)), false)
+ await again.call('delete-room', { id: room.id })
+ await waitFor(() => (existsSync(join(home, 'group-lines', room.id)) ? undefined : true))
+ assert.equal(existsSync(join(home, 'group-lines', room.id)), false)
+ })
+
+ test('a group line longer than a member reads is cut in its prompt, with its length, and its file keeps only that', async (t) => {
+ const { call, emit, userMessage, relay, answer, stop, sent, home, rt } = start()
+ t.after(stop)
+ const room = await team(call, sent)
+ await emit(room.id, userMessage('Go'))
+ const running = relay(room.id, 'relay')
+ const first = await turnFor(sent)
+ await answer(first.sessionId, first.message.source.exchangeId, 'x'.repeat(25_000), 1)
+ const second = await turnFor(sent, first)
+ const prompt = second.message.content[0].text
+ assert.ok(prompt.includes(`${'x'.repeat(20_000)}… (cut; 25000 characters in all)`))
+ assert.ok(!prompt.includes('x'.repeat(20_001)))
+ await answer(second.sessionId, second.message.source.exchangeId, 'Ok.', 2)
+ await running
+ const line = rt.state.rooms[room.id].log.find(entry => entry.length === 25_000)
+ assert.equal(readFileSync(join(home, 'group-lines', room.id, `${line.seq}.txt`), 'utf8').length, 20_000)
+ })
+
+ // 公开#176: a PDF the user sent in a group reached neither the log nor any member, so
+ // every Bot said it could not read it; in a Bot's own chat the same file worked.
+ test('a file the user sends in a group reaches each member the line is shown to, once', async (t) => {
+ const { call, emit, relay, answer, stop, sent, rt } = start()
+ t.after(stop)
+ const room = await team(call, sent)
+ const pdf = { attachmentId: 'sha256:39cb3dab00', name: 'report-XYZ176.pdf', bytes: 607 }
+ await emit(room.id, { type: 'user/message', data: { source: { kind: 'user' }, content: [{ type: 'text', text: 'Read this PDF' }, { type: 'file', attachment: pdf }] } })
+ let running = relay(room.id, 'r1')
+ const first = await turnFor(sent)
+ const files = message => message.content.filter(block => block.type === 'file').map(block => block.attachment)
+ assert.deepEqual(files(first.message), [pdf])
+ assert.match(first.message.content[0].text, /User: Read this PDF\n\[File "report-XYZ176\.pdf" \(607 bytes\) attached\]/)
+ await answer(first.sessionId, first.message.source.exchangeId, 'Reading it.', 1)
+ const second = await turnFor(sent, first)
+ assert.deepEqual(files(second.message), [pdf])
+ await answer(second.sessionId, second.message.source.exchangeId, 'Me too.', 2)
+ await running
+ assert.deepEqual(rt.roomOf(room.id).log.find(line => line.who === 'User').files, [pdf])
+
+ sent.length = 0
+ await emit(room.id, { type: 'user/message', data: { source: { kind: 'user' }, content: [{ type: 'text', text: 'Thanks' }] } })
+ running = relay(room.id, 'r2')
+ const next = await turnFor(sent)
+ assert.deepEqual(files(next.message), [])
+ await answer(next.sessionId, next.message.source.exchangeId, 'OK.', 3)
+ const after = await turnFor(sent, next)
+ await answer(after.sessionId, after.message.source.exchangeId, 'OK.', 4)
+ await running
+ })
+
+ // #206: a Bot's post past 20,000 characters goes as a file; the line keeps the file and
+ // each member it is shown to gets it with its prompt.
+ test('a long post goes to the group as a file, and reaches the member with its prompt', async (t) => {
+ const { call, emit, relay, answer, stop, sent, ctx, rt } = start()
+ t.after(stop)
+ const store = fakeAttachments()
+ ctx.get = name => (name === 'attachments' ? store : undefined)
+ const room = await team(call, sent)
+ const chief = rt.state.mainBotIds[0]
+ const long = `${Array.from({ length: 400 }, (_, at) => `第 ${at + 1} 行:${'报告内容。'.repeat(10)}`).join('\n')}\n结尾`
+ const posted = await ctx.registeredTools.get('post_to_group').execute({ group: 'R1', message: long }, { agent: { id: rt.chatOf(chief) } })
+ assert.match(posted, /^Posted in "R1"/)
+ const post = sent.find(entry => entry.sessionId === room.id && entry.message.source.role === 'post')
+ const file = post.message.content.find(block => block.type === 'file')?.attachment
+ assert.equal(file?.name, 'Post from Chief.txt')
+ assert.equal(post.message.source.length, long.length)
+ assert.equal(new TextDecoder().decode(store.files.get(file.attachmentId)), long)
+
+ sent.length = 0
+ await emit(room.id, { type: 'user/message', data: { source: post.message.source, content: post.message.content } })
+ const running = relay(room.id, 'relay')
+ const turn = await turnFor(sent)
+ assert.deepEqual(turn.message.content.filter(block => block.type === 'file').map(block => block.attachment), [file])
+ const prompt = turn.message.content[0].text
+ assert.ok(prompt.includes(`Chief: [A long message: ${long.length} characters.`))
+ assert.ok(prompt.includes(`[File "Post from Chief.txt" (${file.bytes} bytes) attached]`))
+ assert.ok(prompt.length < 6000, `the prompt has ${prompt.length} characters`)
+ await answer(turn.sessionId, turn.message.source.exchangeId, 'Read it.', 1)
+ await running
+ const line = rt.state.rooms[room.id].log.find(entry => entry.botId === chief)
+ assert.deepEqual(line.files, [file])
+ assert.equal(line.length, undefined, 'the line is short; no file of its own')
+ })