A team of long-lived bots for DeepSeek Harness, with main bots, bot-to-bot messages and group chats.
Key a group post's reactions by its own event
Fei2411698abfe85a4f
diff --git a/ds-bot/client.js b/ds-bot/client.jsindex 9b5e894a..73dada99 100644--- a/ds-bot/client.js+++ b/ds-bot/client.js@@ -4174,7 +4174,7 @@ function TriggerCell({ node, sessionId, useRoster, useSessions, useTurnClock, usif (source.failed !== void 0 || source.resumed === true || source.stopped === true) return null;const room2 = roster.roomsById[sessionId];const poster = roster.byId[source.senderSessionId] ?? { id: source.senderSessionId, name: source.senderName ?? t("a Bot"), color: "gray" };- return (0, import_react6.createElement)(GroupMessage, { bot: poster, text: stripHeader(contentText(data.content)), room: room2, roster, actions, msgKey: `${sessionId}:${data.turn}:post`, useUi });+ return (0, import_react6.createElement)(GroupMessage, { bot: poster, text: stripHeader(contentText(data.content)), room: room2, roster, actions, msgKey: `${sessionId}:post:${data.seq ?? node.key}`, useUi });}if (source.role === "report") {return (0, import_react6.createElement)(GroupEvent, { prefix: t("Replies from"), room: roster.roomsById[source.roomId], name: t("a group chat"), roster, actions });diff --git a/ds-bot/src/client/cells.js b/ds-bot/src/client/cells.jsindex 2695e45d..e16c9ea6 100644--- a/ds-bot/src/client/cells.js+++ b/ds-bot/src/client/cells.js@@ -356,7 +356,8 @@ export function TriggerCell({ node, sessionId, useRoster, useSessions, useTurnClif (source.failed !== undefined || source.resumed === true || source.stopped === true) return nullconst room = roster.roomsById[sessionId]const poster = roster.byId[source.senderSessionId] ?? { id: source.senderSessionId, name: source.senderName ?? t('a Bot'), color: 'gray' }- return h(GroupMessage, { bot: poster, text: stripHeader(contentText(data.content)), room, roster, actions, msgKey: `${sessionId}:${data.turn}:post`, useUi })+ // A trigger's data carries no turn; its event seq is the one durable name of this post.+ return h(GroupMessage, { bot: poster, text: stripHeader(contentText(data.content)), room, roster, actions, msgKey: `${sessionId}:post:${data.seq ?? node.key}`, useUi })}if (source.role === 'report') {return h(GroupEvent, { prefix: t('Replies from'), room: roster.roomsById[source.roomId], name: t('a group chat'), roster, actions })diff --git a/ds-bot/test/tool-cells.test.js b/ds-bot/test/tool-cells.test.jsindex ec43fb05..e8b29285 100644--- a/ds-bot/test/tool-cells.test.js+++ b/ds-bot/test/tool-cells.test.js@@ -378,3 +378,48 @@ test('a goal round draws nothing, while another unknown trigger keeps its eventassert.equal(trigger({ kind: 'goal', goalId: 'goal-1', revision: 1, round: 1 }), null)assert.match(text(trigger({ kind: 'webhook' })), /<goal_round>Keep going/)})++// #212: the chat hands a trigger its event (seq, content, source) but no turn, so every post+// in a group chat shared one reaction entry: a reaction on one showed on all of them.+test('a reaction on a group post stays on that post, also after it draws again', () => {+ const ui = { visits: {}, reactions: {} }+ const actions = {+ toggleReaction: (key, index, emoji) => {+ const entry = { ...ui.reactions[key] }+ const list = entry[index] ?? []+ entry[index] = list.includes(emoji) ? list.filter(item => item !== emoji) : [...list, emoji]+ if (entry[index].length === 0) delete entry[index]+ ui.reactions = { ...ui.reactions, [key]: entry }+ },+ }+ // The trigger node the chat builds for a user/message from a Bot.+ const post = (seq, turn, from, words) => ({+ key: `turn-trigger:${seq}`, kind: 'turn-trigger', anchorSeq: seq, location: { turn: { turn } },+ data: { kind: 'context', seq, time: 1, content: text$(words), source: { kind: 'bot', role: 'post', senderSessionId: from, senderName: from }, producer: {}, form: null },+ })+ const draw = node => TriggerCell({+ node, sessionId: 'room', actions,+ useRoster: select => select(team()), useSessions: select => select({ byId: {} }),+ useTurnClock: select => select({}), useUi: select => select(ui),+ })+ // The handler a bubble's reaction menu calls, read before the menu draws.+ const reactOf = (node) => {+ if (Array.isArray(node)) return node.map(reactOf).find(Boolean)+ if (!node || typeof node !== 'object') return undefined+ if (typeof node.props?.react === 'function') return node.props.react+ if (typeof node.type === 'function') return reactOf(node.type(node.props))+ return reactOf(node.props?.children)+ }+ const chips = node => count(JSON.stringify(expand(node)), '"aria-label":"Remove reaction')+ const first = post(41, 3, 'writer', 'Draft is up')+ const sameTurn = post(44, 3, 'chief', 'Looks good')+ const later = post(57, 5, 'writer', 'Second draft')++ reactOf(draw(first))('👍')+ assert.deepEqual([chips(draw(first)), chips(draw(sameTurn)), chips(draw(later))], [1, 0, 0])+ // A fresh node for the same event, as after a reload, finds the reaction again.+ assert.equal(chips(draw(post(41, 3, 'writer', 'Draft is up'))), 1)+ reactOf(draw(later))('❤️')+ reactOf(draw(first))('👍')+ assert.deepEqual([chips(draw(first)), chips(draw(sameTurn)), chips(draw(later))], [0, 0, 1])+})