Skip to content

A team of long-lived bots for DeepSeek Harness, with main bots, bot-to-bot messages and group chats.

Keep learning proposals visible without closed turns

Fei241189e3346788d0
diff --git a/ds-bot/client.js b/ds-bot/client.js
index 157dbd40..a8414ed6 100644
--- a/ds-bot/client.js
+++ b/ds-bot/client.js
@@ -18959,8 +18959,8 @@ function serveBrowserReads({ browsers, post, clientId = globalThis.crypto.random
}
// src/client/learning-card-model.js
-function proposalTurn(proposal, turns) {
- if (!Number.isFinite(proposal?.at) || typeof turns?.values !== "function") return void 0;
+function proposalPlacement(proposal, turns) {
+ if (!Number.isFinite(proposal?.at) || typeof turns?.values !== "function") return { kind: "dock" };
let latest;
let before;
for (const location2 of turns.values()) {
@@ -18970,7 +18970,8 @@ function proposalTurn(proposal, turns) {
if (later(latest)) latest = location2;
if (end <= proposal.at && later(before)) before = location2;
}
- return (before ?? latest)?.turn;
+ const turn = (before ?? latest)?.turn;
+ return turn === void 0 ? { kind: "dock" } : { kind: "turn", turn };
}
// src/client/learning-card.js
@@ -19028,7 +19029,7 @@ function ProposalCard({ proposal, initialError = "", onFailure, onResolved, acti
)
);
}
-function LearningTurnTail({ turn, sessionId, useRoster, actions }) {
+function LearningProposals({ turn, dock, sessionId, useRoster, actions }) {
const roster = useRoster((value) => value);
const facts = useTurnFacts(sessionId, actions);
const [failed, setFailed] = (0, import_react46.useState)({});
@@ -19039,7 +19040,10 @@ function LearningTurnTail({ turn, sessionId, useRoster, actions }) {
for (const entry of Object.values(failed)) {
if (entry.proposal.botId === bot.id && !proposals.some((proposal) => proposal.id === entry.proposal.id)) visible.push(entry.proposal);
}
- const cards = visible.filter((proposal) => proposalTurn(proposal, facts?.turns) === turn?.turn);
+ const cards = visible.filter((proposal) => {
+ const placement = proposalPlacement(proposal, facts?.turns);
+ return dock ? placement.kind === "dock" : placement.kind === "turn" && placement.turn === turn?.turn;
+ });
if (cards.length === 0) return null;
const onFailure = (proposal, error) => setFailed((current) => ({ ...current, [proposal.id]: { proposal, error } }));
const onResolved = (id) => setFailed((current) => {
@@ -19060,6 +19064,12 @@ function LearningTurnTail({ turn, sessionId, useRoster, actions }) {
})
)));
}
+function LearningTurnTail(props) {
+ return (0, import_react46.createElement)(LearningProposals, { ...props, dock: false });
+}
+function LearningDock(props) {
+ return (0, import_react46.createElement)(LearningProposals, { ...props, dock: true });
+}
var LEARNING_CSS = `
.bt-learning-stack{display:flex;flex-direction:column;align-items:flex-start;gap:4px}
.bt-learning-body{display:flex;flex-direction:column;gap:8px}
@@ -20110,7 +20120,8 @@ function apply(ctx) {
() => shadow("conversation.input.dock", { id: "bot-question", order: -100, inject: face }, QuestionDock),
() => shadow("conversation.input.dock", { id: "bot-view", order: -95, inject: face }, WidgetDock),
() => shadow("conversation.input.dock", { id: "bot-secret", order: -90, inject: face }, SecretDock),
- () => shadow("conversation.input.dock", { id: "bot-handoff", order: -85, inject: face }, HandoffDock)
+ () => shadow("conversation.input.dock", { id: "bot-handoff", order: -85, inject: face }, HandoffDock),
+ () => shadow("conversation.input.dock", { id: "bot-learning", order: 850, priority: BOT_PRIORITY, inject: face }, LearningDock)
];
ctx.effect(() => installCompiledStyles(RETURN_CSS, "return"), "ds-bot: return styles");
shadow("sidebar.footer.action", { id: "bot-return", order: -300, inject: face }, BotReturn);
diff --git a/ds-bot/src/client/index.js b/ds-bot/src/client/index.js
index c05c883b..37a0be87 100644
--- a/ds-bot/src/client/index.js
+++ b/ds-bot/src/client/index.js
@@ -24,7 +24,7 @@ import { Overlays } from './overlays.js'
import { createBotBrowsers, serveBrowserReads } from './bot-browsers.js'
import { BROWSER_CSS } from './browser-pane.js'
import { SECRET_CSS, SecretDock } from './secret-card.js'
-import { LearningTurnTail, LEARNING_CSS } from './learning-card.js'
+import { LearningDock, LearningTurnTail, LEARNING_CSS } from './learning-card.js'
import { MODEL_CSS, ModelChoiceDock, DeepSeekSignIn } from './model-menu.js'
import { BOT_SETTINGS_CSS } from './bot-settings.js'
import { AVATAR_LIBRARY_CSS } from './avatar-library.js'
@@ -862,6 +862,7 @@ export function apply(ctx) {
() => shadow('conversation.input.dock', { id: 'bot-view', order: -95, inject: face }, WidgetDock),
() => shadow('conversation.input.dock', { id: 'bot-secret', order: -90, inject: face }, SecretDock),
() => shadow('conversation.input.dock', { id: 'bot-handoff', order: -85, inject: face }, HandoffDock),
+ () => shadow('conversation.input.dock', { id: 'bot-learning', order: 850, priority: BOT_PRIORITY, inject: face }, LearningDock),
]
// The return button belongs to neither group: it renders only in Agent mode.
ctx.effect(() => installCompiledStyles(RETURN_CSS, 'return'), 'ds-bot: return styles')
diff --git a/ds-bot/src/client/learning-card-model.js b/ds-bot/src/client/learning-card-model.js
index bec6f7e0..14c9fda6 100644
--- a/ds-bot/src/client/learning-card-model.js
+++ b/ds-bot/src/client/learning-card-model.js
@@ -1,5 +1,5 @@
-export function proposalTurn(proposal, turns) {
- if (!Number.isFinite(proposal?.at) || typeof turns?.values !== 'function') return undefined
+export function proposalPlacement(proposal, turns) {
+ if (!Number.isFinite(proposal?.at) || typeof turns?.values !== 'function') return { kind: 'dock' }
let latest
let before
for (const location of turns.values()) {
@@ -9,5 +9,6 @@ export function proposalTurn(proposal, turns) {
if (later(latest)) latest = location
if (end <= proposal.at && later(before)) before = location
}
- return (before ?? latest)?.turn
+ const turn = (before ?? latest)?.turn
+ return turn === undefined ? { kind: 'dock' } : { kind: 'turn', turn }
}
diff --git a/ds-bot/src/client/learning-card.js b/ds-bot/src/client/learning-card.js
index 2da27922..098001dc 100644
--- a/ds-bot/src/client/learning-card.js
+++ b/ds-bot/src/client/learning-card.js
@@ -1,6 +1,6 @@
import { createElement as h, useId, useRef, useState } from 'react'
import { useTurnFacts } from './btw.js'
-import { proposalTurn } from './learning-card-model.js'
+import { proposalPlacement } from './learning-card-model.js'
import { currentPart } from './text.js'
import { t } from './i18n.js'
@@ -42,7 +42,7 @@ function ProposalCard({ proposal, initialError = '', onFailure, onResolved, acti
h('button', { type: 'button', className: 'bt-q-submit', disabled: busy, onClick: () => answer(true) }, t('Approve'))))
}
-export function LearningTurnTail({ turn, sessionId, useRoster, actions }) {
+function LearningProposals({ turn, dock, sessionId, useRoster, actions }) {
const roster = useRoster(value => value)
const facts = useTurnFacts(sessionId, actions)
const [failed, setFailed] = useState({})
@@ -53,7 +53,10 @@ export function LearningTurnTail({ turn, sessionId, useRoster, actions }) {
for (const entry of Object.values(failed)) {
if (entry.proposal.botId === bot.id && !proposals.some(proposal => proposal.id === entry.proposal.id)) visible.push(entry.proposal)
}
- const cards = visible.filter(proposal => proposalTurn(proposal, facts?.turns) === turn?.turn)
+ const cards = visible.filter(proposal => {
+ const placement = proposalPlacement(proposal, facts?.turns)
+ return dock ? placement.kind === 'dock' : placement.kind === 'turn' && placement.turn === turn?.turn
+ })
if (cards.length === 0) return null
const onFailure = (proposal, error) => setFailed(current => ({ ...current, [proposal.id]: { proposal, error } }))
const onResolved = id => setFailed(current => {
@@ -72,6 +75,14 @@ export function LearningTurnTail({ turn, sessionId, useRoster, actions }) {
}))))
}
+export function LearningTurnTail(props) {
+ return h(LearningProposals, { ...props, dock: false })
+}
+
+export function LearningDock(props) {
+ return h(LearningProposals, { ...props, dock: true })
+}
+
export const LEARNING_CSS = `
.bt-learning-stack{display:flex;flex-direction:column;align-items:flex-start;gap:4px}
.bt-learning-body{display:flex;flex-direction:column;gap:8px}
diff --git a/ds-bot/test/learning-card.test.js b/ds-bot/test/learning-card.test.js
index b7887470..49eacd12 100644
--- a/ds-bot/test/learning-card.test.js
+++ b/ds-bot/test/learning-card.test.js
@@ -1,6 +1,6 @@
import assert from 'node:assert/strict'
import { test } from 'node:test'
-import { proposalTurn } from '../src/client/learning-card-model.js'
+import { proposalPlacement } from '../src/client/learning-card-model.js'
const turns = new Map([
[1, { turn: 1, end: { time: 100 }, status: 'closed' }],
@@ -9,10 +9,15 @@ const turns = new Map([
])
test('a proposal belongs to the latest closed turn ending before its timestamp', () => {
- assert.equal(proposalTurn({ at: 150 }, turns), 1)
- assert.equal(proposalTurn({ at: 200 }, turns), 2)
+ assert.deepEqual(proposalPlacement({ at: 150 }, turns), { kind: 'turn', turn: 1 })
+ assert.deepEqual(proposalPlacement({ at: 200 }, turns), { kind: 'turn', turn: 2 })
})
test('a proposal without an earlier closed turn falls back to the latest closed turn', () => {
- assert.equal(proposalTurn({ at: 50 }, turns), 2)
+ assert.deepEqual(proposalPlacement({ at: 50 }, turns), { kind: 'turn', turn: 2 })
+})
+
+test('a proposal uses the dock when there are no closed turns', () => {
+ assert.deepEqual(proposalPlacement({ at: 150 }, new Map()), { kind: 'dock' })
+ assert.deepEqual(proposalPlacement({ at: 150 }, new Map([[3, { turn: 3, status: 'open' }]])), { kind: 'dock' })
})