A team of long-lived bots for DeepSeek Harness, with main bots, bot-to-bot messages and group chats.
Keep every change a memory review's answer holds
Fei2411fb2014beef58
diff --git a/ds-bot/src/host/memory.js b/ds-bot/src/host/memory.jsindex 0eb00ac6..1617b4fc 100644--- a/ds-bot/src/host/memory.js+++ b/ds-bot/src/host/memory.js@@ -1691,7 +1691,9 @@ export function install(rt) {const shown = clip(JSON.stringify(change), 160)rt.warn('ds-bot: memory review of %s left out a change: %s', name, secretEntry(shown) ? 'it looks like a key, token, password, or ID number, which memory never keeps' : `it is not a well-formed change: ${shown}`)}- const { kept, changed } = await applyReview({ keeper, name, home, numbered, changes: changes.slice(0, REVIEW_CHANGES_MAX), source: batch.source(read), teamWrites })+ // The limit is what one answer may hold, not a cut of the one the model+ // gave: every change in it is kept or set aside, none is dropped.+ const { kept, changed } = await applyReview({ keeper, name, home, numbered, changes, source: batch.source(read), teamWrites })if (!alive()) return// An answer that kept all one answer may hold may have left some out, so// the same lines are read again, a few times at most, while each passdiff --git a/ds-bot/test/memory.test.js b/ds-bot/test/memory.test.jsindex 00f404e2..f0058150 100644--- a/ds-bot/test/memory.test.js+++ b/ds-bot/test/memory.test.js@@ -813,7 +813,7 @@ test('a backlog past the text limit is reviewed in passes, oldest first', asyncassert.deepEqual(JSON.parse(read('reviewed.json')), { 'chat:b2': 27 })})-test('an answer past the change limit is applied in part, and the same lines are read once more', async (t) => {+test('an answer past the change limit is kept whole, and the same lines are read once more', async (t) => {const many = Array.from({ length: 9 }, (_, at) => ({ op: 'add', text: `The user likes thing ${at + 1}` }))const replies = [JSON.stringify({ changes: many }), JSON.stringify({ changes: [many[8]] })]const { ctx, call, read, requests, stop } = start({ replies, config: { memoryReviewDelayMs: 0 } })@@ -821,6 +821,9 @@ test('an answer past the change limit is applied in part, and the same lines areawait call('state', {})ctx.emit('agent/status', { agent: { id: 'b2' }, status: 'idle' })await reviewed(call)+ // All nine changes of the first answer were kept, and a full answer still+ // re-read the same lines once: the repeat of an entry it holds changed+ // nothing, and the passes ended there.assert.equal(requests.length, 2)assert.match(requests[0].system, /At most 8 changes in one answer/)assert.match(requests[1].messages[0].content[0].text, /\[8\] \(own\) The user likes thing 8\n/)@@ -841,6 +844,34 @@ test('an answer that reaches the change limit exactly is followed by another pasassert.deepEqual(JSON.parse(read('reviewed.json')), { 'chat:b2': 11 })})+test('a change set aside inside a full answer does not take the ones after it with it', async (t) => {+ const replies = [+ JSON.stringify({ changes: [+ ...Array.from({ length: 7 }, (_, at) => ({ op: 'add', text: `The user likes thing ${at + 1}` })),+ { op: 'add', text: `The user tells ${'a long story '.repeat(30)}` },+ { op: 'add', text: 'The user likes thing 9' },+ ] }),+ JSON.stringify({ changes: [] }),+ ]+ const { ctx, call, read, requests, warnings, stop } = start({ replies, config: { memoryReviewDelayMs: 0 } })+ t.after(() => stop())+ await call('state', {})+ ctx.emit('agent/status', { agent: { id: 'b2' }, status: 'idle' })+ await reviewed(call)+ // Nine changes came in one answer: the long one was set aside and said, and+ // every other — the ninth included — was kept. A full answer was kept, so the+ // same lines were read once more.+ assert.equal(requests.length, 2)+ assert.deepEqual(parseMemory(read('bots', 'b2', 'MEMORY.md')).entries.map(entry => entry.text), [+ ...Array.from({ length: 7 }, (_, at) => `The user likes thing ${at + 1}`),+ 'The user likes thing 9',+ ])+ const dropped = warnings.filter(line => line.includes('left out a change'))+ assert.equal(dropped.length, 1, warnings.join('\n'))+ assert.ok(dropped[0].includes('a long story'), warnings.join('\n'))+ assert.deepEqual(JSON.parse(read('reviewed.json')), { 'chat:b2': 11 })+})+test('a change set aside is no part of the change limit, so the same lines are not read again for it', async (t) => {const home = mkdtempSync(join(tmpdir(), 'ds-bot-memory-'))const dir = join(home, 'memory', 'bots', 'b2')