Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

5.4 KB
Raw Blame
"""Tests for the chat-history import endpoints.

The handlers are exercised directly (no TestClient) with the per-user store
factory monkeypatched to a tmp database, so nothing touches the real chat DB.
"""

from __future__ import annotations

import asyncio
from pathlib import Path

from fastapi import HTTPException
from pydantic import ValidationError
import pytest

from deeptutor.api.routers import imports as imports_router
from deeptutor.api.routers.imports import (
    ChatHistoryImportRequest,
    import_chat_history,
    list_imported_chat_history,
)
from deeptutor.services.session.sqlite_store import SQLiteSessionStore


@pytest.fixture
def store(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> SQLiteSessionStore:
    instance = SQLiteSessionStore(db_path=tmp_path / "test.db")
    monkeypatch.setattr(imports_router, "get_sqlite_session_store", lambda: instance)
    return instance


def _payload(
    external_id: str = "s1",
    messages=None,
    agent_id: str = "",
    agent_name: str = "",
) -> ChatHistoryImportRequest:
    return ChatHistoryImportRequest(
        source="codex",
        agent_id=agent_id,
        agent_name=agent_name,
        sessions=[
            {
                "external_id": external_id,
                "title": "T",
                "source_cwd": "/p",
                "created_at": 1.0,
                "updated_at": 2.0,
                "messages": messages
                if messages is not None
                else [
                    {"role": "user", "content": "q"},
                    {"role": "assistant", "content": "a"},
                ],
            }
        ],
    )


def _imported_prefs(store: SQLiteSessionStore) -> dict:
    listed = asyncio.run(list_imported_chat_history(limit=50, offset=0))
    return listed["sessions"][0]["preferences"]["import"]


def test_source_validation_rejects_unknown() -> None:
    with pytest.raises(ValidationError):
        ChatHistoryImportRequest(source="opencode", sessions=[])


def test_source_is_normalized_lowercase() -> None:
    assert ChatHistoryImportRequest(source="Claude_Code", sessions=[]).source == ("claude_code")
    assert ChatHistoryImportRequest(source="ChatGPT", sessions=[]).source == "chatgpt"


def test_import_endpoint_persists_and_dedups(store: SQLiteSessionStore) -> None:
    res = asyncio.run(import_chat_history(_payload()))
    assert res["imported"] == 1
    assert res["skipped"] == 0

    listed = asyncio.run(list_imported_chat_history(limit=50, offset=0))
    assert len(listed["sessions"]) == 1
    assert listed["sessions"][0]["message_count"] == 2

    # Re-import the same session → deduped, not duplicated.
    again = asyncio.run(import_chat_history(_payload()))
    assert again["imported"] == 0
    assert again["skipped"] == 1
    assert len(asyncio.run(list_imported_chat_history(limit=50, offset=0))["sessions"]) == 1


def test_empty_content_messages_are_dropped(store: SQLiteSessionStore) -> None:
    res = asyncio.run(
        import_chat_history(
            _payload(
                messages=[
                    {"role": "user", "content": "q"},
                    {"role": "assistant", "content": "   "},  # whitespace only
                    {"role": "assistant", "content": "a"},
                ]
            )
        )
    )
    assert res["imported"] == 1
    listed = asyncio.run(list_imported_chat_history(limit=50, offset=0))
    assert listed["sessions"][0]["message_count"] == 2


def test_session_with_only_empty_messages_is_skipped(
    store: SQLiteSessionStore,
) -> None:
    res = asyncio.run(import_chat_history(_payload(messages=[{"role": "user", "content": "  "}])))
    assert res["imported"] == 0
    assert res["skipped"] == 1


def test_import_rejects_empty_request(store: SQLiteSessionStore) -> None:
    with pytest.raises(HTTPException) as exc:
        asyncio.run(import_chat_history(ChatHistoryImportRequest(source="codex", sessions=[])))
    assert exc.value.status_code == 400


def test_agent_attribution_persisted(store: SQLiteSessionStore) -> None:
    asyncio.run(import_chat_history(_payload(agent_id="codex-a1", agent_name="Research")))
    meta = _imported_prefs(store)
    assert meta["agent_id"] == "codex-a1"
    assert meta["agent_name"] == "Research"
    assert meta["source"] == "codex"


def test_reimport_backfills_agent_attribution(store: SQLiteSessionStore) -> None:
    # First import had no agent (legacy client) — no attribution stored.
    asyncio.run(import_chat_history(_payload()))
    assert "agent_id" not in _imported_prefs(store)

    # Re-syncing under an agent backfills attribution without duplicating the
    # session or re-adding messages.
    again = asyncio.run(import_chat_history(_payload(agent_id="codex-a1", agent_name="Research")))
    assert again["imported"] == 0
    assert again["skipped"] == 1
    listed = asyncio.run(list_imported_chat_history(limit=50, offset=0))
    assert len(listed["sessions"]) == 1
    assert listed["sessions"][0]["message_count"] == 2
    meta = listed["sessions"][0]["preferences"]["import"]
    assert meta["agent_id"] == "codex-a1"
    assert meta["agent_name"] == "Research"


def test_agent_rename_propagates_on_resync(store: SQLiteSessionStore) -> None:
    asyncio.run(import_chat_history(_payload(agent_id="codex-a1", agent_name="Old name")))
    asyncio.run(import_chat_history(_payload(agent_id="codex-a1", agent_name="New name")))
    assert _imported_prefs(store)["agent_name"] == "New name"