Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

3.2 KB
Raw Blame
"""Persistence tests for KB web source metadata."""

from __future__ import annotations

import json
from pathlib import Path

import pytest

from deeptutor.knowledge.manager import KnowledgeBaseManager


def _make_manager_with_kb(tmp_path: Path) -> tuple[KnowledgeBaseManager, Path, str]:
    manager = KnowledgeBaseManager(base_dir=str(tmp_path / "kbs"))
    kb_dir = manager.base_dir / "kb"
    kb_dir.mkdir()
    manager.register_knowledge_base("kb")
    return manager, kb_dir / "metadata.json", "kb"


def test_add_web_source_persists(tmp_path: Path) -> None:
    manager, metadata_file, kb = _make_manager_with_kb(tmp_path)
    info = manager.add_web_source(kb, "https://example.com/docs/")

    assert info["url"] == "https://example.com/docs/"
    metadata = json.loads(metadata_file.read_text(encoding="utf-8"))
    assert len(metadata["web_sources"]) == 1


def test_add_web_source_is_idempotent(tmp_path: Path) -> None:
    manager, _, kb = _make_manager_with_kb(tmp_path)
    first = manager.add_web_source(kb, "https://example.com/docs/")
    second = manager.add_web_source(kb, "https://example.com/docs/")

    assert first["id"] == second["id"]
    assert len(manager.get_web_sources(kb)) == 1


@pytest.mark.parametrize(
    ("url", "max_depth", "max_pages"),
    [
        ("file:///tmp/private", 3, 200),
        ("https://example.com/docs", 0, 200),
        ("https://example.com/docs", 6, 200),
        ("https://example.com/docs", 3, 0),
        ("https://example.com/docs", 3, 201),
    ],
)
def test_add_web_source_rejects_unbounded_or_non_http_input(
    tmp_path: Path,
    url: str,
    max_depth: int,
    max_pages: int,
) -> None:
    manager, metadata_file, kb = _make_manager_with_kb(tmp_path)

    with pytest.raises(ValueError):
        manager.add_web_source(kb, url, max_depth, max_pages)

    assert manager.get_web_sources(kb) == []
    assert not metadata_file.exists() or "web_sources" not in json.loads(
        metadata_file.read_text(encoding="utf-8")
    )


def test_remove_web_source(tmp_path: Path) -> None:
    manager, _, kb = _make_manager_with_kb(tmp_path)
    info = manager.add_web_source(kb, "https://example.com/docs/")

    assert manager.remove_web_source(kb, info["id"]) is True
    assert manager.get_web_sources(kb) == []


def test_update_web_source_state_persists(tmp_path: Path) -> None:
    manager, metadata_file, kb = _make_manager_with_kb(tmp_path)
    info = manager.add_web_source(kb, "https://example.com/docs/")

    manager.update_web_source_state(
        kb_name=kb,
        source_id=info["id"],
        page_count=5,
        last_sync_status="success",
    )

    metadata = json.loads(metadata_file.read_text(encoding="utf-8"))
    assert metadata["web_sources"][0]["page_count"] == 5


def test_get_all_web_sources_across_kbs(tmp_path: Path) -> None:
    manager = KnowledgeBaseManager(base_dir=str(tmp_path / "kbs"))
    for name in ("kb-a", "kb-b"):
        (manager.base_dir / name).mkdir()
        manager.register_knowledge_base(name)

    manager.add_web_source("kb-a", "https://a.com/docs")
    manager.add_web_source("kb-b", "https://b.com/docs")

    kb_names = {kb_name for kb_name, _source in manager.get_all_web_sources()}
    assert kb_names == {"kb-a", "kb-b"}