Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

30.4 KB
Raw Blame
"""Tests for the image/video generation service layer.

Covers the shared HTTP helpers, the OpenAI-compatible imagegen adapter (both
``b64_json`` and ``url`` response shapes), the async-task videogen adapter
(submit → poll → download, plus failure + payload shaping), catalog-driven
config resolution, and the public facades.
"""

from __future__ import annotations

import base64
from pathlib import Path
from typing import Any

import httpx
import pytest

from deeptutor.services.config.provider_runtime import (
    resolve_imagegen_runtime_config,
    resolve_videogen_runtime_config,
)
from deeptutor.services.generation_http import (
    GenerationProviderError,
    build_auth_headers,
    decode_base64_media,
    join_api_path,
)
from deeptutor.services.imagegen import generate_image
from deeptutor.services.imagegen.adapters.chat_completions import ChatCompletionsImagegenAdapter
from deeptutor.services.imagegen.adapters.dashscope import DashScopeImagegenAdapter
from deeptutor.services.imagegen.adapters.openai_compat import OpenAICompatImagegenAdapter
from deeptutor.services.imagegen.config import ImagegenConfig
from deeptutor.services.videogen import generate_video, probe_video
from deeptutor.services.videogen.adapters.async_task import AsyncTaskVideogenAdapter
from deeptutor.services.videogen.adapters.dashscope import DashScopeVideogenAdapter
from deeptutor.services.videogen.config import VideogenConfig
from deeptutor.tools.media_gen_tool import ImagegenTool, VideogenTool


def _patch_http(
    monkeypatch: pytest.MonkeyPatch,
    *,
    post: Any = None,
    get: Any = None,
) -> dict[str, Any]:
    """Patch ``httpx.AsyncClient`` post/get with url-routed fakes."""
    captured: dict[str, Any] = {"posts": [], "gets": []}

    async def fake_post(self: httpx.AsyncClient, url: str, **kwargs: Any) -> httpx.Response:
        captured["posts"].append(
            {"url": url, "json": kwargs.get("json"), "headers": kwargs.get("headers")}
        )
        resp = post(url, kwargs) if callable(post) else post
        resp.request = httpx.Request("POST", url)
        return resp

    async def fake_get(self: httpx.AsyncClient, url: str, **kwargs: Any) -> httpx.Response:
        captured["gets"].append({"url": url})
        resp = get(url, kwargs) if callable(get) else get
        resp.request = httpx.Request("GET", url)
        return resp

    if post is not None:
        monkeypatch.setattr(httpx.AsyncClient, "post", fake_post)
    if get is not None:
        monkeypatch.setattr(httpx.AsyncClient, "get", fake_get)
    return captured


# ── shared HTTP helpers ─────────────────────────────────────────────────────


def test_build_auth_headers_styles() -> None:
    assert build_auth_headers("bearer", "k") == {"Authorization": "Bearer k"}
    assert build_auth_headers("api_key_header", "k") == {"api-key": "k"}
    assert build_auth_headers("bearer", "") == {}


def test_decode_base64_media_rejects_invalid_or_empty_payloads() -> None:
    with pytest.raises(GenerationProviderError, match="invalid base64"):
        decode_base64_media("%%%not-base64%%%", "Image generation")
    with pytest.raises(GenerationProviderError, match="empty base64"):
        decode_base64_media("", "Image generation")


def test_join_api_path_appends_and_preserves_full_url() -> None:
    assert (
        join_api_path("https://api.openai.com/v1", "images/generations")
        == "https://api.openai.com/v1/images/generations"
    )
    full = "https://ark.cn-beijing.volces.com/api/v3/images/generations"
    assert join_api_path(full, "images/generations") == full


@pytest.mark.parametrize(
    ("tool", "language", "expected"),
    [
        (ImagegenTool(), "en", "generative visual requests"),
        (ImagegenTool(), "zh", "生成式视觉请求"),
        (VideogenTool(), "en", "long-running media service"),
        (VideogenTool(), "zh", "耗时较长的媒体服务"),
    ],
)
def test_media_tool_prompt_hints_distinguish_generation_from_exec(
    tool: ImagegenTool | VideogenTool, language: str, expected: str
) -> None:
    hints = tool.get_prompt_hints(language)
    rendered = " ".join(
        [hints.short_description, hints.when_to_use, hints.input_format, hints.guideline]
    )
    assert expected in rendered
    assert "outputs/" in rendered
    assert "workspace" in rendered
    for removed_name in ("code_execution", "run_code", "code_execute"):
        assert removed_name not in rendered


# ── imagegen adapter ────────────────────────────────────────────────────────


@pytest.mark.asyncio
async def test_imagegen_adapter_b64_json(monkeypatch: pytest.MonkeyPatch) -> None:
    payload = base64.b64encode(b"PNGDATA").decode("ascii")
    resp = httpx.Response(200, json={"data": [{"b64_json": payload}]})
    captured = _patch_http(monkeypatch, post=resp)
    config = ImagegenConfig(
        model="gpt-image-1",
        base_url="https://api.openai.com/v1",
        api_key="sk-test",
        size="1024x1024",
    )
    images = await OpenAICompatImagegenAdapter().generate("a cat", config, n=2)
    assert images == [(b"PNGDATA", "image/png")]
    post = captured["posts"][0]
    assert post["url"] == "https://api.openai.com/v1/images/generations"
    assert post["json"] == {"model": "gpt-image-1", "prompt": "a cat", "n": 2, "size": "1024x1024"}
    assert post["headers"]["Authorization"] == "Bearer sk-test"


@pytest.mark.asyncio
async def test_imagegen_adapter_url_is_downloaded(monkeypatch: pytest.MonkeyPatch) -> None:
    post_resp = httpx.Response(200, json={"data": [{"url": "https://cdn/x.png"}]})
    get_resp = httpx.Response(200, content=b"DOWNLOADED", headers={"content-type": "image/png"})
    captured = _patch_http(monkeypatch, post=post_resp, get=get_resp)
    config = ImagegenConfig(model="seedream", base_url="https://ark/api/v3", api_key="k")
    images = await OpenAICompatImagegenAdapter().generate("dog", config)
    assert images == [(b"DOWNLOADED", "image/png")]
    assert captured["gets"][0]["url"] == "https://cdn/x.png"


@pytest.mark.asyncio
async def test_imagegen_adapter_rejects_empty_url_download(
    monkeypatch: pytest.MonkeyPatch,
) -> None:
    post_resp = httpx.Response(200, json={"data": [{"url": "https://cdn/empty.png"}]})
    get_resp = httpx.Response(200, content=b"", headers={"content-type": "image/png"})
    _patch_http(monkeypatch, post=post_resp, get=get_resp)
    config = ImagegenConfig(model="seedream", base_url="https://ark/api/v3", api_key="k")
    with pytest.raises(GenerationProviderError, match="empty data"):
        await OpenAICompatImagegenAdapter().generate("dog", config)


@pytest.mark.asyncio
async def test_imagegen_chat_completions_adapter_data_uri(monkeypatch: pytest.MonkeyPatch) -> None:
    data_uri = "data:image/png;base64," + base64.b64encode(b"PNGBYTES").decode("ascii")
    resp = httpx.Response(
        200,
        json={
            "choices": [
                {"message": {"content": "here", "images": [{"image_url": {"url": data_uri}}]}}
            ]
        },
    )
    captured = _patch_http(monkeypatch, post=resp)
    config = ImagegenConfig(
        model="google/gemini-2.5-flash-image-preview",
        adapter="chat_completions",
        base_url="https://openrouter.ai/api/v1",
        api_key="or-key",
    )
    images = await ChatCompletionsImagegenAdapter().generate("a fox", config)
    assert images == [(b"PNGBYTES", "image/png")]
    post = captured["posts"][0]
    assert post["url"] == "https://openrouter.ai/api/v1/chat/completions"
    assert post["json"]["modalities"] == ["image", "text"]
    assert post["json"]["messages"][0]["content"] == "a fox"


@pytest.mark.asyncio
async def test_imagegen_adapter_raises_on_http_error(monkeypatch: pytest.MonkeyPatch) -> None:
    _patch_http(monkeypatch, post=httpx.Response(404, text="not activated"))
    config = ImagegenConfig(model="m", base_url="https://x/v1", api_key="k")
    with pytest.raises(GenerationProviderError, match="404"):
        await OpenAICompatImagegenAdapter().generate("x", config)


@pytest.mark.asyncio
async def test_dashscope_imagegen_task_polls_and_downloads(
    monkeypatch: pytest.MonkeyPatch,
) -> None:
    def post_router(url: str, _kwargs: Any) -> httpx.Response:
        assert (
            url == "https://dashscope.aliyuncs.com/api/v1/services/aigc/text2image/image-synthesis"
        )
        return httpx.Response(200, json={"output": {"task_id": "image-task"}})

    def get_router(url: str, _kwargs: Any) -> httpx.Response:
        if url.endswith("/tasks/image-task"):
            return httpx.Response(
                200,
                json={
                    "output": {
                        "task_status": "SUCCEEDED",
                        "results": [{"url": "https://cdn.example.com/image.png"}],
                    }
                },
            )
        return httpx.Response(200, content=b"IMAGEDATA", headers={"content-type": "image/png"})

    captured = _patch_http(monkeypatch, post=post_router, get=get_router)
    config = ImagegenConfig(
        model="wanx2.1-t2i-turbo",
        provider_name="dashscope",
        adapter="dashscope",
        base_url="https://dashscope.aliyuncs.com/api/v1",
        api_key="dash-key",
        size="1024x1024",
        poll_interval=0.0,
    )

    images = await DashScopeImagegenAdapter().generate("a cat", config, n=2)

    assert images == [(b"IMAGEDATA", "image/png")]
    post = captured["posts"][0]
    assert post["headers"]["X-DashScope-Async"] == "enable"
    assert post["headers"]["Authorization"] == "Bearer dash-key"
    assert post["json"] == {
        "model": "wanx2.1-t2i-turbo",
        "input": {"prompt": "a cat"},
        "parameters": {"n": 2, "size": "1024*1024"},
    }
    assert captured["gets"][0]["url"] == ("https://dashscope.aliyuncs.com/api/v1/tasks/image-task")
    assert captured["gets"][1]["url"] == "https://cdn.example.com/image.png"


@pytest.mark.asyncio
async def test_dashscope_imagegen_task_failure_is_actionable(
    monkeypatch: pytest.MonkeyPatch,
) -> None:
    def post_router(url: str, _kwargs: Any) -> httpx.Response:
        return httpx.Response(200, json={"output": {"task_id": "image-failed"}})

    failed = httpx.Response(
        200,
        json={"output": {"task_status": "FAILED", "message": "content policy blocked"}},
    )
    _patch_http(monkeypatch, post=post_router, get=failed)
    config = ImagegenConfig(
        model="wanx2.1-t2i-turbo",
        adapter="dashscope",
        base_url="https://dashscope.aliyuncs.com/api/v1",
        api_key="dash-key",
        poll_interval=0.0,
    )

    with pytest.raises(GenerationProviderError, match="content policy blocked"):
        await DashScopeImagegenAdapter().generate("unsafe prompt", config)


@pytest.mark.asyncio
async def test_dashscope_imagegen_http200_protocol_error_is_actionable(
    monkeypatch: pytest.MonkeyPatch,
) -> None:
    post = httpx.Response(200, json={"code": "InvalidParameter", "message": "unsupported size"})
    _patch_http(monkeypatch, post=post)
    config = ImagegenConfig(
        model="wanx2.1-t2i-turbo",
        adapter="dashscope",
        base_url="https://dashscope.aliyuncs.com/api/v1",
        api_key="dash-key",
        size="1x1",
    )

    with pytest.raises(
        GenerationProviderError,
        match=r"DashScope image task submission failed \(InvalidParameter\): unsupported size",
    ):
        await DashScopeImagegenAdapter().generate("x", config)


# ── videogen adapter ────────────────────────────────────────────────────────


def test_videogen_submit_payload_seedance_shape() -> None:
    config = VideogenConfig(
        model="seedance",
        base_url="https://ark/api/v3",
        aspect_ratio="16:9",
        resolution="720p",
        duration="5",
    )
    payload = AsyncTaskVideogenAdapter._build_submit_payload("a wave", config)
    assert payload["model"] == "seedance"
    text = payload["content"][0]["text"]
    assert text.startswith("a wave")
    assert "--ratio 16:9" in text and "--resolution 720p" in text and "--duration 5" in text


@pytest.mark.asyncio
async def test_videogen_adapter_submit_poll_download(monkeypatch: pytest.MonkeyPatch) -> None:
    submit = httpx.Response(200, json={"id": "task-1"})

    def get_router(url: str, _kwargs: Any) -> httpx.Response:
        if url.endswith("/contents/generations/tasks/task-1"):
            return httpx.Response(
                200, json={"status": "succeeded", "content": {"video_url": "https://cdn/v.mp4"}}
            )
        return httpx.Response(200, content=b"MP4DATA", headers={"content-type": "video/mp4"})

    _patch_http(monkeypatch, post=submit, get=get_router)
    config = VideogenConfig(
        model="seedance",
        base_url="https://ark/api/v3",
        api_key="k",
        poll_interval=0.0,
    )
    video, content_type = await AsyncTaskVideogenAdapter().generate("a wave", config)
    assert video == b"MP4DATA"
    assert content_type == "video/mp4"


@pytest.mark.asyncio
async def test_videogen_adapter_raises_on_failed_task(monkeypatch: pytest.MonkeyPatch) -> None:
    submit = httpx.Response(200, json={"id": "t2"})
    fail = httpx.Response(200, json={"status": "failed", "error": {"message": "content blocked"}})
    _patch_http(monkeypatch, post=submit, get=fail)
    config = VideogenConfig(model="m", base_url="https://x/v3", api_key="k", poll_interval=0.0)
    with pytest.raises(GenerationProviderError, match="content blocked"):
        await AsyncTaskVideogenAdapter().generate("x", config)


@pytest.mark.asyncio
async def test_dashscope_videogen_task_polls_and_downloads(
    monkeypatch: pytest.MonkeyPatch,
) -> None:
    progress_messages: list[str] = []

    async def progress(message: str) -> None:
        progress_messages.append(message)

    def post_router(url: str, kwargs: Any) -> httpx.Response:
        assert (
            url
            == "https://dashscope.aliyuncs.com/api/v1/services/aigc/video-generation/video-synthesis"
        )
        assert kwargs["headers"]["X-DashScope-Async"] == "enable"
        assert kwargs["json"] == {
            "model": "wanx2.1-t2v-turbo",
            "input": {"prompt": "a wave"},
            "parameters": {"size": "1280*720"},
        }
        return httpx.Response(200, json={"output": {"task_id": "video-task"}})

    def get_router(url: str, _kwargs: Any) -> httpx.Response:
        if url.endswith("/tasks/video-task"):
            return httpx.Response(
                200,
                json={"output": {"task_status": "SUCCEEDED", "video_url": "https://cdn/v.mp4"}},
            )
        return httpx.Response(200, content=b"MP4DATA", headers={"content-type": "video/mp4"})

    _patch_http(monkeypatch, post=post_router, get=get_router)
    config = VideogenConfig(
        model="wanx2.1-t2v-turbo",
        provider_name="dashscope",
        adapter="dashscope",
        base_url="https://dashscope.aliyuncs.com/api/v1",
        api_key="dash-key",
        aspect_ratio="16:9",
        duration="5",
        resolution="720p",
        poll_interval=0.0,
    )

    video, content_type = await DashScopeVideogenAdapter().generate(
        "a wave", config, progress=progress
    )

    assert video == b"MP4DATA"
    assert content_type == "video/mp4"
    assert progress_messages[0].startswith("Submitted DashScope video task")


@pytest.mark.parametrize(
    ("model", "ratio", "resolution", "expected_size"),
    [
        ("wanx2.1-t2v-turbo", "9:16", "480p", "480*832"),
        ("wanx2.1-t2v-turbo", "1:1", "", "960*960"),
        ("wan2.2-t2v-plus", "16:9", "480p", "832*480"),
        ("wan2.2-t2v-plus", "4:3", "1080p", "1632*1248"),
        ("wan2.6-t2v", "4:3", "1080p", "1632*1248"),
        ("wan2.6-t2v", "", "1280*720", "1280*720"),
    ],
)
def test_dashscope_videogen_uses_concrete_size(
    model: str, ratio: str, resolution: str, expected_size: str
) -> None:
    config = VideogenConfig(model=model, aspect_ratio=ratio, resolution=resolution)
    assert DashScopeVideogenAdapter._payload("a wave", config)["parameters"] == {
        "size": expected_size
    }


@pytest.mark.parametrize(
    ("model", "ratio", "resolution", "message"),
    [
        ("wanx2.1-t2v-plus", "16:9", "480p", "does not support 480p"),
        ("wan2.2-t2v-plus", "16:9", "720p", "does not support 720p"),
        ("wan2.2-t2v-plus", "", "1280*720", "does not support 720p"),
        ("wanx2.1-t2v-turbo", "4:3", "480p", "Unsupported DashScope"),
        ("wanx2.1-t2v-turbo", "9:16", "1280*720", "conflicts with aspect ratio"),
    ],
)
def test_dashscope_videogen_rejects_unsupported_size(
    model: str, ratio: str, resolution: str, message: str
) -> None:
    config = VideogenConfig(model=model, aspect_ratio=ratio, resolution=resolution)
    with pytest.raises(GenerationProviderError, match=message):
        DashScopeVideogenAdapter._payload("a wave", config)


def test_dashscope_videogen_rejects_non_five_second_legacy_duration() -> None:
    config = VideogenConfig(model="wanx2.1-t2v-turbo", duration="10")
    with pytest.raises(GenerationProviderError, match="only supports a 5-second video"):
        DashScopeVideogenAdapter._payload("a wave", config)


@pytest.mark.asyncio
async def test_dashscope_videogen_http200_protocol_error_is_actionable(
    monkeypatch: pytest.MonkeyPatch,
) -> None:
    post = httpx.Response(200, json={"success": False, "message": "model quota exceeded"})
    _patch_http(monkeypatch, post=post)
    config = VideogenConfig(
        model="wanx2.1-t2v-turbo",
        adapter="dashscope",
        base_url="https://dashscope.aliyuncs.com/api/v1",
        api_key="dash-key",
    )

    with pytest.raises(
        GenerationProviderError,
        match=r"DashScope video task submission failed \(unknown\): model quota exceeded",
    ):
        await DashScopeVideogenAdapter().generate("x", config)


# ── catalog resolution ──────────────────────────────────────────────────────


def _media_catalog() -> dict[str, Any]:
    return {
        "version": 1,
        "services": {
            "imagegen": {
                "active_profile_id": "p1",
                "active_model_id": "m1",
                "profiles": [
                    {
                        "id": "p1",
                        "binding": "volcengine",
                        "base_url": "",
                        "api_key": "ark-key",
                        "models": [{"id": "m1", "model": "doubao-seedream-3", "size": "1024x1024"}],
                    }
                ],
            },
            "videogen": {
                "active_profile_id": "p2",
                "active_model_id": "m2",
                "profiles": [
                    {
                        "id": "p2",
                        "binding": "volcengine",
                        "base_url": "",
                        "api_key": "ark-key",
                        "models": [
                            {"id": "m2", "model": "doubao-seedance-1", "aspect_ratio": "9:16"}
                        ],
                    }
                ],
            },
        },
    }


def test_resolve_imagegen_config_fills_provider_default_base() -> None:
    cfg = resolve_imagegen_runtime_config(catalog=_media_catalog())
    assert cfg.model == "doubao-seedream-3"
    assert cfg.provider_name == "volcengine"
    assert cfg.base_url == "https://ark.cn-beijing.volces.com/api/v3"
    assert cfg.size == "1024x1024"
    assert cfg.api_key == "ark-key"


def test_resolve_imagegen_openrouter_uses_chat_adapter() -> None:
    catalog = {
        "version": 1,
        "services": {
            "imagegen": {
                "active_profile_id": "p",
                "active_model_id": "m",
                "profiles": [
                    {
                        "id": "p",
                        "binding": "openrouter",
                        "base_url": "",
                        "api_key": "or-key",
                        "models": [{"id": "m", "model": "black-forest-labs/flux.2-pro"}],
                    }
                ],
            }
        },
    }
    cfg = resolve_imagegen_runtime_config(catalog=catalog)
    assert cfg.provider_name == "openrouter"
    assert cfg.adapter == "chat_completions"
    assert cfg.base_url == "https://openrouter.ai/api/v1"


def test_resolve_videogen_config_uses_async_task_adapter() -> None:
    cfg = resolve_videogen_runtime_config(catalog=_media_catalog())
    assert cfg.provider_name == "volcengine"
    assert cfg.adapter == "async_task"
    assert cfg.aspect_ratio == "9:16"


def test_resolve_dashscope_media_configs() -> None:
    catalog = _media_catalog()
    catalog["services"]["imagegen"]["profiles"][0]["binding"] = "aliyun"
    catalog["services"]["imagegen"]["profiles"][0]["models"][0]["model"] = "wanx2.1-t2i-turbo"
    catalog["services"]["videogen"]["profiles"][0]["binding"] = "bailian"
    catalog["services"]["videogen"]["profiles"][0]["models"][0]["model"] = "wanx2.1-t2v-turbo"

    image = resolve_imagegen_runtime_config(catalog=catalog)
    video = resolve_videogen_runtime_config(catalog=catalog)

    assert image.provider_name == "dashscope"
    assert image.adapter == "dashscope"
    assert image.model == "wanx2.1-t2i-turbo"
    assert video.provider_name == "dashscope"
    assert video.adapter == "dashscope"
    assert video.model == "wanx2.1-t2v-turbo"
    assert image.base_url == video.base_url == "https://dashscope.aliyuncs.com/api/v1"


def test_resolve_imagegen_config_raises_without_model() -> None:
    catalog = {"version": 1, "services": {"imagegen": {"profiles": []}}}
    with pytest.raises(ValueError, match="No active image-generation model"):
        resolve_imagegen_runtime_config(catalog=catalog)


# ── facades ─────────────────────────────────────────────────────────────────


@pytest.mark.asyncio
async def test_generate_image_facade(monkeypatch: pytest.MonkeyPatch) -> None:
    payload = base64.b64encode(b"IMG").decode("ascii")
    captured = _patch_http(
        monkeypatch, post=httpx.Response(200, json={"data": [{"b64_json": payload}]})
    )
    images = await generate_image("a tree", catalog=_media_catalog(), size="512x512")
    assert images == [(b"IMG", "image/png")]
    assert captured["posts"][0]["json"]["size"] == "512x512"


@pytest.mark.asyncio
async def test_imagegen_tool_saves_then_presents_selected_workspace_artifact(
    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    """Mock E2E: provider bytes -> outputs/ -> opaque openable snapshot."""
    import deeptutor.services.imagegen as imagegen_mod
    from deeptutor.services.workspace import get_content_workspace_service
    from deeptutor.tools.media_gen_tool import ImagegenTool
    from deeptutor.tools.workspace import WorkspacePresentTool

    async def fake_generate_image(prompt: str, **_kwargs: Any) -> list[tuple[bytes, str]]:
        return [(b"\x89PNG\r\n\x1a\nfake", "image/png")]

    monkeypatch.setattr(imagegen_mod, "generate_image", fake_generate_image)
    selected = tmp_path / "selected-workspace"
    selected.mkdir()
    monkeypatch.setenv("DEEPTUTOR_WORKSPACE_ROOT", str(selected))
    workspace_service = get_content_workspace_service()
    runtime = workspace_service.create_runtime_context(
        capability="chat", session_id="session-a", turn_id="turn-a"
    )

    result = await ImagegenTool().execute(
        prompt="a cat",
        _workspace_dir=str(Path(runtime.output_dir) / "media"),
        _workspace_id=runtime.workspace_id,
    )

    assert result.success, result.content
    artifacts = result.metadata.get("artifacts") or []
    assert len(artifacts) == 1
    assert artifacts[0]["relative_path"].startswith("outputs/chat/session-a/turn-a/media/imagegen_")
    assert artifacts[0]["path"] == artifacts[0]["relative_path"]
    assert artifacts[0]["url"] == ""
    assert artifacts[0]["mime_type"] == "image/png"
    assert str(selected) not in result.content

    assert result.metadata.get("workspace_items") == []
    assert result.sources == []
    assert "not yet presented" in result.content
    presentation = await WorkspacePresentTool().execute(
        items=[{"path": artifacts[0]["relative_path"]}],
        _workspace_id=runtime.workspace_id,
    )
    items = presentation.metadata.get("workspace_items") or []
    assert len(items) == 1
    assert items[0]["url"].startswith("/files/workspace-items/")
    assert items[0]["relative_path"] == artifacts[0]["relative_path"]
    assert items[0]["generated"] is True
    snapshot, published = workspace_service.resolve_published_item(
        runtime.workspace_id, items[0]["workspace_item_id"]
    )
    assert snapshot.read_bytes() == b"\x89PNG\r\n\x1a\nfake"
    assert published.mime_type == "image/png"


@pytest.mark.asyncio
async def test_imagegen_tool_without_injected_workspace_uses_public_fallback(
    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    """Direct SDK calls use the selected workspace's outputs/, never legacy data paths."""
    import deeptutor.services.imagegen as imagegen_mod
    from deeptutor.services.workspace import get_content_workspace_service
    from deeptutor.tools.media_gen_tool import ImagegenTool
    from deeptutor.tools.workspace import WorkspacePresentTool

    async def fake_generate_image(prompt: str, **_kwargs: Any) -> list[tuple[bytes, str]]:
        return [(b"\x89PNG\r\n\x1a\nfake", "image/png")]

    monkeypatch.setattr(imagegen_mod, "generate_image", fake_generate_image)
    selected = tmp_path / "sdk-workspace"
    selected.mkdir()
    monkeypatch.setenv("DEEPTUTOR_WORKSPACE_ROOT", str(selected))

    result = await ImagegenTool().execute(prompt="fallback image")

    assert result.success, result.content
    artifacts = result.metadata.get("artifacts") or []
    assert len(artifacts) == 1
    assert artifacts[0]["relative_path"].startswith("outputs/chat/direct/media_gen/media/imagegen_")
    assert (selected / artifacts[0]["relative_path"]).read_bytes().endswith(b"fake")
    assert result.metadata.get("workspace_items") == []
    assert result.sources == []
    service = get_content_workspace_service()
    binding = service.current_binding()
    presentation = await WorkspacePresentTool().execute(
        items=[{"path": artifacts[0]["relative_path"]}],
        _workspace_id=binding.workspace_id,
    )
    items = presentation.metadata.get("workspace_items") or []
    assert len(items) == 1
    assert items[0]["url"].startswith("/files/workspace-items/")


@pytest.mark.asyncio
async def test_videogen_tool_forwards_progress_then_presents(
    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    """videogen must forward progress to its event_sink (resets the chat idle
    watchdog during long renders) and save the video to a public path."""
    import deeptutor.services.videogen as videogen_mod
    from deeptutor.services.workspace import get_content_workspace_service
    from deeptutor.tools.media_gen_tool import VideogenTool
    from deeptutor.tools.workspace import WorkspacePresentTool

    async def fake_generate_video(
        prompt: str, *, progress: Any = None, **_kwargs: Any
    ) -> tuple[bytes, str]:
        if progress is not None:
            await progress("Still rendering video…")
        return (b"MP4DATA", "video/mp4")

    monkeypatch.setattr(videogen_mod, "generate_video", fake_generate_video)

    events: list[tuple[str, str]] = []

    async def event_sink(event_type: str, message: str = "", metadata: Any = None) -> None:
        events.append((event_type, message))

    selected = tmp_path / "video-workspace"
    selected.mkdir()
    monkeypatch.setenv("DEEPTUTOR_WORKSPACE_ROOT", str(selected))
    workspace_service = get_content_workspace_service()
    runtime = workspace_service.create_runtime_context(
        capability="chat", session_id="session-v", turn_id="turn-v"
    )

    result = await VideogenTool().execute(
        prompt="an ocean wave",
        _workspace_dir=str(Path(runtime.output_dir) / "media"),
        _workspace_id=runtime.workspace_id,
        event_sink=event_sink,
    )

    assert result.success, result.content
    assert any("rendering" in message for _, message in events), events
    artifacts = result.metadata.get("artifacts") or []
    assert len(artifacts) == 1
    assert artifacts[0]["relative_path"].startswith("outputs/chat/session-v/turn-v/media/videogen_")
    assert artifacts[0]["path"] == artifacts[0]["relative_path"]
    assert artifacts[0]["url"] == ""
    assert artifacts[0]["mime_type"] == "video/mp4"
    assert result.metadata.get("workspace_items") == []
    assert result.sources == []
    assert "not yet presented" in result.content
    presentation = await WorkspacePresentTool().execute(
        items=[{"path": artifacts[0]["relative_path"]}],
        _workspace_id=runtime.workspace_id,
    )
    items = presentation.metadata.get("workspace_items") or []
    assert len(items) == 1
    snapshot, published = workspace_service.resolve_published_item(
        runtime.workspace_id, items[0]["workspace_item_id"]
    )
    assert snapshot.read_bytes() == b"MP4DATA"
    assert published.mime_type == "video/mp4"


@pytest.mark.asyncio
async def test_generate_image_facade_rejects_empty_prompt() -> None:
    with pytest.raises(GenerationProviderError, match="empty prompt"):
        await generate_image("   ", catalog=_media_catalog())


@pytest.mark.asyncio
async def test_probe_video_returns_task_id(monkeypatch: pytest.MonkeyPatch) -> None:
    captured = _patch_http(monkeypatch, post=httpx.Response(200, json={"id": "probe-1"}))
    task_id = await probe_video("test clip", catalog=_media_catalog())
    assert task_id == "probe-1"
    # Probe submits only — no polling GET.
    assert captured["gets"] == []


@pytest.mark.asyncio
async def test_generate_video_facade(monkeypatch: pytest.MonkeyPatch) -> None:
    submit = httpx.Response(200, json={"id": "task-9"})

    def get_router(url: str, _kwargs: Any) -> httpx.Response:
        if "tasks/task-9" in url:
            return httpx.Response(
                200, json={"status": "succeeded", "content": {"video_url": "https://cdn/v.mp4"}}
            )
        return httpx.Response(200, content=b"VID", headers={"content-type": "video/mp4"})

    _patch_http(monkeypatch, post=submit, get=get_router)
    # Default poll_interval would sleep, but the first poll succeeds so no sleep.
    video, content_type = await generate_video("ocean", catalog=_media_catalog())
    assert video == b"VID"
    assert content_type == "video/mp4"