DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.
Python ai-agentsai-tutorclawbotcli-tooldeepresearchinteractive-learninglearningmulti-agent-systemsrag
feat(co-writer): support model selection for edits
XZH0541549ef37c
diff --git a/deeptutor/api/routers/co_writer.py b/deeptutor/api/routers/co_writer.pyindex 861cf304c..60136e5d6 100644--- a/deeptutor/api/routers/co_writer.py+++ b/deeptutor/api/routers/co_writer.py@@ -1,6 +1,7 @@from __future__ import annotationsimport asyncio+from contextlib import contextmanagerfrom datetime import datetimeimport jsonimport logging@@ -13,7 +14,7 @@ import uuidfrom fastapi import APIRouter, File, HTTPException, UploadFilefrom fastapi.responses import Response, StreamingResponse-from pydantic import BaseModel, Field+from pydantic import BaseModel, ConfigDict, Field# ``docx_converter`` imports python-docx lazily, so this stays import-cheap.from deeptutor.co_writer.docx_converter import (@@ -28,6 +29,10 @@ from deeptutor.co_writer.storage import ()from deeptutor.runtime.stream_bus import StreamBusfrom deeptutor.services.config import PROJECT_ROOT, load_config_with_main+from deeptutor.services.model_selection.runtime import (+ activate_llm_selection,+ reset_llm_selection,+)from deeptutor.services.settings.interface_settings import get_response_languageif TYPE_CHECKING:@@ -67,6 +72,86 @@ def get_edit_agent() -> EditAgent:return _edit_agent+class LLMSelectionPayload(BaseModel):+ model_config = ConfigDict(extra="forbid")++ profile_id: str+ model_id: str+ reasoning_effort: str | None = None+++def _validated_llm_selection(payload: LLMSelectionPayload | None) -> dict[str, str] | None:+ """Normalize and authorize a Co-Writer model selection.++ Ordinary users must receive a concrete granted model, mirroring Chat turn+ admission instead of silently falling back to the deployment's admin LLM.+ """+ from deeptutor.multi_user.context import get_current_user+ from deeptutor.multi_user.model_access import (+ apply_allowed_llm_selection,+ has_capability_access,+ redacted_model_access,+ )+ from deeptutor.multi_user.personal_models import merge_personal_llm_profiles+ from deeptutor.services.config import get_model_catalog_service+ from deeptutor.services.model_selection import (+ LLMSelection,+ apply_llm_selection_to_catalog,+ )++ raw = payload.model_dump(exclude_none=True) if payload is not None else None+ try:+ selection = LLMSelection.from_payload(raw)+ if selection is None and not get_current_user().is_admin:+ if not has_capability_access("llm"):+ raise PermissionError(+ "No LLM model is assigned to your account. Please contact an administrator."+ )+ assigned = next(+ (item for item in redacted_model_access().get("llm", []) if item.get("available")),+ None,+ )+ if assigned is None:+ raise PermissionError(+ "No LLM model is assigned to your account. Please contact an administrator."+ )+ selection = LLMSelection(+ profile_id=str(assigned["profile_id"]),+ model_id=str(assigned["model_id"]),+ )++ if selection is None:+ return None++ authorized = apply_allowed_llm_selection(selection.to_dict())+ catalog = merge_personal_llm_profiles(get_model_catalog_service().load())+ apply_llm_selection_to_catalog(catalog, LLMSelection.from_payload(authorized))+ return LLMSelection.from_payload(authorized).to_dict()+ except PermissionError as exc:+ raise HTTPException(status_code=403, detail=str(exc)) from None+ except ValueError as exc:+ raise HTTPException(status_code=422, detail=str(exc)) from None+++@contextmanager+def _selected_edit_agent(+ llm_selection: dict[str, str] | None,+ *,+ language: str,+):+ """Run one edit with a request-scoped LLM configuration."""+ from deeptutor.co_writer.edit_agent import EditAgent++ _, token = activate_llm_selection(llm_selection)+ try:+ # A selected model gets its own agent so concurrent edits cannot race+ # through the shared singleton's mutable api_key/model attributes.+ agent = EditAgent(language=language) if llm_selection else get_edit_agent()+ yield agent+ finally:+ reset_llm_selection(token)++# Generous ceilings — they exist to stop runaway payloads (OOM / surprise# LLM bills), not to constrain normal documents._MAX_DOC_CHARS = 600_000@@ -82,6 +167,7 @@ class EditRequest(BaseModel):action: Literal["rewrite", "shorten", "expand"] = "rewrite"source: Literal["rag", "web"] | None = Nonekb_name: str | None = None+ llm_selection: LLMSelectionPayload | None = Noneclass EditResponse(BaseModel):@@ -95,6 +181,7 @@ class ReactEditRequest(BaseModel):mode: Literal["rewrite", "shorten", "expand", "none"] = "rewrite"tools: list[Literal["rag", "web"]] = []kb_name: str | None = None+ llm_selection: LLMSelectionPayload | None = Noneclass ReactEditResponse(BaseModel):@@ -105,6 +192,7 @@ class ReactEditResponse(BaseModel):class AutoMarkRequest(BaseModel):text: str = Field(max_length=_MAX_DOC_CHARS)+ llm_selection: LLMSelectionPayload | None = Noneclass AutoMarkResponse(BaseModel):@@ -244,6 +332,7 @@ async def _run_react_edit(request: ReactEditRequest,*,language: str,+ llm_selection: dict[str, str] | None = None,stream: StreamBus | None = None,) -> dict[str, object]:from deeptutor.co_writer.edit_agent import append_history, print_stats@@ -251,145 +340,148 @@ async def _run_react_edit(selected_text, instruction, tools = _prepare_react_edit_request(request, language)operation_id = datetime.now().strftime("%Y%m%d_%H%M%S") + "_" + uuid.uuid4().hex[:6]- agent = get_edit_agent()-- # Optional reference retrieval before the edit. Each tool degrades to a- # plain edit on failure — retrieval must never block the user's edit.- query = instruction or selected_text[:400]- context_blocks: list[str] = []- tools_used: list[str] = []- from deeptutor.services.rag.pipelines.pageindex import is_pageindex_kb-- pageindex_source = "rag" in tools and is_pageindex_kb(request.kb_name)- for tool in tools:- kb_name = request.kb_name if tool == "rag" else None- if tool == "rag" and not kb_name:- continue- if tool == "rag" and pageindex_source:- # The edit loop below receives PageIndex tools directly.- continue- if stream is not None:- await stream.tool_call(- tool,- {"query": query, **({"kb_name": kb_name} if kb_name else {})},- source="co_writer_react_edit",- stage="exploring",+ with _selected_edit_agent(llm_selection, language=language) as agent:+ # Optional reference retrieval before the edit. Each tool degrades to a+ # plain edit on failure — retrieval must never block the user's edit.+ query = instruction or selected_text[:400]+ context_blocks: list[str] = []+ tools_used: list[str] = []+ from deeptutor.services.rag.pipelines.pageindex import is_pageindex_kb++ pageindex_source = "rag" in tools and is_pageindex_kb(request.kb_name)+ for tool in tools:+ kb_name = request.kb_name if tool == "rag" else None+ if tool == "rag" and not kb_name:+ continue+ if tool == "rag" and pageindex_source:+ # The edit loop below receives PageIndex tools directly.+ continue+ if stream is not None:+ await stream.tool_call(+ tool,+ {"query": query, **({"kb_name": kb_name} if kb_name else {})},+ source="co_writer_react_edit",+ stage="exploring",+ )+ context, _file = await agent.gather_context(+ source=tool,+ query=query,+ kb_name=kb_name,+ operation_id=operation_id,)- context, _file = await agent.gather_context(- source=tool,- query=query,- kb_name=kb_name,- operation_id=operation_id,+ if stream is not None:+ await stream.tool_result(+ tool,+ _trace_preview(context) if context else "(no result)",+ source="co_writer_react_edit",+ stage="exploring",+ )+ if context:+ context_blocks.append(context)+ tools_used.append(tool)++ system_prompt = (+ "You are an expert markdown editor."+ if not language.startswith("zh")+ else "你是一个严格的 Markdown 编辑助手。"+ )+ prompt = _build_react_edit_prompt(+ selected_text=selected_text,+ instruction=instruction,+ mode=request.mode,+ language=language,+ context="\n\n".join(context_blocks),)- if stream is not None:- await stream.tool_result(- tool,- _trace_preview(context) if context else "(no result)",- source="co_writer_react_edit",- stage="exploring",- )- if context:- context_blocks.append(context)- tools_used.append(tool)-- system_prompt = (- "You are an expert markdown editor."- if not language.startswith("zh")- else "你是一个严格的 Markdown 编辑助手。"- )- prompt = _build_react_edit_prompt(- selected_text=selected_text,- instruction=instruction,- mode=request.mode,- language=language,- context="\n\n".join(context_blocks),- )- response_chunks: list[str] = []- pageindex_sources: list[dict[str, object]] = []+ response_chunks: list[str] = []+ pageindex_sources: list[dict[str, object]] = []- async def _consume() -> None:- if pageindex_source and request.kb_name:- from deeptutor.services.rag.pipelines.pageindex.reasoning import (- read_pageindex_with_agent,- )+ async def _consume() -> None:+ if pageindex_source and request.kb_name:+ from deeptutor.services.rag.pipelines.pageindex.reasoning import (+ read_pageindex_with_agent,+ )- reading = await read_pageindex_with_agent(- kb_name=request.kb_name,- system_prompt=system_prompt,+ reading = await read_pageindex_with_agent(+ kb_name=request.kb_name,+ system_prompt=system_prompt,+ user_prompt=prompt,+ stream=stream,+ source="co_writer_react_edit",+ stage="responding",+ )+ if reading.text:+ response_chunks.append(reading.text)+ pageindex_sources.extend(reading.sources)+ tools_used.append("rag")+ if stream is not None:+ await stream.content(+ reading.text,+ source="co_writer_react_edit",+ stage="responding",+ )+ return+ async for chunk in agent.stream_llm(user_prompt=prompt,- stream=stream,- source="co_writer_react_edit",- stage="responding",- )- if reading.text:- response_chunks.append(reading.text)- pageindex_sources.extend(reading.sources)- tools_used.append("rag")+ system_prompt=system_prompt,+ stage=f"react_edit_{request.mode}",+ ):+ if not chunk:+ continue+ response_chunks.append(chunk)if stream is not None:await stream.content(- reading.text,+ chunk,source="co_writer_react_edit",stage="responding",)- return- async for chunk in agent.stream_llm(- user_prompt=prompt,- system_prompt=system_prompt,- stage=f"react_edit_{request.mode}",- ):- if not chunk:- continue- response_chunks.append(chunk)- if stream is not None:- await stream.content(- chunk,- source="co_writer_react_edit",- stage="responding",- )- if stream is not None:- async with stream.stage("responding", source="co_writer_react_edit"):+ if stream is not None:+ async with stream.stage("responding", source="co_writer_react_edit"):+ await _consume()+ else:await _consume()- else:- await _consume()- edited_text = _clean_react_edit_output(- "".join(response_chunks),- binding=agent.binding,- model=agent.get_model(),- )+ edited_text = _clean_react_edit_output(+ "".join(response_chunks),+ binding=agent.binding,+ model=agent.get_model(),+ )- append_history(- {- "id": operation_id,- "timestamp": datetime.now().isoformat(),- "action": "react_edit",- "mode": request.mode,- "tools": tools_used,- "kb_name": request.kb_name,- "input": {- "selected_text": request.selected_text,- "instruction": instruction,- },- "output": {"edited_text": edited_text},- "sources": pageindex_sources,- "model": agent.get_model(),- }- )- print_stats()+ append_history(+ {+ "id": operation_id,+ "timestamp": datetime.now().isoformat(),+ "action": "react_edit",+ "mode": request.mode,+ "tools": tools_used,+ "kb_name": request.kb_name,+ "input": {+ "selected_text": request.selected_text,+ "instruction": instruction,+ },+ "output": {"edited_text": edited_text},+ "sources": pageindex_sources,+ "model": agent.get_model(),+ }+ )+ print_stats()- result = {- "edited_text": edited_text,- "operation_id": operation_id,- "tools_used": tools_used,- }- if stream is not None:- await stream.result(result, source="co_writer_react_edit")- return result+ result = {+ "edited_text": edited_text,+ "operation_id": operation_id,+ "tools_used": tools_used,+ }+ if stream is not None:+ await stream.result(result, source="co_writer_react_edit")+ return result-async def _stream_react_edit(request: ReactEditRequest) -> AsyncGenerator[str, None]:+async def _stream_react_edit(+ request: ReactEditRequest,+ *,+ llm_selection: dict[str, str] | None,+) -> AsyncGenerator[str, None]:language = _current_language()bus = StreamBus()error_holder: dict[str, str] = {}@@ -398,7 +490,12 @@ async def _stream_react_edit(request: ReactEditRequest) -> AsyncGenerator[str, Nasync def _run() -> None:nonlocal result_holdertry:- result_holder = await _run_react_edit(request, language=language, stream=bus)+ result_holder = await _run_react_edit(+ request,+ language=language,+ llm_selection=llm_selection,+ stream=bus,+ )except HTTPException as exc:error_holder["detail"] = str(exc.detail)except Exception as exc:@@ -427,15 +524,17 @@ async def edit_text(request: EditRequest):try:# Get agent with refreshed LLM configuration from Settings- agent = get_edit_agent()-- result = await agent.process(- text=request.text,- instruction=request.instruction,- action=request.action,- source=request.source,- kb_name=request.kb_name,- )+ with _selected_edit_agent(+ _validated_llm_selection(request.llm_selection),+ language=_current_language(),+ ) as agent:+ result = await agent.process(+ text=request.text,+ instruction=request.instruction,+ action=request.action,+ source=request.source,+ kb_name=request.kb_name,+ )# Print token statsprint_stats()@@ -450,7 +549,11 @@ async def edit_text(request: EditRequest):@router.post("/documents/actions/edit-react", response_model=ReactEditResponse)async def edit_text_react(request: ReactEditRequest):try:- return await _run_react_edit(request, language=_current_language())+ return await _run_react_edit(+ request,+ language=_current_language(),+ llm_selection=_validated_llm_selection(request.llm_selection),+ )except HTTPException:raiseexcept Exception as e:@@ -461,11 +564,12 @@ async def edit_text_react(request: ReactEditRequest):@router.post("/documents/actions/edit-react/stream")async def edit_text_react_stream(request: ReactEditRequest):try:+ llm_selection = _validated_llm_selection(request.llm_selection)_prepare_react_edit_request(request, _current_language())except HTTPException:raisereturn StreamingResponse(- _stream_react_edit(request),+ _stream_react_edit(request, llm_selection=llm_selection),media_type="text/event-stream",headers={"Cache-Control": "no-cache", "X-Accel-Buffering": "no"},)@@ -478,9 +582,11 @@ async def auto_mark_text(request: AutoMarkRequest):try:# Get agent with refreshed LLM configuration from Settings- agent = get_edit_agent()-- result = await agent.auto_mark(text=request.text)+ with _selected_edit_agent(+ _validated_llm_selection(request.llm_selection),+ language=_current_language(),+ ) as agent:+ result = await agent.auto_mark(text=request.text)# Print token statsprint_stats()diff --git a/tests/api/test_co_writer.py b/tests/api/test_co_writer.pyindex db3d65088..b435a907b 100644--- a/tests/api/test_co_writer.py+++ b/tests/api/test_co_writer.py@@ -2,6 +2,7 @@from io import BytesIOfrom pathlib import Path+from types import SimpleNamespaceimport zipfilefrom docx import Document as DocxDocument@@ -159,6 +160,137 @@ def test_load_history_survives_corrupt_file(tmp_path, monkeypatch):assert edit_agent.load_history() == []+def test_llm_selection_defaults_to_admin_active_model(monkeypatch):+ monkeypatch.setattr(+ "deeptutor.multi_user.context.get_current_user", lambda: SimpleNamespace(is_admin=True)+ )++ assert co_writer_router._validated_llm_selection(None) is None+++def test_llm_selection_uses_first_granted_model_for_ordinary_user(monkeypatch):+ monkeypatch.setattr(+ "deeptutor.multi_user.context.get_current_user",+ lambda: SimpleNamespace(is_admin=False),+ )+ monkeypatch.setattr(+ "deeptutor.multi_user.model_access.has_capability_access", lambda _capability: True+ )+ monkeypatch.setattr(+ "deeptutor.multi_user.model_access.redacted_model_access",+ lambda: {+ "llm": [{"profile_id": "profile", "model_id": "granted-model", "available": True}]+ },+ )+ monkeypatch.setattr(+ "deeptutor.multi_user.model_access.apply_allowed_llm_selection",+ lambda selection: selection,+ )+ monkeypatch.setattr(+ "deeptutor.multi_user.personal_models.merge_personal_llm_profiles",+ lambda catalog: catalog,+ )+ monkeypatch.setattr(+ "deeptutor.services.config.get_model_catalog_service",+ lambda: SimpleNamespace(load=lambda: {}),+ )+ monkeypatch.setattr(+ "deeptutor.services.model_selection.apply_llm_selection_to_catalog",+ lambda _catalog, selection: selection,+ )++ selection = co_writer_router._validated_llm_selection(None)++ assert selection == {"profile_id": "profile", "model_id": "granted-model"}+++def _reject_model_assignment(_selection):+ raise PermissionError("not assigned")+++def test_llm_selection_rejects_unassigned_model(monkeypatch):+ monkeypatch.setattr(+ "deeptutor.multi_user.context.get_current_user",+ lambda: SimpleNamespace(is_admin=False),+ )+ monkeypatch.setattr(+ "deeptutor.multi_user.model_access.apply_allowed_llm_selection",+ _reject_model_assignment,+ )+ monkeypatch.setattr(+ "deeptutor.multi_user.personal_models.merge_personal_llm_profiles",+ lambda catalog: catalog,+ )+ monkeypatch.setattr(+ "deeptutor.services.config.get_model_catalog_service",+ lambda: SimpleNamespace(load=lambda: {}),+ )+ monkeypatch.setattr(+ "deeptutor.services.model_selection.apply_llm_selection_to_catalog",+ lambda _catalog, selection: selection,+ )++ with pytest.raises(HTTPException) as exc:+ co_writer_router._validated_llm_selection(+ co_writer_router.LLMSelectionPayload(profile_id="profile", model_id="unassigned-model")+ )++ assert exc.value.status_code == 403+++def test_selected_edit_agent_is_request_scoped(monkeypatch):+ calls = []++ class ScopedAgent:+ def __init__(self, language):+ self.language = language+ self.model = "scoped-model"++ def activate(selection):+ calls.append(("activate", selection))+ return "scoped-config", "scope-token"++ def reset(token):+ calls.append(("reset", token))++ monkeypatch.setattr(co_writer_router, "activate_llm_selection", activate)+ monkeypatch.setattr(co_writer_router, "reset_llm_selection", reset)+ monkeypatch.setattr(edit_agent, "EditAgent", ScopedAgent)++ selection = {"profile_id": "profile", "model_id": "scoped-model"}+ with co_writer_router._selected_edit_agent(selection, language="zh") as agent:+ assert agent.model == "scoped-model"++ assert calls == [+ ("activate", selection),+ ("reset", "scope-token"),+ ]+++def test_selected_edit_agent_keeps_default_singleton_and_resets(monkeypatch):+ calls = []++ class SharedAgent:+ model = "default-model"++ monkeypatch.setattr(+ co_writer_router,+ "activate_llm_selection",+ lambda selection: (selection, "default-token"),+ )+ monkeypatch.setattr(+ co_writer_router,+ "reset_llm_selection",+ lambda token: calls.append(token),+ )+ monkeypatch.setattr(co_writer_router, "get_edit_agent", lambda: SharedAgent())++ with co_writer_router._selected_edit_agent(None, language="en") as agent:+ assert agent.model == "default-model"++ assert calls == ["default-token"]++def test_automark_never_returns_unsupported_rough_notation_markup():original = "Deep learning uses neural networks."marked = '<span data-rough-notation="circle">Deep learning</span> uses neural networks.'diff --git a/web/features/co-writer/components/CoWriterWorkspace.tsx b/web/features/co-writer/components/CoWriterWorkspace.tsxindex 34a09a7c9..706c45ede 100644--- a/web/features/co-writer/components/CoWriterWorkspace.tsx+++ b/web/features/co-writer/components/CoWriterWorkspace.tsx@@ -71,11 +71,14 @@ import {saveDraft,} from "@/features/co-writer/storage/drafts";import { useSelectionEdit } from "@/features/co-writer/hooks/useSelectionEdit";+import type { LLMSelection } from "@/features/chat/model/protocol";import { useSplitPane } from "@/features/co-writer/hooks/useSplitPane";import { useSynchronizedScroll } from "@/features/co-writer/hooks/useSynchronizedScroll";import { useDocumentLifecycle } from "@/features/co-writer/hooks/useDocumentLifecycle";import type { NotebookSavePayload } from "@/components/notebook/SaveToNotebookModal";import { CO_WRITER_SAMPLE_TEMPLATE } from "@/app/(workspace)/co-writer/sampleTemplate";+import ModelSelector from "@/components/chat/home/ModelSelector";+import { useLLMOptions } from "@/hooks/useLLMOptions";import Tooltip from "@/shared/ui/Tooltip";const MarkdownRenderer = dynamic(@@ -254,6 +257,7 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {const [selectionInstruction, setSelectionInstruction] = useState("");const [selectionMode, setSelectionMode] = useState<SelectionMode>("rewrite");const [selectionTools, setSelectionTools] = useState<ToolName[]>([]);+ const [llmSelection, setLLMSelection] = useState<LLMSelection | null>(null);const [isToolMenuOpen, setIsToolMenuOpen] = useState(false);const [isModeMenuOpen, setIsModeMenuOpen] = useState(false);const [selectionTrace, setSelectionTrace] =@@ -267,6 +271,18 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {const undoTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);const pendingUndoSnapshotRef = useRef<string | null>(null);const [hasLoadedDraft, setHasLoadedDraft] = useState(false);+ const {+ options: llmOptions,+ activeDefault: activeLLMDefault,+ loading: llmOptionsLoading,+ error: llmOptionsError,+ refresh: refreshLLMOptions,+ } = useLLMOptions();++ useEffect(() => {+ if (llmSelection || !activeLLMDefault) return;+ setLLMSelection(activeLLMDefault);+ }, [activeLLMDefault, llmSelection]);useEffect(() => {markdownRef.current = markdown;@@ -987,6 +1003,7 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {mode: selectionMode,tools: selectionTools,kb_name: selectionTools.includes("rag") ? kbName || null : null,+ llm_selection: llmSelection,}),},);@@ -1082,6 +1099,7 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {selectionInstruction,selectionMode,selectionTools,+ llmSelection,startSelectionRequest,t,updateSelectionTraceFromEvent,@@ -1106,6 +1124,7 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {action,source: source === "none" ? null : source,kb_name: source === "rag" ? kbName || null : null,+ llm_selection: llmSelection,}),});const data = await response.json();@@ -1148,7 +1167,10 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {{method: "POST",headers: { "Content-Type": "application/json" },- body: JSON.stringify({ text: snapshot }),+ body: JSON.stringify({+ text: snapshot,+ llm_selection: llmSelection,+ }),},);const data = await response.json();@@ -2173,6 +2195,19 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {</div></div>+ <div className="mt-2 flex justify-end">+ <ModelSelector+ options={llmOptions}+ activeDefault={activeLLMDefault}+ value={llmSelection}+ loading={llmOptionsLoading}+ error={llmOptionsError}+ onChange={setLLMSelection}+ onRefresh={() => void refreshLLMOptions({ force: true })}+ placement="top"+ />+ </div>+{selectionTools.includes("rag") && (<selectvalue={kbName}@@ -2364,6 +2399,22 @@ export default function CoWriterWorkspace({ docId }: CoWriterWorkspaceProps) {</select></div></div>++ <div>+ <label className="mb-1 block text-[10px] font-medium uppercase tracking-wider text-[var(--muted-foreground)]">+ {t("Model")}+ </label>+ <ModelSelector+ options={llmOptions}+ activeDefault={activeLLMDefault}+ value={llmSelection}+ loading={llmOptionsLoading}+ error={llmOptionsError}+ onChange={setLLMSelection}+ onRefresh={() => void refreshLLMOptions({ force: true })}+ placement="bottom"+ />+ </div></div><div className="flex justify-end gap-2 border-t border-[var(--border)] px-4 py-3">diff --git a/web/tests/co-writer-lazy-notebook.spec.tsx b/web/tests/co-writer-lazy-notebook.spec.tsxindex d4f449bd9..25d959bdd 100644--- a/web/tests/co-writer-lazy-notebook.spec.tsx+++ b/web/tests/co-writer-lazy-notebook.spec.tsx@@ -24,6 +24,15 @@ vi.mock("@/lib/notebook-api", () => ({listNotebooks: vi.fn().mockResolvedValue([{ id: "notebook-1", name: "My notebook" }]),createNotebook: vi.fn(),}));+vi.mock("@/hooks/useLLMOptions", () => ({+ useLLMOptions: () => ({+ options: [],+ activeDefault: null,+ loading: false,+ error: false,+ refresh: vi.fn(),+ }),+}));it("opens and closes the dynamically loaded notebook picker without changing the draft", async () => {vi.stubGlobal(diff --git a/web/tests/co-writer-model-selection.spec.tsx b/web/tests/co-writer-model-selection.spec.tsxnew file mode 100644index 000000000..6ad3e00c9--- /dev/null+++ b/web/tests/co-writer-model-selection.spec.tsx@@ -0,0 +1,107 @@+import { fireEvent, render, screen, waitFor } from "@testing-library/react";+import userEvent from "@testing-library/user-event";+import { expect, it, vi } from "vitest";+import CoWriterWorkspace from "@/features/co-writer/components/CoWriterWorkspace";+import { apiFetch } from "@/lib/api";++const fetcher = vi.hoisted(() => vi.fn());++vi.mock("next/navigation", () => ({ useRouter: () => ({ push: vi.fn() }) }));+vi.mock("react-i18next", () => ({+ useTranslation: () => ({ t: (key: string) => key, i18n: { language: "en" } }),+}));+vi.mock("@/lib/api", () => ({+ apiUrl: (path: string) => path,+ apiFetch: fetcher,+}));+vi.mock("@/components/common/MarkdownRenderer", () => ({ default: () => null }));+vi.mock("@/features/knowledge/api/catalog", () => ({+ listKnowledgeBases: vi.fn().mockResolvedValue([]),+}));+vi.mock("@/lib/co-writer-api", () => ({+ getCoWriterDocument: vi.fn().mockResolvedValue({+ id: "document-1",+ title: "Existing document",+ content: "Existing draft content",+ updated_at: 1,+ }),+ updateCoWriterDocument: vi.fn().mockResolvedValue({}),+ exportCoWriterDocx: vi.fn(),+}));+vi.mock("@/lib/notebook-api", () => ({+ listNotebooks: vi.fn().mockResolvedValue([]),+ createNotebook: vi.fn(),+}));+vi.mock("@/hooks/useLLMOptions", () => ({+ useLLMOptions: () => ({+ options: [+ {+ profile_id: "profile-1",+ model_id: "default-model",+ profile_name: "Primary profile",+ model_name: "Default model",+ model: "default-model",+ provider: "openai",+ is_active_default: true,+ },+ {+ profile_id: "profile-2",+ model_id: "writing-model",+ profile_name: "Writing profile",+ model_name: "Writing model",+ model: "writing-model",+ provider: "openrouter",+ is_active_default: false,+ },+ ],+ activeDefault: { profile_id: "profile-1", model_id: "default-model" },+ loading: false,+ error: false,+ refresh: vi.fn(),+ }),+}));++it("sends the selected model with a full-draft edit", async () => {+ fetcher.mockResolvedValueOnce({+ ok: true,+ json: async () => ({ edited_text: "Edited draft", operation_id: "operation-1" }),+ });+ vi.stubGlobal(+ "ResizeObserver",+ class {+ observe() {}+ disconnect() {}+ },+ );+ const user = userEvent.setup();++ try {+ render(<CoWriterWorkspace docId="document-1" />);+ expect(await screen.findByDisplayValue("Existing draft content")).toBeInTheDocument();++ fireEvent.click(screen.getByRole("button", { name: "Full Draft" }));+ await user.click(await screen.findByRole("button", { name: "Select model" }));+ await user.click(+ screen.getByRole("button", { name: "Writing model | Writing profile" }),+ );+ await user.type(+ screen.getByPlaceholderText("Describe how you want the text edited..."),+ "Tighten this draft",+ );+ await user.click(screen.getByRole("button", { name: "Apply" }));++ await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));+ const [endpoint, init] = fetcher.mock.calls[0] as [string, RequestInit];+ expect(endpoint).toBe("/api/documents/actions/edit");+ expect(JSON.parse(String(init.body))).toEqual({+ text: "Existing draft content",+ instruction: "Tighten this draft",+ action: "rewrite",+ source: null,+ kb_name: null,+ llm_selection: { profile_id: "profile-2", model_id: "writing-model" },+ });+ } finally {+ vi.unstubAllGlobals();+ }+});