Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix: install tzdata so named timezones resolve on Windows

Mohammad Hijjawi13ac7b5df60b
diff --git a/packaging/deeptutor-cli/pyproject.toml b/packaging/deeptutor-cli/pyproject.toml
index 22d124cad..d710746a8 100644
--- a/packaging/deeptutor-cli/pyproject.toml
+++ b/packaging/deeptutor-cli/pyproject.toml
@@ -41,6 +41,8 @@ dependencies = [
"pageindex>=0.2.10,<0.3.0",
# The shared partner onboarding CLI renders QR codes on a plain CLI install.
"qrcode>=7.4.0,<9.0.0",
+ # IANA time zone data for `zoneinfo`; Windows has no system database.
+ "tzdata>=2024.1",
"anthropic>=0.30.0",
"dashscope>=1.14.0",
"perplexityai>=0.1.0",
diff --git a/pyproject.toml b/pyproject.toml
index 0f5bc7c5e..eb73c8a52 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -48,6 +48,11 @@ dependencies = [
# without it the browser renders no code at all — the operator sees a
# button that does nothing, with no error to explain why.
"qrcode>=7.4.0,<9.0.0",
+ # IANA time zone database for `zoneinfo`. Windows ships none, so without
+ # it every named zone (even "UTC") is unknown there and usage statistics,
+ # practice reviews and cron schedules reject every timezone they are given.
+ # On Linux/macOS `zoneinfo` keeps preferring the system database.
+ "tzdata>=2024.1",
# Full app dependencies included by default for `pip install deeptutor`.
"anthropic>=0.30.0",
"dashscope>=1.14.0",
diff --git a/requirements/cli.txt b/requirements/cli.txt
index 092bdaa1a..2497e667b 100644
--- a/requirements/cli.txt
+++ b/requirements/cli.txt
@@ -82,3 +82,6 @@ pageindex>=0.2.10,<0.3.0
# --- Partner channel QR onboarding (WeChat, WeCom, Feishu; core) ---
qrcode>=7.4.0,<9.0.0
+
+# --- IANA time zone data for zoneinfo (Windows has no system database) ---
+tzdata>=2024.1
diff --git a/tests/test_packaging_metadata.py b/tests/test_packaging_metadata.py
index 8b326a401..8ccb820b4 100644
--- a/tests/test_packaging_metadata.py
+++ b/tests/test_packaging_metadata.py
@@ -214,3 +214,18 @@ def test_cli_runtime_dependencies_match_every_install_surface(expected: str) ->
.splitlines()
]
assert requirement_lines.count(expected) == 1
+
+
+def test_timezone_database_is_installed_on_every_install_surface() -> None:
+ """Windows has no system zoneinfo database, so named zones need ``tzdata``.
+
+ Without it ``ZoneInfo("UTC")`` raises on Windows and the usage statistics,
+ practice review and cron features reject every timezone (issue #1907).
+ """
+ expected = "tzdata>=2024.1"
+ root = _project(REPOSITORY_ROOT / "pyproject.toml")
+ cli_package = _project(REPOSITORY_ROOT / "packaging" / "deeptutor-cli" / "pyproject.toml")
+
+ assert root["dependencies"].count(expected) == 1
+ assert cli_package["dependencies"].count(expected) == 1
+ assert _cli_requirement_lines().count(expected) == 1