Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(tooltips): cover interactive nonbutton hints

Bingxi Zhao (Frank)1c97480cb243
diff --git a/web/components/courses/CourseSyllabus.tsx b/web/components/courses/CourseSyllabus.tsx
index 3687c743c..1c305f5b7 100644
--- a/web/components/courses/CourseSyllabus.tsx
+++ b/web/components/courses/CourseSyllabus.tsx
@@ -1,5 +1,6 @@
"use client";
+import Tooltip from "@/shared/ui/Tooltip";
import { useEffect, useState } from "react";
import { Check, ListTree, Pencil } from "lucide-react";
import { useTranslation } from "react-i18next";
@@ -228,14 +229,16 @@ export default function CourseSyllabus({
) : null}
</span>
{unit.wrong_questions > 0 ? (
- <span
- title={t(
+ <Tooltip
+ label={t(
"Evidence, not a verdict — you decide whether this unit is done.",
)}
- className="mt-0.5 shrink-0 text-[10.5px] text-[var(--muted-foreground)]"
+ side="top"
>
- {t("{{count}} wrong", { count: unit.wrong_questions })}
- </span>
+ <span className="mt-0.5 shrink-0 text-[10.5px] text-[var(--muted-foreground)]">
+ {t("{{count}} wrong", { count: unit.wrong_questions })}
+ </span>
+ </Tooltip>
) : null}
</label>
</li>
diff --git a/web/components/courses/CoursesShelf.tsx b/web/components/courses/CoursesShelf.tsx
index 611ada393..9833f83c2 100644
--- a/web/components/courses/CoursesShelf.tsx
+++ b/web/components/courses/CoursesShelf.tsx
@@ -188,16 +188,16 @@ export default function CoursesShelf() {
<div className="mt-3 flex items-center gap-3 text-[10.5px] text-[var(--muted-foreground)]/75">
<span
className="inline-flex items-center gap-1"
- title={t("Materials")}
>
<Layers size={11} strokeWidth={1.8} />
+ {t("Materials")}
{course.resources.length}
</span>
<span
className="inline-flex items-center gap-1"
- title={t("Conversations")}
>
<MessagesSquare size={11} strokeWidth={1.8} />
+ {t("Conversations")}
{counts.get(course.id) ?? 0}
</span>
{lastActive.has(course.id) ? (
diff --git a/web/components/courses/OrganizedSessionList.tsx b/web/components/courses/OrganizedSessionList.tsx
index db51073b0..1c9732bca 100644
--- a/web/components/courses/OrganizedSessionList.tsx
+++ b/web/components/courses/OrganizedSessionList.tsx
@@ -1,5 +1,6 @@
"use client";
+import Tooltip from "@/shared/ui/Tooltip";
import { useEffect, useMemo, useRef, useState } from "react";
import { createPortal } from "react-dom";
import {
@@ -370,20 +371,20 @@ export default function OrganizedSessionList({
}}
className="min-w-0 flex-1 rounded border border-[var(--border)] bg-[var(--background)] px-1.5 py-0.5 text-[12px] outline-none focus:border-[var(--ring)]"
/>
- ) : isPlaceholderSessionTitle(session.title) ? (
- <span
- className="dt-breathing-text min-w-0 flex-1 truncate text-[12.5px] italic text-[var(--foreground)]"
- title={placeholderLabel}
- >
- {displaySessionTitle(session.title, placeholderLabel)}
- </span>
) : (
- <span
- className="min-w-0 flex-1 truncate text-[12.5px]"
- title={session.title}
+ <Tooltip
+ label={`${t("Conversation")}: ${isPlaceholderSessionTitle(session.title) ? placeholderLabel : session.title}`}
+ side="top"
+ className="min-w-0 flex-1"
>
- {displaySessionTitle(session.title, placeholderLabel)}
- </span>
+ <span
+ className={isPlaceholderSessionTitle(session.title)
+ ? "dt-breathing-text min-w-0 flex-1 truncate text-[12.5px] italic text-[var(--foreground)]"
+ : "min-w-0 flex-1 truncate text-[12.5px]"}
+ >
+ {displaySessionTitle(session.title, placeholderLabel)}
+ </span>
+ </Tooltip>
)}
{pinned ? <Pin size={10} className="shrink-0 opacity-55" /> : null}
{children.length > 0 && !expanded ? (
diff --git a/web/components/knowledge/KbFilePreview.tsx b/web/components/knowledge/KbFilePreview.tsx
index c553aa64e..2acca2792 100644
--- a/web/components/knowledge/KbFilePreview.tsx
+++ b/web/components/knowledge/KbFilePreview.tsx
@@ -269,15 +269,16 @@ export default function KbFilePreview({
{previewUrl && (
<>
- <a
- href={previewUrl}
- download={source.filename}
- title={t("Download")}
- aria-label={t("Download")}
- className="flex h-7 w-7 items-center justify-center rounded-md text-[var(--muted-foreground)] transition-colors hover:bg-[var(--muted)] hover:text-[var(--foreground)]"
- >
- <Download size={13} strokeWidth={1.7} />
- </a>
+ <Tooltip label={t("Download")} side="top">
+ <a
+ href={previewUrl}
+ download={source.filename}
+ aria-label={t("Download")}
+ className="flex h-7 w-7 items-center justify-center rounded-md text-[var(--muted-foreground)] transition-colors hover:bg-[var(--muted)] hover:text-[var(--foreground)]"
+ >
+ <Download size={13} strokeWidth={1.7} />
+ </a>
+ </Tooltip>
<Tooltip label={t("Copy link")} side="top">
<button
type="button"
diff --git a/web/components/mcp/McpCatalogBrowser.tsx b/web/components/mcp/McpCatalogBrowser.tsx
index 5cccdfc0e..476666d6f 100644
--- a/web/components/mcp/McpCatalogBrowser.tsx
+++ b/web/components/mcp/McpCatalogBrowser.tsx
@@ -1,5 +1,6 @@
"use client";
+import Tooltip from "@/shared/ui/Tooltip";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import {
AlertTriangle,
@@ -361,54 +362,56 @@ function EntryCard({
const { t } = useTranslation();
const description = localizedCatalogText(entry.description_i18n, lang);
return (
- <li
- role="button"
- tabIndex={0}
- onClick={onOpen}
- onKeyDown={(e) => {
- if (e.key === "Enter" || e.key === " ") {
- e.preventDefault();
- onOpen();
- }
- }}
- title={t("View details")}
- className="group flex cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
- >
- <div className="flex items-start gap-2.5">
- <BrandIcon namespace="mcp" id={entry.id} name={entry.display_name} />
- <div className="min-w-0 flex-1">
- <div className="flex flex-wrap items-center gap-1.5">
- <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
- {entry.display_name}
- </span>
- {installed && (
- <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-emerald-500/12 px-1.5 py-0.5 text-[10px] font-medium text-emerald-600 dark:text-emerald-400">
- <CheckCircle2 size={9} />
- {t("Installed")}
+ <Tooltip label={t("View details")} as="li" side="top">
+ <div
+ role="button"
+ tabIndex={0}
+ aria-label={`${t("View details")}: ${entry.display_name}`}
+ onClick={onOpen}
+ onKeyDown={(e) => {
+ if (e.key === "Enter" || e.key === " ") {
+ e.preventDefault();
+ onOpen();
+ }
+ }}
+ className="group flex h-full cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
+ >
+ <div className="flex items-start gap-2.5">
+ <BrandIcon namespace="mcp" id={entry.id} name={entry.display_name} />
+ <div className="min-w-0 flex-1">
+ <div className="flex flex-wrap items-center gap-1.5">
+ <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
+ {entry.display_name}
</span>
- )}
+ {installed && (
+ <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-emerald-500/12 px-1.5 py-0.5 text-[10px] font-medium text-emerald-600 dark:text-emerald-400">
+ <CheckCircle2 size={9} />
+ {t("Installed")}
+ </span>
+ )}
+ </div>
+ <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
+ {description}
+ </p>
</div>
- <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
- {description}
- </p>
+ </div>
+ <div className="mt-3 flex flex-wrap items-center gap-1.5 pt-1">
+ <span className={chipClass}>{t(`mcp.category.${entry.category}`)}</span>
+ {entry.tier === "registry" && (
+ <span className={chipClass}>{t("mcp.tier.registry")}</span>
+ )}
+ {entry.trust !== "verified" && (
+ <span className="inline-flex items-center gap-1 rounded-full border border-amber-500/30 bg-amber-500/10 px-2 py-0.5 text-[10.5px] font-medium text-amber-700 dark:text-amber-400">
+ <ShieldAlert size={9} />
+ {t("Unverified")}
+ </span>
+ )}
+ {entry.fields.length > 0 && (
+ <span className={chipClass}>{t("Needs a credential")}</span>
+ )}
</div>
</div>
- <div className="mt-3 flex flex-wrap items-center gap-1.5 pt-1">
- <span className={chipClass}>{t(`mcp.category.${entry.category}`)}</span>
- {entry.tier === "registry" && (
- <span className={chipClass}>{t("mcp.tier.registry")}</span>
- )}
- {entry.trust !== "verified" && (
- <span className="inline-flex items-center gap-1 rounded-full border border-amber-500/30 bg-amber-500/10 px-2 py-0.5 text-[10.5px] font-medium text-amber-700 dark:text-amber-400">
- <ShieldAlert size={9} />
- {t("Unverified")}
- </span>
- )}
- {entry.fields.length > 0 && (
- <span className={chipClass}>{t("Needs a credential")}</span>
- )}
- </div>
- </li>
+ </Tooltip>
);
}
diff --git a/web/components/memory/MemoryL1Workbench.tsx b/web/components/memory/MemoryL1Workbench.tsx
index c6f5c6ee1..cf4488f82 100644
--- a/web/components/memory/MemoryL1Workbench.tsx
+++ b/web/components/memory/MemoryL1Workbench.tsx
@@ -173,9 +173,8 @@ export default function MemoryL1Workbench({
{p > 0 ? (
<span
className="rounded-full bg-amber-500/10 px-1.5 py-0.5 text-[10px] text-amber-600 dark:text-amber-400"
- title={t("{{n}} pending", { n: p })}
>
- {p}
+ {t("{{n}} pending", { n: p })}
</span>
) : typeof c === "number" ? (
<span className="rounded-full bg-[var(--background)] px-1.5 py-0.5 text-[10px] text-[var(--muted-foreground)]">
diff --git a/web/components/memory/MemorySection.tsx b/web/components/memory/MemorySection.tsx
index 16accee4c..b02bf8314 100644
--- a/web/components/memory/MemorySection.tsx
+++ b/web/components/memory/MemorySection.tsx
@@ -1099,12 +1099,13 @@ function EntityRow({ surface, ent, focused, pendingKind, t }: EntityRowProps) {
<li
id={entityAnchorId(ref)}
data-entity-ref={ref}
- title={t("Open in {{label}}", { label: meta.label })}
>
{url ? (
- <Link href={url} className={rowClass}>
- {inner}
- </Link>
+ <Tooltip label={t("Open in {{label}}", { label: meta.label })} as="div" side="top">
+ <Link href={url} className={`${rowClass} border-b-0`}>
+ {inner}
+ </Link>
+ </Tooltip>
) : (
<div className={rowClass}>{inner}</div>
)}
diff --git a/web/components/partners/PartnerChannels.tsx b/web/components/partners/PartnerChannels.tsx
index dad0db49e..e1b474e0b 100644
--- a/web/components/partners/PartnerChannels.tsx
+++ b/web/components/partners/PartnerChannels.tsx
@@ -285,11 +285,10 @@ export default function PartnerChannels({
{entry.display_name}
</span>
{enabled && (
- <span
- aria-label={t("Enabled")}
- title={t("Enabled")}
- className="h-1.5 w-1.5 shrink-0 rounded-full bg-emerald-500"
- />
+ <span className="inline-flex shrink-0 items-center gap-1 text-[10px] text-emerald-600 dark:text-emerald-400">
+ <span aria-hidden className="h-1.5 w-1.5 rounded-full bg-emerald-500" />
+ {t("Enabled")}
+ </span>
)}
</button>
</li>
diff --git a/web/components/settings/ModelsWorkspace.tsx b/web/components/settings/ModelsWorkspace.tsx
index b04abdc4e..1b23bdb44 100644
--- a/web/components/settings/ModelsWorkspace.tsx
+++ b/web/components/settings/ModelsWorkspace.tsx
@@ -320,10 +320,10 @@ export function ModelsWorkspace({
</span>
{isDefault && (
<span
- title={t("Default model")}
- className="shrink-0 text-[var(--primary)]"
+ className="inline-flex shrink-0 items-center gap-0.5 text-[10px] text-[var(--primary)]"
>
<Check size={13} />
+ {t("Default model")}
</span>
)}
</span>
diff --git a/web/components/space/EduHubImportModal.tsx b/web/components/space/EduHubImportModal.tsx
index ef3a4358d..aa52286c5 100644
--- a/web/components/space/EduHubImportModal.tsx
+++ b/web/components/space/EduHubImportModal.tsx
@@ -1,5 +1,6 @@
"use client";
+import Tooltip from "@/shared/ui/Tooltip";
import { useCallback, useEffect, useMemo, useState } from "react";
import dynamic from "next/dynamic";
import { useTranslation } from "react-i18next";
@@ -350,75 +351,78 @@ function SkillCard({
onInstall: (slug: string, opts?: { force?: boolean }) => void;
}) {
return (
- <li
- role="button"
- tabIndex={0}
- onClick={onOpen}
- onKeyDown={(e) => {
- if (e.key === "Enter" || e.key === " ") {
- e.preventDefault();
- onOpen();
- }
- }}
- title={tr("查看详情", "View details")}
- className="group relative flex cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
- >
- <div className="flex items-start gap-2.5">
- <span className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-lg border border-[var(--border)]/60 bg-[var(--background)] text-[var(--muted-foreground)]">
- <Wand2 size={13} strokeWidth={1.6} />
- </span>
- <div className="min-w-0 flex-1">
- <div className="flex items-center gap-1.5">
- <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
- {skill.name}
- </span>
- {installed ? (
- <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-emerald-500/12 px-1.5 py-0.5 text-[10px] font-medium text-emerald-600 dark:text-emerald-400">
- <CheckCircle2 size={9} />
- {tr("已导入", "Installed")}
+ <Tooltip label={tr("查看详情", "View details")} as="li" side="top">
+ <div
+ role="button"
+ tabIndex={0}
+ aria-label={`${tr("查看详情", "View details")}: ${skill.name}`}
+ onClick={onOpen}
+ onKeyDown={(e) => {
+ if (e.target !== e.currentTarget) return;
+ if (e.key === "Enter" || e.key === " ") {
+ e.preventDefault();
+ onOpen();
+ }
+ }}
+ className="group relative flex h-full cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
+ >
+ <div className="flex items-start gap-2.5">
+ <span className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-lg border border-[var(--border)]/60 bg-[var(--background)] text-[var(--muted-foreground)]">
+ <Wand2 size={13} strokeWidth={1.6} />
+ </span>
+ <div className="min-w-0 flex-1">
+ <div className="flex items-center gap-1.5">
+ <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
+ {skill.name}
</span>
- ) : null}
+ {installed ? (
+ <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-emerald-500/12 px-1.5 py-0.5 text-[10px] font-medium text-emerald-600 dark:text-emerald-400">
+ <CheckCircle2 size={9} />
+ {tr("已导入", "Installed")}
+ </span>
+ ) : null}
+ </div>
+ {skill.summary ? (
+ <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
+ {skill.summary}
+ </p>
+ ) : (
+ <p className="mt-0.5 text-[12px] italic text-[var(--muted-foreground)]/60">
+ {tr("暂无描述。", "No description.")}
+ </p>
+ )}
</div>
- {skill.summary ? (
- <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
- {skill.summary}
- </p>
- ) : (
- <p className="mt-0.5 text-[12px] italic text-[var(--muted-foreground)]/60">
- {tr("暂无描述。", "No description.")}
- </p>
- )}
</div>
- </div>
- <div className="mt-3 flex items-center justify-between gap-2 pt-2">
- <div className="flex min-w-0 items-center gap-2.5 text-[11px] text-[var(--muted-foreground)]">
- <span className="inline-flex items-center gap-1">
- <Download size={11} />
- {skill.downloads}
- </span>
- <span className="inline-flex items-center gap-1">
- <Star size={11} />
- {skill.stars}
- </span>
- {skill.owner ? (
- <span className="truncate">· {skill.owner}</span>
- ) : null}
+ <div className="mt-3 flex items-center justify-between gap-2 pt-2">
+ <div className="flex min-w-0 items-center gap-2.5 text-[11px] text-[var(--muted-foreground)]">
+ <span className="inline-flex items-center gap-1">
+ <Download size={11} />
+ {skill.downloads}
+ </span>
+ <span className="inline-flex items-center gap-1">
+ <Star size={11} />
+ {skill.stars}
+ </span>
+ {skill.owner ? (
+ <span className="truncate">· {skill.owner}</span>
+ ) : null}
+ </div>
+ <InstallButton
+ state={state}
+ installed={installed}
+ tr={tr}
+ onClick={(force) => onInstall(skill.slug, { force })}
+ />
</div>
- <InstallButton
- state={state}
- installed={installed}
- tr={tr}
- onClick={(force) => onInstall(skill.slug, { force })}
- />
- </div>
- {state?.kind === "error" ? (
- <p className="mt-2 line-clamp-2 text-[11px] text-amber-700 dark:text-amber-400">
- {state.message}
- </p>
- ) : null}
- </li>
+ {state?.kind === "error" ? (
+ <p className="mt-2 line-clamp-2 text-[11px] text-amber-700 dark:text-amber-400">
+ {state.message}
+ </p>
+ ) : null}
+ </div>
+ </Tooltip>
);
}
diff --git a/web/components/space/PersonasSection.tsx b/web/components/space/PersonasSection.tsx
index 4543c44a1..83f402b8d 100644
--- a/web/components/space/PersonasSection.tsx
+++ b/web/components/space/PersonasSection.tsx
@@ -298,87 +298,89 @@ export default function PersonasSection() {
{personas.map((persona) => {
const readOnly = Boolean(persona.read_only);
return (
- <li
- key={persona.name}
- role="button"
- tabIndex={0}
- onClick={() => void openView(persona)}
- onKeyDown={(e) => {
- if (e.key === "Enter" || e.key === " ") {
- e.preventDefault();
- void openView(persona);
- }
- }}
- title={t("View persona")}
- className="group relative flex cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
- >
- <div className="flex items-start justify-between gap-2">
- <div className="flex items-start gap-2.5">
- <span className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-lg border border-[var(--border)]/60 bg-[var(--background)] text-[var(--muted-foreground)]">
- <UserRound size={13} strokeWidth={1.6} />
- </span>
- <div className="min-w-0">
- <div className="flex items-center gap-1.5">
- <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
- {persona.name}
- </span>
- {persona.source === "admin" ? (
- <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-[var(--muted)] px-1.5 py-0.5 text-[10px] font-medium uppercase tracking-wide text-[var(--muted-foreground)]">
- {readOnly ? <Lock size={9} /> : null}
- {t("Preset")}
+ <Tooltip key={persona.name} label={t("View persona")} as="li" side="top">
+ <div
+ role="button"
+ tabIndex={0}
+ aria-label={`${t("View persona")}: ${persona.name}`}
+ onClick={() => void openView(persona)}
+ onKeyDown={(e) => {
+ if (e.target !== e.currentTarget) return;
+ if (e.key === "Enter" || e.key === " ") {
+ e.preventDefault();
+ void openView(persona);
+ }
+ }}
+ className="group relative flex h-full cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
+ >
+ <div className="flex items-start justify-between gap-2">
+ <div className="flex items-start gap-2.5">
+ <span className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-lg border border-[var(--border)]/60 bg-[var(--background)] text-[var(--muted-foreground)]">
+ <UserRound size={13} strokeWidth={1.6} />
+ </span>
+ <div className="min-w-0">
+ <div className="flex items-center gap-1.5">
+ <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
+ {persona.name}
</span>
- ) : null}
+ {persona.source === "admin" ? (
+ <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-[var(--muted)] px-1.5 py-0.5 text-[10px] font-medium uppercase tracking-wide text-[var(--muted-foreground)]">
+ {readOnly ? <Lock size={9} /> : null}
+ {t("Preset")}
+ </span>
+ ) : null}
+ </div>
+ {persona.description ? (
+ <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
+ {persona.description}
+ </p>
+ ) : (
+ <p className="mt-0.5 text-[12px] italic text-[var(--muted-foreground)]/60">
+ {t("No description.")}
+ </p>
+ )}
</div>
- {persona.description ? (
- <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
- {persona.description}
- </p>
- ) : (
- <p className="mt-0.5 text-[12px] italic text-[var(--muted-foreground)]/60">
- {t("No description.")}
- </p>
- )}
</div>
+ {readOnly ? (
+ <span className="shrink-0 text-[var(--muted-foreground)] opacity-0 transition-opacity group-hover:opacity-100">
+ <Eye size={13} />
+ </span>
+ ) : (
+ <div className="flex shrink-0 items-center gap-0.5 opacity-0 transition-opacity group-hover:opacity-100 focus-within:opacity-100">
+ <Tooltip label={t("Edit")} side="top">
+ <button
+ onClick={(e) => {
+ e.stopPropagation();
+ void openEdit(persona.name);
+ }}
+ className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-[var(--muted)] hover:text-[var(--foreground)]"
+ aria-label={t("Edit")}
+ >
+ <Pencil size={13} />
+ </button>
+ </Tooltip>
+ <Tooltip label={t("Delete")} side="top">
+ <button
+ onClick={(e) => {
+ e.stopPropagation();
+ void handleDelete(persona.name);
+ }}
+ disabled={deleting === persona.name}
+ className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-red-50 hover:text-red-600 disabled:opacity-50 dark:hover:bg-red-950/30"
+ aria-label={t("Delete")}
+ >
+ {deleting === persona.name ? (
+ <Loader2 size={13} className="animate-spin" />
+ ) : (
+ <Trash2 size={13} />
+ )}
+ </button>
+ </Tooltip>
+ </div>
+ )}
</div>
- {readOnly ? (
- <span className="shrink-0 text-[var(--muted-foreground)] opacity-0 transition-opacity group-hover:opacity-100">
- <Eye size={13} />
- </span>
- ) : (
- <div className="flex shrink-0 items-center gap-0.5 opacity-0 transition-opacity group-hover:opacity-100 focus-within:opacity-100">
- <Tooltip label={t("Edit")} side="top">
- <button
- onClick={(e) => {
- e.stopPropagation();
- void openEdit(persona.name);
- }}
- className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-[var(--muted)] hover:text-[var(--foreground)]"
- aria-label={t("Edit")}
- >
- <Pencil size={13} />
- </button>
- </Tooltip>
- <Tooltip label={t("Delete")} side="top">
- <button
- onClick={(e) => {
- e.stopPropagation();
- void handleDelete(persona.name);
- }}
- disabled={deleting === persona.name}
- className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-red-50 hover:text-red-600 disabled:opacity-50 dark:hover:bg-red-950/30"
- aria-label={t("Delete")}
- >
- {deleting === persona.name ? (
- <Loader2 size={13} className="animate-spin" />
- ) : (
- <Trash2 size={13} />
- )}
- </button>
- </Tooltip>
- </div>
- )}
</div>
- </li>
+ </Tooltip>
);
})}
</ul>
diff --git a/web/components/space/SkillsSection.tsx b/web/components/space/SkillsSection.tsx
index 8ac8dfbfd..d5cd244c7 100644
--- a/web/components/space/SkillsSection.tsx
+++ b/web/components/space/SkillsSection.tsx
@@ -624,112 +624,114 @@ export default function SkillsSection() {
? t("Preset")
: null;
return (
- <li
- key={skill.name}
- role="button"
- tabIndex={0}
- onClick={() => void openView(skill)}
- onKeyDown={(e) => {
- if (e.key === "Enter" || e.key === " ") {
- e.preventDefault();
- void openView(skill);
- }
- }}
- title={t("View skill")}
- className="group relative flex cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
- >
- <div className="mb-2 flex items-start justify-between gap-2">
- <div className="flex items-start gap-2.5">
- <span className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-lg border border-[var(--border)]/60 bg-[var(--background)] text-[var(--muted-foreground)]">
- <Wand2 size={13} strokeWidth={1.6} />
- </span>
- <div className="min-w-0">
- <div className="flex items-center gap-1.5">
- <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
- {skill.name}
- </span>
- {sourceBadge ? (
- <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-[var(--muted)] px-1.5 py-0.5 text-[10px] font-medium uppercase tracking-wide text-[var(--muted-foreground)]">
- {readOnly ? <Lock size={9} /> : null}
- {sourceBadge}
+ <Tooltip key={skill.name} label={t("View skill")} as="li" side="top">
+ <div
+ role="button"
+ tabIndex={0}
+ aria-label={`${t("View skill")}: ${skill.name}`}
+ onClick={() => void openView(skill)}
+ onKeyDown={(e) => {
+ if (e.target !== e.currentTarget) return;
+ if (e.key === "Enter" || e.key === " ") {
+ e.preventDefault();
+ void openView(skill);
+ }
+ }}
+ className="group relative flex h-full cursor-pointer flex-col rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 shadow-sm transition-all hover:border-[var(--foreground)]/30 hover:shadow-md focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--primary)]/40"
+ >
+ <div className="mb-2 flex items-start justify-between gap-2">
+ <div className="flex items-start gap-2.5">
+ <span className="mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-lg border border-[var(--border)]/60 bg-[var(--background)] text-[var(--muted-foreground)]">
+ <Wand2 size={13} strokeWidth={1.6} />
+ </span>
+ <div className="min-w-0">
+ <div className="flex items-center gap-1.5">
+ <span className="truncate text-[14px] font-semibold tracking-tight text-[var(--foreground)]">
+ {skill.name}
</span>
- ) : null}
+ {sourceBadge ? (
+ <span className="inline-flex shrink-0 items-center gap-1 rounded-md bg-[var(--muted)] px-1.5 py-0.5 text-[10px] font-medium uppercase tracking-wide text-[var(--muted-foreground)]">
+ {readOnly ? <Lock size={9} /> : null}
+ {sourceBadge}
+ </span>
+ ) : null}
+ </div>
+ {skill.description ? (
+ <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
+ {skill.description}
+ </p>
+ ) : (
+ <p className="mt-0.5 text-[12px] italic text-[var(--muted-foreground)]/60">
+ {t("No description.")}
+ </p>
+ )}
</div>
- {skill.description ? (
- <p className="mt-0.5 line-clamp-2 text-[12px] leading-relaxed text-[var(--muted-foreground)]">
- {skill.description}
- </p>
- ) : (
- <p className="mt-0.5 text-[12px] italic text-[var(--muted-foreground)]/60">
- {t("No description.")}
- </p>
- )}
</div>
+ {readOnly ? (
+ <span className="shrink-0 text-[var(--muted-foreground)] opacity-0 transition-opacity group-hover:opacity-100">
+ <Eye size={13} />
+ </span>
+ ) : (
+ <div className="flex shrink-0 items-center gap-0.5 opacity-0 transition-opacity group-hover:opacity-100 focus-within:opacity-100">
+ <Tooltip label={t("Edit")} side="top">
+ <button
+ onClick={(e) => {
+ e.stopPropagation();
+ void openEdit(skill.name);
+ }}
+ className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-[var(--muted)] hover:text-[var(--foreground)]"
+ aria-label={t("Edit")}
+ >
+ <Pencil size={13} />
+ </button>
+ </Tooltip>
+ <Tooltip label={t("Delete")} side="top">
+ <button
+ onClick={(e) => {
+ e.stopPropagation();
+ void handleDelete(skill.name);
+ }}
+ disabled={deleting === skill.name}
+ className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-red-50 hover:text-red-600 disabled:opacity-50 dark:hover:bg-red-950/30"
+ aria-label={t("Delete")}
+ >
+ {deleting === skill.name ? (
+ <Loader2 size={13} className="animate-spin" />
+ ) : (
+ <Trash2 size={13} />
+ )}
+ </button>
+ </Tooltip>
+ </div>
+ )}
</div>
- {readOnly ? (
- <span className="shrink-0 text-[var(--muted-foreground)] opacity-0 transition-opacity group-hover:opacity-100">
- <Eye size={13} />
- </span>
- ) : (
- <div className="flex shrink-0 items-center gap-0.5 opacity-0 transition-opacity group-hover:opacity-100 focus-within:opacity-100">
- <Tooltip label={t("Edit")} side="top">
- <button
- onClick={(e) => {
- e.stopPropagation();
- void openEdit(skill.name);
- }}
- className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-[var(--muted)] hover:text-[var(--foreground)]"
- aria-label={t("Edit")}
- >
- <Pencil size={13} />
- </button>
- </Tooltip>
- <Tooltip label={t("Delete")} side="top">
+
+ {skill.tags && skill.tags.length > 0 ? (
+ <div className="mt-auto flex flex-wrap gap-1 pt-2">
+ {skill.tags.map((tag) => (
<button
+ key={tag}
onClick={(e) => {
e.stopPropagation();
- void handleDelete(skill.name);
+ setFilterTag(tag);
}}
- disabled={deleting === skill.name}
- className="rounded-md p-1.5 text-[var(--muted-foreground)] transition-colors hover:bg-red-50 hover:text-red-600 disabled:opacity-50 dark:hover:bg-red-950/30"
- aria-label={t("Delete")}
+ className="inline-flex items-center gap-1 rounded-full border border-[var(--border)]/60 bg-[var(--muted)]/40 px-2 py-0.5 text-[10.5px] font-medium text-[var(--muted-foreground)] transition-colors hover:border-[var(--foreground)]/30 hover:text-[var(--foreground)]"
>
- {deleting === skill.name ? (
- <Loader2 size={13} className="animate-spin" />
- ) : (
- <Trash2 size={13} />
- )}
+ <span className="inline-flex h-1.5 w-1.5 rounded-full bg-[var(--foreground)]/40" />
+ {tag}
</button>
- </Tooltip>
+ ))}
+ </div>
+ ) : (
+ <div className="mt-auto pt-2">
+ <span className="inline-flex items-center gap-1 rounded-full border border-dashed border-[var(--border)] px-2 py-0.5 text-[10.5px] text-[var(--muted-foreground)]/70">
+ <TagIcon size={10} />
+ {t("Untagged")}
+ </span>
</div>
)}
</div>
-
- {skill.tags && skill.tags.length > 0 ? (
- <div className="mt-auto flex flex-wrap gap-1 pt-2">
- {skill.tags.map((tag) => (
- <button
- key={tag}
- onClick={(e) => {
- e.stopPropagation();
- setFilterTag(tag);
- }}
- className="inline-flex items-center gap-1 rounded-full border border-[var(--border)]/60 bg-[var(--muted)]/40 px-2 py-0.5 text-[10.5px] font-medium text-[var(--muted-foreground)] transition-colors hover:border-[var(--foreground)]/30 hover:text-[var(--foreground)]"
- >
- <span className="inline-flex h-1.5 w-1.5 rounded-full bg-[var(--foreground)]/40" />
- {tag}
- </button>
- ))}
- </div>
- ) : (
- <div className="mt-auto pt-2">
- <span className="inline-flex items-center gap-1 rounded-full border border-dashed border-[var(--border)] px-2 py-0.5 text-[10.5px] text-[var(--muted-foreground)]/70">
- <TagIcon size={10} />
- {t("Untagged")}
- </span>
- </div>
- )}
- </li>
+ </Tooltip>
);
})}
</ul>
diff --git a/web/components/workspaces/WorkspacePill.tsx b/web/components/workspaces/WorkspacePill.tsx
index b733be441..c1acbfb1d 100644
--- a/web/components/workspaces/WorkspacePill.tsx
+++ b/web/components/workspaces/WorkspacePill.tsx
@@ -94,22 +94,27 @@ export function WorkspacePill({
if (readOnly) {
return (
- <span
- {...triggerProps}
- tabIndex={collapsible ? 0 : undefined}
- className="inline-flex h-8 min-w-0 shrink-0 items-center rounded-lg px-2 text-[13px] font-medium text-[var(--muted-foreground)]"
- title={`${t(pickerLabel)}: ${label}\n${t("Conversations with messages are moved from workspace settings")}`}
+ <Tooltip
+ label={`${t(pickerLabel)}: ${label}`}
+ description={t("Conversations with messages are moved from workspace settings")}
+ side="top"
>
- {workspaceId ? (
- <FolderOpen size={15} strokeWidth={1.7} className="shrink-0" />
- ) : (
- <Folder size={15} strokeWidth={1.7} className="shrink-0" />
- )}
- <span className="sr-only">{label}</span>
- <ToolbarLabel expanded={expanded}>
- <span className="max-w-[150px] truncate">{label}</span>
- </ToolbarLabel>
- </span>
+ <span
+ {...triggerProps}
+ tabIndex={collapsible ? 0 : undefined}
+ className="inline-flex h-8 min-w-0 shrink-0 items-center rounded-lg px-2 text-[13px] font-medium text-[var(--muted-foreground)]"
+ >
+ {workspaceId ? (
+ <FolderOpen size={15} strokeWidth={1.7} className="shrink-0" />
+ ) : (
+ <Folder size={15} strokeWidth={1.7} className="shrink-0" />
+ )}
+ <span className="sr-only">{label}</span>
+ <ToolbarLabel expanded={expanded}>
+ <span className="max-w-[150px] truncate">{label}</span>
+ </ToolbarLabel>
+ </span>
+ </Tooltip>
);
}
diff --git a/web/shared/ui/Tooltip.tsx b/web/shared/ui/Tooltip.tsx
index 4abf9e331..1a87299b9 100644
--- a/web/shared/ui/Tooltip.tsx
+++ b/web/shared/ui/Tooltip.tsx
@@ -17,10 +17,18 @@ import type { TooltipSide } from "./tooltip-position";
const loadTooltipLayer = () => import("./TooltipLayer");
const TooltipLayer = lazy(loadTooltipLayer);
+function isNestedControl(target: EventTarget): boolean {
+ return target instanceof Element &&
+ Boolean(target.closest("button, a, input, select, textarea"));
+}
+
export interface TooltipProps {
label: string;
description?: string;
children: ReactElement<{ "aria-describedby"?: string }>;
+ /** Choose a semantic wrapper when a span cannot contain the trigger. */
+ as?: "span" | "div" | "li";
+ className?: string;
side?: TooltipSide;
delay?: number;
/** Suppress a tooltip while its trigger owns an open popover or menu. */
@@ -31,12 +39,17 @@ export function Tooltip({
label,
description,
children,
+ as: Wrapper = "span",
+ className,
side = "bottom",
delay = 180,
suppressed = false,
}: TooltipProps) {
const id = useId();
- const wrapperRef = useRef<HTMLSpanElement>(null);
+ const wrapperRef = useRef<HTMLElement>(null);
+ const setWrapperRef = useCallback((node: HTMLElement | null) => {
+ wrapperRef.current = node;
+ }, []);
const timerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
const hoverRef = useRef(false);
const keyboardFocusRef = useRef(false);
@@ -96,11 +109,12 @@ export function Tooltip({
const tooltipText = description ? `${label}. ${description}` : label;
return (
- <span
- ref={wrapperRef}
- className="inline-flex"
+ <Wrapper
+ ref={setWrapperRef}
+ className={Wrapper === "span" ? `inline-flex ${className ?? ""}` : className}
onPointerEnter={(event) => {
if (event.pointerType === "touch") return;
+ if (Wrapper === "li" && isNestedControl(event.target)) return;
hoverRef.current = true;
show(false);
}}
@@ -111,6 +125,10 @@ export function Tooltip({
}}
onPointerDown={(event) => {
pointerFocusRef.current = true;
+ if (Wrapper === "li" && isNestedControl(event.target)) {
+ hide();
+ return;
+ }
if (event.pointerType !== "touch") return;
touchRef.current = true;
if (renderedVisible) hide();
@@ -124,7 +142,11 @@ export function Tooltip({
pointerFocusRef.current = false;
});
}}
- onFocusCapture={() => {
+ onFocusCapture={(event) => {
+ if (Wrapper === "li" && isNestedControl(event.target)) {
+ hide();
+ return;
+ }
if (pointerFocusRef.current) return;
keyboardFocusRef.current = true;
show(true);
@@ -158,7 +180,7 @@ export function Tooltip({
</Suspense>
)
: null}
- </span>
+ </Wrapper>
);
}
diff --git a/web/shared/ui/TooltipLayer.tsx b/web/shared/ui/TooltipLayer.tsx
index 9326bafc6..266416074 100644
--- a/web/shared/ui/TooltipLayer.tsx
+++ b/web/shared/ui/TooltipLayer.tsx
@@ -21,7 +21,7 @@ export default function TooltipLayer({
side,
onMount,
}: {
- anchorRef: RefObject<HTMLSpanElement | null>;
+ anchorRef: RefObject<HTMLElement | null>;
id: string;
label: string;
description?: string;
diff --git a/web/tests/tooltip.spec.tsx b/web/tests/tooltip.spec.tsx
index f89d1936f..348e99159 100644
--- a/web/tests/tooltip.spec.tsx
+++ b/web/tests/tooltip.spec.tsx
@@ -67,6 +67,38 @@ it("shows on touch and on hover over a disabled trigger", async () => {
expect(visualTooltip()).toHaveTextContent("Unavailable because setup is incomplete");
});
+it("keeps list cards as list items while exposing focus and touch hints", async () => {
+ render(
+ <ul>
+ <Tooltip label="View details" as="li">
+ <div role="button" tabIndex={0} aria-label="View details: Example">
+ Example
+ <button type="button">Edit</button>
+ </div>
+ </Tooltip>
+ </ul>,
+ );
+
+ const card = screen.getByRole("button", { name: "View details: Example" });
+ const list = screen.getByRole("list");
+ expect(list.children).toHaveLength(1);
+ expect(list.firstElementChild?.tagName).toBe("LI");
+ expect(card.getAttribute("aria-describedby")).toBeTruthy();
+ expect(document.getElementById(card.getAttribute("aria-describedby")!)).toHaveTextContent(
+ "View details",
+ );
+
+ fireEvent.focus(card);
+ await waitFor(() => expect(visualTooltip()).toHaveTextContent("View details"));
+ fireEvent.blur(card);
+ expect(visualTooltip()).toBeNull();
+
+ fireEvent.pointerDown(card, { pointerType: "touch" });
+ await waitFor(() => expect(visualTooltip()).toHaveTextContent("View details"));
+ fireEvent.pointerDown(screen.getByRole("button", { name: "Edit" }), { pointerType: "touch" });
+ expect(visualTooltip()).toBeNull();
+});
+
it("flips and clamps near viewport edges", () => {
const rect = (values: Partial<DOMRect>): DOMRect =>
({