Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(visualize): validate mindmap roots and complete translations

Bingxi Zhao (Frank)1e048bab7777
diff --git a/deeptutor/agents/visualize/utils.py b/deeptutor/agents/visualize/utils.py
index f1d7cbc93..2c9256660 100644
--- a/deeptutor/agents/visualize/utils.py
+++ b/deeptutor/agents/visualize/utils.py
@@ -183,9 +183,10 @@ def validate_visualization(code: str, render_type: str) -> tuple[bool, str]:
]
if not lines or lines[0][0].strip() != "mindmap":
return False, "Mermaid mindmap output must start with the `mindmap` keyword."
- root_indent = min(indent for _, indent in lines[1:])
- root_lines = [line for line, indent in lines[1:] if indent == root_indent]
- if len(root_lines) != 1 or not root_lines[0].strip():
+ if len(lines) < 2:
+ return False, "Mermaid mindmap output must contain exactly one non-empty root node."
+ root_indent = lines[1][1]
+ if any(indent <= root_indent for _, indent in lines[2:]):
return False, "Mermaid mindmap output must contain exactly one non-empty root node."
if not any(indent > root_indent for _, indent in lines[2:]):
return False, "Mermaid mindmap output needs at least one child branch."
diff --git a/tests/agents/visualize/test_validate_visualization.py b/tests/agents/visualize/test_validate_visualization.py
index b68aa368b..eaa1eceef 100644
--- a/tests/agents/visualize/test_validate_visualization.py
+++ b/tests/agents/visualize/test_validate_visualization.py
@@ -1,3 +1,5 @@
+import pytest
+
from deeptutor.agents.visualize.utils import validate_visualization
VALID_MINDMAP = """mindmap
@@ -54,3 +56,16 @@ def test_mindmap_validation_rejects_markdown_fence() -> None:
assert ok is False
assert "without a Markdown fence" in error
+
+
[email protected]("code", ["mindmap", "mindmap\n %% no nodes", "mindmap\n\n"])
+def test_mindmap_validation_rejects_missing_root(code: str) -> None:
+ ok, error = validate_visualization(code, "mindmap")
+ assert ok is False
+ assert "exactly one non-empty root" in error
+
+
+def test_mindmap_validation_rejects_child_before_root() -> None:
+ ok, error = validate_visualization("mindmap\n Early child\n Root\n Child", "mindmap")
+ assert ok is False
+ assert "exactly one non-empty root" in error
diff --git a/web/locales/de/app.json b/web/locales/de/app.json
index 2ed08f5b3..0c45dbde7 100644
--- a/web/locales/de/app.json
+++ b/web/locales/de/app.json
@@ -790,6 +790,7 @@
"Chart.js": "Chart.js",
"SVG": "SVG",
"Mermaid": "Mermaid",
+ "Mind map": "Mindmap",
"Reference": "Referenz",
"Show code": "Code anzeigen",
"Hide code": "Code ausblenden",
diff --git a/web/locales/fr/app.json b/web/locales/fr/app.json
index 59cb12394..1b43c1ee0 100644
--- a/web/locales/fr/app.json
+++ b/web/locales/fr/app.json
@@ -1151,6 +1151,7 @@
"Chart.js": "Chart.js",
"SVG": "SVG",
"Mermaid": "Mermaid",
+ "Mind map": "Carte mentale",
"Reference": "Référence",
"Describe the chart or diagram you want to visualize...": "Décrivez le graphique ou le diagramme à visualiser…",
"Show code": "Afficher le code",
diff --git a/web/locales/pl/app.json b/web/locales/pl/app.json
index c527ebf8c..179332c73 100644
--- a/web/locales/pl/app.json
+++ b/web/locales/pl/app.json
@@ -790,6 +790,7 @@
"Chart.js": "Chart.js",
"SVG": "SVG",
"Mermaid": "Mermaid",
+ "Mind map": "Mapa myśli",
"Reference": "Odnośnik",
"Show code": "Pokaż kod",
"Hide code": "Ukryj kod",
diff --git a/web/locales/uk/app.json b/web/locales/uk/app.json
index 6fe42bb82..d7d6e9ad7 100644
--- a/web/locales/uk/app.json
+++ b/web/locales/uk/app.json
@@ -772,6 +772,7 @@
"Chart.js": "Chart.js",
"SVG": "SVG",
"Mermaid": "Mermaid",
+ "Mind map": "Мапа думок",
"Reference": "Довідка",
"Show code": "Показати код",
"Hide code": "Приховати код",