Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

test(chat): align recovery integration checks with account-scoped causal retries

Bingxi Zhao (Frank)261206460f4e
diff --git a/web/tests/integration/chat-messages.spec.tsx b/web/tests/integration/chat-messages.spec.tsx
index be7ac451a..5550403af 100644
--- a/web/tests/integration/chat-messages.spec.tsx
+++ b/web/tests/integration/chat-messages.spec.tsx
@@ -259,35 +259,35 @@ describe('unsent message recovery actions', () => {
{ id: -2, role: 'user' as const, content: 'same outline request', parentMessageId: -1, failedSubmission: true },
];
- it('offers discard for each pending record and retries only the visible tail', async () => {
- const discard = vi.fn();
- const retry = vi.fn();
+ it('offers discard and causal retry for each pending record', async () => {
+ const discard = vi.fn(() => true);
+ const retry = vi.fn(async () => true);
const edit = vi.fn();
render(<ChatMessageList messages={pending} isStreaming={false}
onCopyAssistantMessage={vi.fn()} onRegenerateMessage={vi.fn()}
- canResendLastTurn onResendLastTurn={retry}
+ onRetryFailedSubmission={retry}
onDiscardFailedSubmission={discard} onEditMessage={edit} />);
expect(screen.getAllByText('Not sent')).toHaveLength(2);
expect(screen.queryByRole('button', { name: 'Edit' })).toBeNull();
const user = userEvent.setup();
- await user.click(screen.getAllByRole('button', { name: 'Discard' })[0]);
+ await user.click(screen.getAllByRole('button', { name: 'Discard unsent draft' })[0]);
expect(discard).toHaveBeenCalledWith(-1);
- await user.click(screen.getByRole('button', { name: 'Retry' }));
- expect(retry).toHaveBeenCalledOnce();
+ await user.click(screen.getAllByRole('button', { name: 'Retry' })[0]);
+ await user.click(screen.getAllByRole('button', { name: 'Retry' })[1]);
+ expect(retry.mock.calls).toEqual([[-1], [-2]]);
});
it('blocks recovery mutations while streaming and unsafe retries of incomplete snapshots', () => {
const { rerender } = render(<ChatMessageList messages={pending} isStreaming
onCopyAssistantMessage={vi.fn()} onRegenerateMessage={vi.fn()}
- canResendLastTurn onResendLastTurn={vi.fn()} onDiscardFailedSubmission={vi.fn()} />);
- expect(screen.queryByRole('button', { name: 'Retry' })).toBeNull();
- for (const button of screen.getAllByRole('button', { name: 'Discard' })) {
+ onRetryFailedSubmission={vi.fn()} onDiscardFailedSubmission={vi.fn()} />);
+ for (const button of screen.getAllByRole('button', { name: /^(Retry|Discard unsent draft)$/ })) {
expect(button).toBeDisabled();
}
rerender(<ChatMessageList messages={[{ ...pending[0], failedSubmissionNeedsReview: true }]}
isStreaming={false} onCopyAssistantMessage={vi.fn()} onRegenerateMessage={vi.fn()}
- canResendLastTurn onResendLastTurn={vi.fn()} onDiscardFailedSubmission={vi.fn()} />);
+ onRetryFailedSubmission={vi.fn()} onDiscardFailedSubmission={vi.fn()} />);
expect(screen.queryByRole('button', { name: 'Retry' })).toBeNull();
- expect(screen.getByRole('button', { name: 'Discard' })).toBeEnabled();
+ expect(screen.getByRole('button', { name: 'Discard unsent draft' })).toBeEnabled();
});
});
diff --git a/web/tests/session-failed-submission-cleanup.spec.ts b/web/tests/session-failed-submission-cleanup.spec.ts
index 5223d5305..4fb73fa97 100644
--- a/web/tests/session-failed-submission-cleanup.spec.ts
+++ b/web/tests/session-failed-submission-cleanup.spec.ts
@@ -1,5 +1,6 @@
import { beforeEach, expect, it, vi } from "vitest";
import { deleteSession } from "@/lib/session-api";
+import { updateRecoveryPrincipal } from "@/lib/recovery-principal";
import { moveFailedSubmissions, readFailedSubmissions, storeFailedSubmission } from "@/lib/failed-submissions";
const fixture = vi.hoisted(() => ({ fetch: vi.fn() }));
@@ -9,6 +10,7 @@ vi.mock("@/lib/api", () => ({
}));
beforeEach(() => {
+ updateRecoveryPrincipal({ enabled: false, authenticated: true });
localStorage.clear();
sessionStorage.clear();
fixture.fetch.mockReset();
@@ -32,15 +34,17 @@ it("preserves recovery data if the deletion request fails", async () => {
expect(readFailedSubmissions("A")).toHaveLength(1);
});
-it("does not resurrect old-format records after deletion", async () => {
- localStorage.setItem("deeptutor.failedSubmissions", JSON.stringify({
+it("keeps unowned legacy records quarantined when a current-account session is deleted", async () => {
+ const legacy = JSON.stringify({
A: { content: "legacy", capability: "chat", requestSnapshot: {}, savedAt: Date.now() },
B: { content: "other", capability: "chat", requestSnapshot: {}, savedAt: Date.now() },
- }));
+ });
+ localStorage.setItem("deeptutor.failedSubmissions", legacy);
fixture.fetch.mockResolvedValue(new Response(JSON.stringify({ deleted: true }), { status: 200 }));
await deleteSession("A");
expect(readFailedSubmissions("A")).toEqual([]);
- expect(readFailedSubmissions("B")).toHaveLength(1);
+ expect(readFailedSubmissions("B")).toEqual([]);
+ expect(localStorage.getItem("deeptutor.failedSubmissions")).toBe(legacy);
});
it("also clears the draft source of a tab-scoped session binding", async () => {