Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(sessions): group dates by local calendar days

dajiaohuang31637a659e83
diff --git a/web/lib/relative-time.ts b/web/lib/relative-time.ts
index 276086426..84026aba4 100644
--- a/web/lib/relative-time.ts
+++ b/web/lib/relative-time.ts
@@ -19,16 +19,18 @@ export type DayGroupKey = "today" | "yesterday" | "last_7_days" | "earlier";
export function getDayGroupKey(timestamp: number): DayGroupKey {
const now = new Date();
const date = new Date(timestamp * 1000);
- const startOfToday = new Date(
+ // Compare local calendar dates on a uniform UTC axis: a local day can
+ // contain 23 or 25 hours when daylight-saving time changes.
+ const startOfToday = Date.UTC(
now.getFullYear(),
now.getMonth(),
now.getDate(),
- ).getTime();
- const startOfItemDay = new Date(
+ );
+ const startOfItemDay = Date.UTC(
date.getFullYear(),
date.getMonth(),
date.getDate(),
- ).getTime();
+ );
const diffDays = Math.floor((startOfToday - startOfItemDay) / 86400000);
if (diffDays <= 0) return "today";
if (diffDays === 1) return "yesterday";
diff --git a/web/tests/session-calendar-groups.test.ts b/web/tests/session-calendar-groups.test.ts
new file mode 100644
index 000000000..e09cadff3
--- /dev/null
+++ b/web/tests/session-calendar-groups.test.ts
@@ -0,0 +1,30 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+
+import { getDayGroupKey } from "../lib/relative-time";
+
+test("session day groups count local dates across spring daylight saving", (t) => {
+ const previousTimezone = process.env.TZ;
+ process.env.TZ = "America/New_York";
+ t.after(() => {
+ if (previousTimezone === undefined) delete process.env.TZ;
+ else process.env.TZ = previousTimezone;
+ });
+ t.mock.timers.enable({ apis: ["Date"], now: new Date("2026-03-09T12:00:00-04:00") });
+
+ assert.equal(getDayGroupKey(new Date("2026-03-08T12:00:00-04:00").getTime() / 1000), "yesterday");
+});
+
+test("seven calendar days remain outside the last-seven-days group across DST", (t) => {
+ const previousTimezone = process.env.TZ;
+ process.env.TZ = "America/New_York";
+ t.after(() => {
+ if (previousTimezone === undefined) delete process.env.TZ;
+ else process.env.TZ = previousTimezone;
+ });
+ t.mock.timers.enable({ apis: ["Date"], now: new Date("2026-03-09T12:00:00-04:00") });
+
+ assert.equal(getDayGroupKey(new Date("2026-03-02T12:00:00-05:00").getTime() / 1000), "earlier");
+ assert.equal(getDayGroupKey(new Date("2026-03-03T12:00:00-05:00").getTime() / 1000), "last_7_days");
+ assert.equal(getDayGroupKey(new Date("2026-03-09T01:00:00-04:00").getTime() / 1000), "today");
+});