Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(chat): keep knowledge base resource option accessible when empty

李晨32feb12014de
diff --git a/web/components/chat/home/ChatComposer.tsx b/web/components/chat/home/ChatComposer.tsx
index 459320a92..17145b3fb 100644
--- a/web/components/chat/home/ChatComposer.tsx
+++ b/web/components/chat/home/ChatComposer.tsx
@@ -930,14 +930,18 @@ export default memo(function ChatComposer({
),
});
}
- if (knowledgeBases.length > 0) {
+ if (onToggleKB) {
resourceItems.push({
key: "knowledge",
group: "Reference materials",
summary: selectedKnowledgeBases.length
? `${selectedKnowledgeBases.length} ${t("selected")}`
- : t("Default"),
- onClear: () => [...selectedKnowledgeBases].forEach(onToggleKB),
+ : knowledgeBases.length > 0
+ ? t("Default")
+ : t("No KB"),
+ onClear: selectedKnowledgeBases.length
+ ? () => [...selectedKnowledgeBases].forEach(onToggleKB)
+ : undefined,
label: t("Knowledge"),
icon: Database,
count: selectedKnowledgeBases.length,
diff --git a/web/components/chat/home/KnowledgeSelector.tsx b/web/components/chat/home/KnowledgeSelector.tsx
index deba7b107..6efabc096 100644
--- a/web/components/chat/home/KnowledgeSelector.tsx
+++ b/web/components/chat/home/KnowledgeSelector.tsx
@@ -1,6 +1,7 @@
"use client";
import { knowledgeBaseRef } from "@/lib/knowledge-helpers";
+import Link from "next/link";
import { useEffect, useRef, useState } from "react";
import { Check, ChevronDown, Database } from "lucide-react";
import { useTranslation } from "react-i18next";
@@ -117,7 +118,7 @@ export default function KnowledgeSelector({
: `dt-popup-up absolute right-0 z-50 ${menuPlacementClass} w-[min(280px,calc(100vw-32px))] overflow-hidden rounded-xl border border-[var(--border)] bg-[var(--popover)] shadow-lg backdrop-blur-md`
}
>
- {embedded && (
+ {embedded && knowledgeBases.length > 0 && (
<div className="border-b border-[var(--border)] px-3 py-2">
<input
aria-label={t("Search")}
@@ -130,8 +131,14 @@ export default function KnowledgeSelector({
)}
{knowledgeBases.length === 0 ? (
- <div className="px-3 py-4 text-center text-[12px] text-[var(--muted-foreground)]">
- {t("No knowledge bases available")}
+ <div className="px-3 py-6 text-center text-[12px] text-[var(--muted-foreground)]">
+ <p>{t("No knowledge bases available")}</p>
+ <Link
+ href="/knowledge-bases"
+ className="mt-2 inline-flex items-center text-xs text-[var(--primary)] hover:underline"
+ >
+ {t("Create your first knowledge base")}
+ </Link>
</div>
) : (
<div className="max-h-[280px] overflow-y-auto py-1">
diff --git a/web/tests/chat-composer-empty-kb.spec.tsx b/web/tests/chat-composer-empty-kb.spec.tsx
new file mode 100644
index 000000000..0f7d7bfd9
--- /dev/null
+++ b/web/tests/chat-composer-empty-kb.spec.tsx
@@ -0,0 +1,135 @@
+import { useRef, useState } from "react";
+import { cleanup, fireEvent, render, screen } from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+import { Database, MessageSquare } from "lucide-react";
+
+import ChatComposer from "@/components/chat/home/ChatComposer";
+import type { CapabilityDef } from "@/features/capabilities/presentation";
+
+vi.mock("react-i18next", () => ({
+ useTranslation: () => ({ t: (key: string) => key }),
+}));
+
+vi.mock("@/lib/workspace-drafts", () => ({
+ readWorkspaceDraft: vi.fn().mockResolvedValue(null),
+ saveWorkspaceDraft: vi.fn().mockResolvedValue(undefined),
+}));
+
+afterEach(() => {
+ cleanup();
+ vi.restoreAllMocks();
+});
+
+const activeCap: CapabilityDef = {
+ value: "",
+ label: "Chat",
+ description: "Flexible conversation with any tool",
+ icon: MessageSquare,
+ allowedTools: [],
+};
+
+function Harness({
+ knowledgeBases = [],
+ selectedKnowledgeBases = [],
+}: {
+ knowledgeBases?: { name: string }[];
+ selectedKnowledgeBases?: string[];
+}) {
+ const [spaceOpen, setSpaceOpen] = useState(false);
+ const composerRef = useRef<HTMLDivElement>(null);
+ const capMenuRef = useRef<HTMLDivElement>(null);
+ const capBtnRef = useRef<HTMLButtonElement>(null);
+ const spaceMenuRef = useRef<HTMLDivElement>(null);
+ const spaceBtnRef = useRef<HTMLButtonElement>(null);
+ const dragCounter = useRef(0);
+
+ return (
+ <ChatComposer
+ composerRef={composerRef}
+ capMenuRef={capMenuRef}
+ capBtnRef={capBtnRef}
+ spaceMenuRef={spaceMenuRef}
+ spaceBtnRef={spaceBtnRef}
+ dragCounter={dragCounter}
+ dragging={false}
+ capMenuOpen={false}
+ spaceMenuOpen={spaceOpen}
+ hasMessages={false}
+ attachments={[]}
+ attachmentError={null}
+ activeCap={activeCap}
+ knowledgeBases={knowledgeBases}
+ llmOptions={[]}
+ activeLLMDefault={null}
+ llmSelection={null}
+ llmOptionsLoading={false}
+ llmOptionsError={false}
+ selectedNotebookRecords={[]}
+ selectedBookReferences={[]}
+ selectedHistorySessions={[]}
+ selectedAgentSessions={[]}
+ selectedQuestionEntries={[]}
+ notebookReferenceGroups={[]}
+ selectedPersona={null}
+ selectedMemoryFiles={[]}
+ selectedKnowledgeBases={selectedKnowledgeBases}
+ isStreaming={false}
+ isVisualizeMode={false}
+ capabilityNeedsConfig={false}
+ capabilityConfigConfirmed={false}
+ onRequestConfigConfirm={() => {}}
+ capabilities={[activeCap]}
+ onSetCapMenuOpen={() => {}}
+ onSetSpaceMenuOpen={setSpaceOpen}
+ onToggleKB={() => {}}
+ onSelectLLM={() => {}}
+ onSelectNotebookPicker={() => {}}
+ onSelectBookPicker={() => {}}
+ onSelectHistoryPicker={() => {}}
+ onSelectAgentsPicker={() => {}}
+ onSelectQuestionBankPicker={() => {}}
+ onSelectPersonaPicker={() => {}}
+ onSelectMemoryPicker={() => {}}
+ onClearPersona={() => {}}
+ onToggleMemoryFile={() => {}}
+ onSend={() => {}}
+ onRemoveAttachment={() => {}}
+ onRemoveHistory={() => {}}
+ onRemoveAgent={() => {}}
+ onRemoveBookReference={() => {}}
+ onRemoveNotebook={() => {}}
+ onRemoveQuestion={() => {}}
+ onDragEnter={() => {}}
+ onDragLeave={() => {}}
+ onDragOver={() => {}}
+ onDrop={() => {}}
+ onPaste={() => {}}
+ onAddFiles={() => {}}
+ onSelectCapability={() => {}}
+ onCancelStreaming={() => {}}
+ />
+ );
+}
+
+it("keeps knowledge base entry available with 'No KB' summary when knowledge bases are empty", () => {
+ render(<Harness knowledgeBases={[]} />);
+ fireEvent.click(screen.getByRole("button", { name: "Resources" }));
+
+ const kbButton = screen.getByRole("button", { name: /Knowledge.*No KB/ });
+ expect(kbButton).toBeInTheDocument();
+
+ fireEvent.click(kbButton);
+ expect(screen.getByText("No knowledge bases available")).toBeInTheDocument();
+ expect(screen.getByText("Create your first knowledge base")).toBeInTheDocument();
+});
+
+it("displays 'Default' summary and lists knowledge bases when configured", () => {
+ render(<Harness knowledgeBases={[{ name: "Chemistry" }]} />);
+ fireEvent.click(screen.getByRole("button", { name: "Resources" }));
+
+ const kbButton = screen.getByRole("button", { name: /Knowledge.*Default/ });
+ expect(kbButton).toBeInTheDocument();
+
+ fireEvent.click(kbButton);
+ expect(screen.getByText("Chemistry")).toBeInTheDocument();
+});