Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix: keep mastery review within the gate

dajiaohuang3ce2937c828d
diff --git a/deeptutor/api/routers/mastery_path.py b/deeptutor/api/routers/mastery_path.py
index d583efdfa..2d1e27750 100644
--- a/deeptutor/api/routers/mastery_path.py
+++ b/deeptutor/api/routers/mastery_path.py
@@ -362,7 +362,8 @@ def _review_queue(progress, *, now: float | None = None) -> list[dict]:
),
}
for task in sorted(
- progress.review_queue, key=lambda item: review_sort_key(item, now=moment)
+ learning_policy.reviewable_tasks(progress),
+ key=lambda item: review_sort_key(item, now=moment),
)
]
diff --git a/deeptutor/learning/policy.py b/deeptutor/learning/policy.py
index 1980fd2b8..4cc99e52b 100644
--- a/deeptutor/learning/policy.py
+++ b/deeptutor/learning/policy.py
@@ -176,13 +176,28 @@ def objective_status(progress: LearningProgress, kp: KnowledgePoint) -> str:
return "learning" if seen else "new"
+def reviewable_tasks(progress: LearningProgress) -> list[ReviewTask]:
+ """Scheduled items for objectives that have cleared the mastery gate.
+
+ Failed attempts can also carry retry schedules, but review mode is limited
+ to work the learner has already mastered.
+ """
+ mastered_ids = {
+ kp.id
+ for module in progress.modules
+ for kp in module.knowledge_points
+ if is_mastered(progress, kp)
+ }
+ return [task for task in progress.review_queue if task.knowledge_point_id in mastered_ids]
+
+
def due_reviews(progress: LearningProgress, *, now: float | None = None) -> list[ReviewTask]:
- """Spaced-repetition tasks whose ``due_at`` has passed, highest forgetting
+ """Mastered spaced-repetition tasks whose ``due_at`` has passed, highest forgetting
risk first. Pure read over ``progress.review_queue`` (built by the scheduler)."""
from deeptutor.learning.scheduler import review_sort_key
moment = time.time() if now is None else now
- due = [task for task in progress.review_queue if task.due_at <= moment]
+ due = [task for task in reviewable_tasks(progress) if task.due_at <= moment]
due.sort(key=lambda task: review_sort_key(task, now=moment))
return due
diff --git a/deeptutor/learning/tests/test_policy.py b/deeptutor/learning/tests/test_policy.py
index b258548e8..3ef90af5e 100644
--- a/deeptutor/learning/tests/test_policy.py
+++ b/deeptutor/learning/tests/test_policy.py
@@ -233,6 +233,7 @@ def test_next_objective_due_review_beats_new_ground():
def test_due_reviews_order_by_forgetting_risk_before_priority():
kp1, kp2 = _kp("kp_high", KnowledgeType.MEMORY), _kp("kp_low", KnowledgeType.MEMORY)
progress = _progress(kp1, kp2)
+ progress.mastery_levels.update(kp_high=0.95, kp_low=0.95)
now = time.time()
progress.review_queue = [
ReviewTask(
@@ -264,6 +265,30 @@ def test_due_reviews_order_by_forgetting_risk_before_priority():
assert "retrievability" in step.reason
+def test_unmastered_due_tasks_do_not_become_review_work():
+ kp = _kp("kp1", KnowledgeType.MEMORY)
+ progress = _progress(kp)
+ progress.quiz_attempts.append(
+ QuizAttempt(question_id="failed", knowledge_point_id="kp1", is_correct=False)
+ )
+ now = time.time()
+ progress.review_queue = [
+ ReviewTask(
+ id="r1",
+ knowledge_point_id="kp1",
+ knowledge_type=KnowledgeType.MEMORY,
+ due_at=now - 10,
+ priority=1,
+ state=RepetitionState(next_review_at=now - 10),
+ )
+ ]
+
+ assert policy.due_reviews(progress, now=now) == []
+ step = policy.next_objective(progress, now=now)
+ assert step.action == "practice"
+ assert step.knowledge_point_id == "kp1"
+
+
def test_next_objective_complete_when_all_mastered():
kp = _kp("kp1", KnowledgeType.MEMORY)
progress = _progress(kp)
diff --git a/tests/api/test_mastery_path_reviews.py b/tests/api/test_mastery_path_reviews.py
new file mode 100644
index 000000000..484a26172
--- /dev/null
+++ b/tests/api/test_mastery_path_reviews.py
@@ -0,0 +1,43 @@
+"""The mastery review plan must not advertise objectives below the mastery gate."""
+
+import time
+
+from deeptutor.api.routers.mastery_path import _review_queue
+from deeptutor.learning.models import (
+ KnowledgePoint,
+ KnowledgeType,
+ LearningModule,
+ LearningProgress,
+ RepetitionState,
+ ReviewTask,
+)
+
+
+def test_review_queue_only_exposes_mastered_objectives():
+ progress = LearningProgress(book_id="path")
+ mastered = KnowledgePoint(
+ id="mastered", name="Mastered objective", type=KnowledgeType.MEMORY, module_id="m1"
+ )
+ learning = KnowledgePoint(
+ id="learning", name="Learning objective", type=KnowledgeType.MEMORY, module_id="m1"
+ )
+ progress.modules = [
+ LearningModule(id="m1", name="Module", order=0, knowledge_points=[mastered, learning])
+ ]
+ progress.mastery_levels[mastered.id] = 0.95
+ now = time.time()
+ progress.review_queue = [
+ ReviewTask(
+ id=f"review_{kp.id}",
+ knowledge_point_id=kp.id,
+ knowledge_type=kp.type,
+ due_at=now - 10,
+ priority=1,
+ state=RepetitionState(next_review_at=now - 10),
+ )
+ for kp in (learning, mastered)
+ ]
+
+ result = _review_queue(progress, now=now)
+
+ assert [item["knowledge_point_id"] for item in result] == [mastered.id]