Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(courses): surface course deletion failure instead of silent redirect (#1754)

evan188199-tech46199adf51fe
diff --git a/web/app/(utility)/courses/[courseId]/page.tsx b/web/app/(utility)/courses/[courseId]/page.tsx
index 3adef8c5d..a579b9d60 100644
--- a/web/app/(utility)/courses/[courseId]/page.tsx
+++ b/web/app/(utility)/courses/[courseId]/page.tsx
@@ -56,6 +56,8 @@ export default function CourseDetailPage() {
const [loading, setLoading] = useState(true);
const [editOpen, setEditOpen] = useState(false);
const [deleteOpen, setDeleteOpen] = useState(false);
+ const [deleteBusy, setDeleteBusy] = useState(false);
+ const [deleteError, setDeleteError] = useState<string | null>(null);
const [menuOpen, setMenuOpen] = useState(false);
const load = useCallback(async () => {
@@ -175,6 +177,24 @@ export default function CourseDetailPage() {
[load, t],
);
+ const confirmDelete = useCallback(async () => {
+ if (!course) return;
+ setDeleteBusy(true);
+ setDeleteError(null);
+ try {
+ await deleteCourse(course.id);
+ router.push("/courses");
+ } catch (error) {
+ setDeleteError(
+ error instanceof Error && error.message
+ ? error.message
+ : t("Delete failed"),
+ );
+ } finally {
+ setDeleteBusy(false);
+ }
+ }, [course, router, t]);
+
if (loading) {
return (
<div className="space-y-4" aria-label={t("Loading course")}>
@@ -304,6 +324,7 @@ export default function CourseDetailPage() {
type="button"
onClick={() => {
setMenuOpen(false);
+ setDeleteError(null);
setDeleteOpen(true);
}}
className="flex w-full items-center gap-2 rounded-lg px-2 py-1.5 text-[var(--destructive)] hover:bg-[var(--muted)]"
@@ -409,14 +430,19 @@ export default function CourseDetailPage() {
title={t("Delete course?")}
confirmLabel={t("Delete course")}
tone="danger"
+ busy={deleteBusy}
+ busyLabel={t("Deleting…")}
onCancel={() => setDeleteOpen(false)}
- onConfirm={() => {
- void deleteCourse(course.id).then(() => router.push("/courses"));
- }}
+ onConfirm={confirmDelete}
>
{t(
"Conversations will not be deleted. They will move to Unclassified.",
)}
+ {deleteError ? (
+ <p role="alert" className="mt-2 text-[var(--destructive)]">
+ {deleteError}
+ </p>
+ ) : null}
</ConfirmDialog>
</div>
);
diff --git a/web/tests/course-detail-delete.spec.tsx b/web/tests/course-detail-delete.spec.tsx
new file mode 100644
index 000000000..dca197af9
--- /dev/null
+++ b/web/tests/course-detail-delete.spec.tsx
@@ -0,0 +1,101 @@
+import { fireEvent, render, screen, waitFor, within } from "@testing-library/react";
+import { beforeEach, expect, it, vi } from "vitest";
+
+import CourseDetailPage from "@/app/(utility)/courses/[courseId]/page";
+import type { StudyCourse } from "@/lib/courses-api";
+
+const fixture = vi.hoisted(() => ({
+ course: null as StudyCourse | null,
+ listCourses: vi.fn(),
+ getCourseState: vi.fn(),
+ deleteCourse: vi.fn(),
+ listAllSessions: vi.fn(),
+ push: vi.fn(),
+}));
+
+vi.mock("next/navigation", () => ({
+ useRouter: () => ({ push: fixture.push }),
+ useParams: () => ({ courseId: "course-1" }),
+}));
+vi.mock("react-i18next", () => ({
+ useTranslation: () => ({ t: (key: string) => key }),
+}));
+vi.mock("@/lib/courses-api", async (importOriginal) => ({
+ ...(await importOriginal<typeof import("@/lib/courses-api")>()),
+ listCourses: (...args: unknown[]) => fixture.listCourses(...args),
+ getCourseState: (...args: unknown[]) => fixture.getCourseState(...args),
+ deleteCourse: (...args: unknown[]) => fixture.deleteCourse(...args),
+}));
+vi.mock("@/lib/session-api", async (importOriginal) => ({
+ ...(await importOriginal<typeof import("@/lib/session-api")>()),
+ listAllSessions: (...args: unknown[]) => fixture.listAllSessions(...args),
+}));
+
+function makeCourse(): StudyCourse {
+ return {
+ id: "course-1",
+ name: "Linear Algebra",
+ description: "Vectors and matrices",
+ color: "#C65D2E",
+ created_at: 1,
+ updated_at: 1,
+ instructions: "",
+ agent_notes: "",
+ default_capability: "",
+ default_persona: "",
+ resources: [],
+ syllabus: [],
+ status: "active",
+ archived_at: 0,
+ };
+}
+
+async function openDeleteDialog() {
+ fireEvent.click(screen.getByRole("button", { name: "Course actions" }));
+ fireEvent.click(screen.getByRole("button", { name: "Delete course" }));
+ return screen.findByRole("alertdialog");
+}
+
+beforeEach(() => {
+ fixture.course = makeCourse();
+ fixture.listCourses.mockImplementation(async () => [fixture.course!]);
+ fixture.listAllSessions.mockImplementation(async () => []);
+ fixture.getCourseState.mockImplementation(async () => null);
+ fixture.deleteCourse.mockImplementation(async () => undefined);
+ fixture.push.mockReset();
+});
+
+it("shows a visible error and stays on the course page when deletion fails", async () => {
+ fixture.deleteCourse.mockImplementation(async () => {
+ throw new Error("offline");
+ });
+ render(<CourseDetailPage />);
+ await screen.findByText("Linear Algebra");
+
+ const dialog = await openDeleteDialog();
+ fireEvent.click(
+ within(dialog).getByRole("button", { name: "Delete course" }),
+ );
+
+ const alert = await screen.findByRole("alert");
+ expect(alert).toHaveTextContent("offline");
+ expect(fixture.push).not.toHaveBeenCalled();
+ // The dialog stays open so the failure is seen in context and retry is possible.
+ expect(screen.getByRole("alertdialog")).toBeInTheDocument();
+});
+
+it("navigates back to the course list only after a successful deletion", async () => {
+ render(<CourseDetailPage />);
+ await screen.findByText("Linear Algebra");
+
+ const dialog = await openDeleteDialog();
+ fireEvent.click(
+ within(dialog).getByRole("button", { name: "Delete course" }),
+ );
+
+ await waitFor(() =>
+ expect(fixture.push).toHaveBeenCalledWith("/courses"),
+ );
+ expect(fixture.deleteCourse).toHaveBeenCalledWith("course-1");
+ expect(screen.queryByRole("alert")).toBeNull();
+});