DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.
Python ai-agentsai-tutorclawbotcli-tooldeepresearchinteractive-learninglearningmulti-agent-systemsrag
fix(agent-loop): keep content parts when appending a loop directive
Fancie-Personal4826ae980a23
diff --git a/deeptutor/agents/loop/agent_loop.py b/deeptutor/agents/loop/agent_loop.pyindex 7f1a76821..6d05704c1 100644--- a/deeptutor/agents/loop/agent_loop.py+++ b/deeptutor/agents/loop/agent_loop.py@@ -243,6 +243,31 @@ def _assistant_round_message(result: LLMCallResult) -> dict[str, Any]:return message+def _append_directive_to_parts(parts: list[Any], instruction: str) -> list[Any]:+ """Extend a multimodal user message with a text directive, keeping its parts.++ The trailing user message can carry content parts: a chat PDF's embedded+ images arrive as ``image_url`` blocks beside the text that references them.+ Text is appended to the message's own text part (the parts-list analogue of+ the plain-string branch in :meth:`AgentLoop._append_loop_instruction`), and+ a message holding nothing but images gets a text part of its own.++ Only the directive is added. Rebuilding the message as a string instead+ would fold every ``data:...;base64,`` payload into prompt text and send the+ image bytes to the provider as language tokens on the next round.+ """+ updated = list(parts)+ for index in range(len(updated) - 1, -1, -1):+ part = updated[index]+ if isinstance(part, dict) and isinstance(part.get("text"), str):+ prior = part["text"].rstrip()+ merged = f"{prior}\n\n{instruction}" if prior else instruction+ updated[index] = {**part, "text": merged}+ return updated+ updated.append({"type": "text", "text": instruction})+ return updated++def _has_replayable_assistant_state(result: LLMCallResult) -> bool:"""Whether a tool-less round still has provider state to replay."""return bool(@@ -793,7 +818,11 @@ class AgentLoop:def _append_loop_instruction(messages: list[dict[str, Any]], instruction: str) -> None:"""Append a loop directive without creating consecutive user roles."""if messages and messages[-1].get("role") == "user":- prior = str(messages[-1].get("content") or "").rstrip()+ content = messages[-1].get("content")+ if isinstance(content, list):+ messages[-1]["content"] = _append_directive_to_parts(content, instruction)+ return+ prior = str(content or "").rstrip()messages[-1]["content"] = f"{prior}\n\n{instruction}" if prior else instructionreturnmessages.append({"role": "user", "content": instruction})diff --git a/tests/agents/chat/test_agent_loop.py b/tests/agents/chat/test_agent_loop.pyindex bdd1840e4..ab53dc502 100644--- a/tests/agents/chat/test_agent_loop.py+++ b/tests/agents/chat/test_agent_loop.py@@ -823,6 +823,88 @@ async def test_empty_finish_gets_one_nudge_then_recovers(assert result.metadata["completed"] is True+async def test_empty_round_nudge_keeps_multimodal_user_parts(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ """A nudge must extend a multimodal user message, never stringify it.++ A chat PDF's embedded images ride in the trailing user message's content+ parts. A round that finishes with nothing to replay leaves that message+ trailing, so the recovery directive is appended to it; rebuilding the+ message as a string folds every ``data:...;base64,`` payload into prompt+ text and the next round bills image bytes as language tokens.+ """+ image = {"type": "image_url", "image_url": {"url": "data:image/png;base64,YWJj"}}+ messages = [+ {+ "role": "user",+ "content": [+ {"type": "text", "text": "[Attached Documents]\nQuestion sheet"},+ image,+ ],+ }+ ]+ client = _ScriptedChatClient(+ [+ # Round 1: an empty finish — no text, no reasoning, no tool call.+ [_llm_chunk(finish_reason="stop")],+ # Round 2 (after the nudge): a real answer.+ [_llm_chunk(content="Here is the real answer.")],+ ]+ )+ pipeline = AgenticChatPipeline(language="en")+ pipeline.registry = _Registry()+ pipeline._model_turn_start = 0+ monkeypatch.setattr(pipeline, "_compose_enabled_tools", lambda _context: [])+ monkeypatch.setattr(pipeline, "_build_openai_client", lambda: client)+ monkeypatch.setattr(pipeline, "_build_loop_messages", lambda *_args, **_kwargs: messages)++ events = await _run(pipeline, UnifiedContext(session_id="s1", user_message="Solve it"))++ assert client.call_count == 2+ durable = messages[0]["content"]+ assert isinstance(durable, list)+ assert [part["type"] for part in durable] == ["text", "image_url"]+ assert durable[0]["text"].startswith("[Attached Documents]\nQuestion sheet")+ assert "internal reasoning" in durable[0]["text"]+ assert durable[1] == image+ # The round the provider receives still carries the image as an image.+ wire = client.calls[1]["messages"][-1]["content"]+ assert any(part.get("type") == "image_url" for part in wire)+ result = _result(events)+ assert result.metadata["response"] == "Here is the real answer."+ assert result.metadata["completed"] is True+++async def test_pure_image_message_gets_its_own_directive_part(+ monkeypatch: pytest.MonkeyPatch,+) -> None:+ """A message holding only images has no text part to extend."""+ image = {"type": "image_url", "image_url": {"url": "data:image/png;base64,YWJj"}}+ messages = [{"role": "user", "content": [image]}]+ client = _ScriptedChatClient(+ [+ [_llm_chunk(finish_reason="stop")],+ [_llm_chunk(content="Answered from the image.")],+ ]+ )+ pipeline = AgenticChatPipeline(language="en")+ pipeline.registry = _Registry()+ pipeline._model_turn_start = 0+ monkeypatch.setattr(pipeline, "_compose_enabled_tools", lambda _context: [])+ monkeypatch.setattr(pipeline, "_build_openai_client", lambda: client)+ monkeypatch.setattr(pipeline, "_build_loop_messages", lambda *_args, **_kwargs: messages)++ await _run(pipeline, UnifiedContext(session_id="s1", user_message="What is this?"))++ durable = messages[0]["content"]+ assert [part["type"] for part in durable] == ["image_url", "text"]+ assert "internal reasoning" in durable[1]["text"]+ assert durable[0] == image++@pytest.mark.asyncioasync def test_explore_context_pre_pass_seeds_loop_without_polluting_answer(monkeypatch: pytest.MonkeyPatch,