Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(settings): accept the caller's image fallback flag on the validated client

cgycorey4da7b28372d1
diff --git a/deeptutor/services/llm/image_description.py b/deeptutor/services/llm/image_description.py
index 299b2d11e..08fa8cb57 100644
--- a/deeptutor/services/llm/image_description.py
+++ b/deeptutor/services/llm/image_description.py
@@ -54,6 +54,8 @@ class _ImageDescriptionClient(LLMClient):
history: list[dict[str, str]] | None = None,
**kwargs: Any,
) -> str:
+ # The caption batcher passes this flag too; the validated verdict wins.
+ kwargs.pop("allow_image_fallback", None)
# Preserve the full resolved profile (including wire API and endpoint)
# rather than rebuilding an override from a subset of its fields.
return await complete_with_config(
diff --git a/tests/services/llm/test_image_description_vision_gate.py b/tests/services/llm/test_image_description_vision_gate.py
index ec5831890..3af10b6fa 100644
--- a/tests/services/llm/test_image_description_vision_gate.py
+++ b/tests/services/llm/test_image_description_vision_gate.py
@@ -124,3 +124,35 @@ async def test_complete_sends_images_for_the_validated_selection(
assert await client.complete("Describe", image_data="synthetic-image") == "a labelled diagram"
assert calls[0]["allow_image_fallback"] is False
+
+
+async def test_complete_tolerates_a_caller_supplied_fallback_flag(
+ tmp_path: Path, monkeypatch
+) -> None:
+ """The caption batcher passes this flag itself; it must not collide."""
+ service = _service(tmp_path, [{"id": "m", "model": "llama3.2-vision"}])
+ _patch_catalog(monkeypatch, service)
+ config = resolve_image_description_config(SELECTION)
+ calls: list[bool | None] = []
+
+ async def complete(
+ *,
+ config: Any,
+ prompt: str,
+ system_prompt: str,
+ messages: Any,
+ allow_image_fallback: bool | None = None,
+ **kwargs: Any,
+ ) -> str:
+ calls.append(allow_image_fallback)
+ return "a labelled diagram"
+
+ monkeypatch.setattr(image_description, "complete_with_config", complete)
+ client = image_description._ImageDescriptionClient(config, configure_env=False)
+
+ caption = await client.complete(
+ "Describe", image_data="synthetic-image", max_retries=0, allow_image_fallback=False
+ )
+ assert caption == "a labelled diagram"
+ assert calls == [False]