Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix: support Malay as a persistent reply language

Bingxi Zhao (Frank)550268e1e342
diff --git a/deeptutor/api/routers/settings.py b/deeptutor/api/routers/settings.py
index 1420d584c..41fd591c5 100644
--- a/deeptutor/api/routers/settings.py
+++ b/deeptutor/api/routers/settings.py
@@ -109,6 +109,7 @@ ResponseLanguage = Literal[
"ar",
"pl",
"uk",
+ "ms",
]
diff --git a/deeptutor/core/response_languages.py b/deeptutor/core/response_languages.py
index fa255208c..4737e853a 100644
--- a/deeptutor/core/response_languages.py
+++ b/deeptutor/core/response_languages.py
@@ -15,6 +15,7 @@ SUPPORTED_RESPONSE_LANGUAGES: tuple[str, ...] = (
"ar",
"pl",
"uk",
+ "ms",
)
diff --git a/deeptutor/services/prompt/language.py b/deeptutor/services/prompt/language.py
index 608756758..426796e2f 100644
--- a/deeptutor/services/prompt/language.py
+++ b/deeptutor/services/prompt/language.py
@@ -23,6 +23,7 @@ _LANGUAGE_LABELS: dict[str, str] = {
"it": "Italiano",
"ar": "العربية",
"pl": "Polski",
+ "ms": "Bahasa Melayu",
}
diff --git a/deeptutor/services/settings/interface_settings.py b/deeptutor/services/settings/interface_settings.py
index 5707017a9..95e7cc312 100644
--- a/deeptutor/services/settings/interface_settings.py
+++ b/deeptutor/services/settings/interface_settings.py
@@ -50,6 +50,8 @@ _RESPONSE_LANGUAGE_ALIASES: dict[str, str] = {
"italian": "it",
"arabic": "ar",
"polish": "pl",
+ "malay": "ms",
+ "bahasa melayu": "ms",
}
diff --git a/tests/api/test_settings_router.py b/tests/api/test_settings_router.py
index 85f63a3c9..b107cccc3 100644
--- a/tests/api/test_settings_router.py
+++ b/tests/api/test_settings_router.py
@@ -122,6 +122,12 @@ async def test_ui_accepts_extended_response_languages(
)
assert response["response_language"] == "pt"
+ response = await settings_router.update_ui_settings(
+ settings_router.UISettingsUpdate(response_language="ms")
+ )
+ assert response["response_language"] == "ms"
+ assert settings_router.load_ui_settings()["response_language"] == "ms"
+
class _FakeEmbeddingAdapter:
def __init__(self, config: dict[str, Any]):
diff --git a/tests/multi_user/test_ui_language_scoping.py b/tests/multi_user/test_ui_language_scoping.py
index ca24ac87d..083dfbd4d 100644
--- a/tests/multi_user/test_ui_language_scoping.py
+++ b/tests/multi_user/test_ui_language_scoping.py
@@ -75,6 +75,8 @@ def test_response_language_normalizes_supported_labels_and_variants():
)
assert resolve_languages({"response_language": "ja-JP"})["response_language"] == "ja"
assert resolve_languages({"response_language": "zh-TW"})["response_language"] == "zh-tw"
+ assert resolve_languages({"response_language": "ms-MY"})["response_language"] == "ms"
+ assert resolve_languages({"response_language": "Malay"})["response_language"] == "ms"
def test_response_language_falls_back_when_unsupported():
diff --git a/tests/services/prompt/test_language_directive.py b/tests/services/prompt/test_language_directive.py
index 079df92c6..67bfc4f0c 100644
--- a/tests/services/prompt/test_language_directive.py
+++ b/tests/services/prompt/test_language_directive.py
@@ -65,7 +65,7 @@ def test_fixed_session_selector_disables_conversational_override() -> None:
@pytest.mark.parametrize(
("language", "label"),
- [("fr", "Français"), ("uk", "Українська")],
+ [("fr", "Français"), ("uk", "Українська"), ("ms", "Bahasa Melayu")],
)
def test_loop_preserves_requested_output_language_with_english_prompt_assets(
language: str, label: str
diff --git a/tests/services/session/test_reply_language_override.py b/tests/services/session/test_reply_language_override.py
index f060944c2..be45782ec 100644
--- a/tests/services/session/test_reply_language_override.py
+++ b/tests/services/session/test_reply_language_override.py
@@ -64,7 +64,8 @@ async def test_explicit_reply_language_stays_with_one_conversation(
@pytest.mark.parametrize(
- "code", ["en", "zh", "zh-tw", "ja", "ko", "es", "fr", "de", "ru", "pt", "it", "ar", "pl", "uk"]
+ "code",
+ ["en", "zh", "zh-tw", "ja", "ko", "es", "fr", "de", "ru", "pt", "it", "ar", "pl", "uk", "ms"],
)
def test_selector_accepts_every_supported_response_language(code: str) -> None:
assert TurnRequest(content="hi", reply_language_override=code).reply_language_override == code
diff --git a/web/context/app-shell-storage.ts b/web/context/app-shell-storage.ts
index bf76442fc..cda821518 100644
--- a/web/context/app-shell-storage.ts
+++ b/web/context/app-shell-storage.ts
@@ -24,7 +24,8 @@ export type ResponseLanguage =
| "it"
| "ar"
| "pl"
- | "uk";
+ | "uk"
+ | "ms";
const SUPPORTED_RESPONSE_LANGUAGE_CODES: readonly ResponseLanguage[] = [
"en",
@@ -41,6 +42,7 @@ const SUPPORTED_RESPONSE_LANGUAGE_CODES: readonly ResponseLanguage[] = [
"ar",
"pl",
"uk",
+ "ms",
];
export function isResponseLanguage(value: unknown): value is ResponseLanguage {
@@ -63,6 +65,8 @@ const RESPONSE_LANGUAGE_ALIASES: Record<string, ResponseLanguage> = {
arabic: "ar",
polish: "pl",
ukrainian: "uk",
+ malay: "ms",
+ "bahasa melayu": "ms",
"zh-cn": "zh",
};
diff --git a/web/contracts/generated/api.ts b/web/contracts/generated/api.ts
index f41835930..6677f11f6 100644
--- a/web/contracts/generated/api.ts
+++ b/web/contracts/generated/api.ts
@@ -15369,6 +15369,7 @@ export interface components {
| "ar"
| "pl"
| "uk"
+ | "ms"
)
| null;
/** Sidebar Description */
diff --git a/web/contracts/schema/openapi.json b/web/contracts/schema/openapi.json
index d7923e8ee..106b6ace9 100644
--- a/web/contracts/schema/openapi.json
+++ b/web/contracts/schema/openapi.json
@@ -10772,7 +10772,8 @@
"it",
"ar",
"pl",
- "uk"
+ "uk",
+ "ms"
],
"type": "string"
},
diff --git a/web/features/settings/store/SettingsStore.tsx b/web/features/settings/store/SettingsStore.tsx
index abf7c6fc5..6304dbd68 100644
--- a/web/features/settings/store/SettingsStore.tsx
+++ b/web/features/settings/store/SettingsStore.tsx
@@ -115,6 +115,7 @@ export const RESPONSE_LANGUAGE_OPTIONS: readonly ResponseLanguageOption[] = [
{ value: "ar", label: "العربية" },
{ value: "pl", label: "Polski" },
{ value: "uk", label: "Українська" },
+ { value: "ms", label: "Bahasa Melayu" },
];
type CodeBlockUiSettings = Pick<
diff --git a/web/tests/language-preferences.test.ts b/web/tests/language-preferences.test.ts
index 0a0055cf7..ef8637aaf 100644
--- a/web/tests/language-preferences.test.ts
+++ b/web/tests/language-preferences.test.ts
@@ -30,6 +30,8 @@ test("response language accepts and normalizes the extended registry", () => {
assert.equal(resolveResponseLanguage("Japanese", "en"), "ja");
assert.equal(resolveResponseLanguage("zh-cn", "en"), "zh");
assert.equal(resolveResponseLanguage("pt-BR", "en"), "pt");
+ assert.equal(resolveResponseLanguage("ms-MY", "en"), "ms");
+ assert.equal(resolveResponseLanguage("Malay", "en"), "ms");
assert.equal(resolveResponseLanguage("klingon", "zh"), "zh");
});