DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.
Python ai-agentsai-tutorclawbotcli-tooldeepresearchinteractive-learninglearningmulti-agent-systemsrag
fix(partners): require successful persona load before saving
dajiaohuang7799c161072f
diff --git a/web/components/partners/PartnerConfigure.tsx b/web/components/partners/PartnerConfigure.tsxindex 87cd218f2..9a030ede6 100644--- a/web/components/partners/PartnerConfigure.tsx+++ b/web/components/partners/PartnerConfigure.tsx@@ -89,6 +89,7 @@ export default function PartnerConfigure({// Soulconst [soul, setSoul] = useState("");const [soulLoaded, setSoulLoaded] = useState(false);+ const [soulError, setSoulError] = useState<string | null>(null);const [savingSoul, setSavingSoul] = useState(false);// Model@@ -124,13 +125,19 @@ export default function PartnerConfigure({});const [addingAssets, setAddingAssets] = useState(false);+ const loadSoul = useCallback(async () => {+ setSoulLoaded(false);+ setSoulError(null);+ try {+ setSoul(await getPartnerSoul(partnerId));+ setSoulLoaded(true);+ } catch (error) {+ setSoulError(error instanceof Error ? error.message : String(error));+ }+ }, [partnerId]);+useEffect(() => {- void getPartnerSoul(partnerId)- .then((content) => {- setSoul(content);- setSoulLoaded(true);- })- .catch(() => setSoulLoaded(true));+ void loadSoul();void getPartnerAssets(partnerId).then(setAssets).catch(() => {});@@ -163,7 +170,7 @@ export default function PartnerConfigure({}).catch(() => {});// eslint-disable-next-line react-hooks/exhaustive-deps- }, [partnerId]);+ }, [partnerId, loadSoul]);const saveWorkspace = async (workspaceId: string) => {setSavingWorkspace(true);@@ -398,6 +405,14 @@ export default function PartnerConfigure({</button>}>+ {soulError && (+ <div className="mb-3 flex items-center gap-2 text-[12px] text-red-500">+ <span>{soulError}</span>+ <button type="button" onClick={() => void loadSoul()}>+ {t("Retry")}+ </button>+ </div>+ )}<SoulEditor value={soul} onChange={setSoul} heightClass="h-[280px]" /></Section>diff --git a/web/tests/partner-soul-load-errors.spec.tsx b/web/tests/partner-soul-load-errors.spec.tsxnew file mode 100644index 000000000..7a3408109--- /dev/null+++ b/web/tests/partner-soul-load-errors.spec.tsx@@ -0,0 +1,66 @@+import { act, cleanup, fireEvent, render, screen, waitFor, within } from "@testing-library/react";+import { afterEach, expect, it, vi } from "vitest";+import PartnerConfigure from "@/components/partners/PartnerConfigure";+import { apiFetch } from "@/lib/api";+import type { PartnerInfo } from "@/lib/partners-api";++vi.mock("react-i18next", () => ({ useTranslation: () => ({ t: (key: string) => key }) }));+vi.mock("@/components/common/MarkdownRenderer", () => ({ default: () => null }));+vi.mock("@/components/partners/FaceEditor", () => ({ default: () => null }));+vi.mock("@/components/partners/PartnerModelSelect", () => ({ default: () => null }));+vi.mock("@/components/partners/PartnerWorkspacePicker", () => ({ default: () => null }));+vi.mock("@/components/partners/ToolPicker", () => ({ default: () => null }));+vi.mock("@/components/partners/AssetPicker", () => ({ default: () => null }));+vi.mock("@/lib/llm-options", () => ({ listLLMOptions: async () => ({ options: [], active: null }) }));+vi.mock("@/lib/api", async () => {+ const actual = await vi.importActual<typeof import("@/lib/api")>("@/lib/api");+ return { ...actual, apiUrl: (url: string) => url, apiFetch: vi.fn() };+});++const partner: PartnerInfo = { partner_id: "study", name: "Study", description: "", channels: [], running: false, started_at: null };+afterEach(() => { cleanup(); vi.clearAllMocks(); });++function setup(status: number, content = "Existing persona") {+ vi.mocked(apiFetch).mockImplementation(async (url, options) => {+ if (String(url).endsWith("/soul")) {+ if (options?.method === "PUT") return Response.json({ saved: true });+ return Response.json(status === 200 ? { content } : { detail: "Persona storage unavailable" }, { status });+ }+ if (String(url).endsWith("/tool-options")) return Response.json({ tools: [], builtin_tools: [], mcp_tools: [] });+ return Response.json({ knowledge_bases: [], skills: [], notebooks: [] });+ });+}++function soulSection() {+ return within(screen.getByRole("heading", { name: "Soul" }).closest("section")!);+}++it("does not allow a failed persona read to be saved as an empty document", async () => {+ setup(503);+ render(<PartnerConfigure partner={partner} onToast={vi.fn()} onUpdated={vi.fn()} />);+ await waitFor(() => expect(apiFetch).toHaveBeenCalled());+ await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });+ const save = soulSection().getByRole("button", { name: "Save" });+ await act(async () => { fireEvent.click(save); });+ expect(apiFetch).not.toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ method: "PUT" }));+ expect(save).toBeDisabled();+});++it("allows an intentionally empty successfully loaded persona to be saved", async () => {+ setup(200, "");+ render(<PartnerConfigure partner={partner} onToast={vi.fn()} onUpdated={vi.fn()} />);+ const save = soulSection().getByRole("button", { name: "Save" });+ await waitFor(() => expect(save).not.toBeDisabled());+ await act(async () => { fireEvent.click(save); });+ await waitFor(() => expect(apiFetch).toHaveBeenCalledWith("/api/partners/study/soul", expect.objectContaining({ method: "PUT", body: JSON.stringify({ content: "" }) })));+});++it("loads the stored persona on retry before enabling save", async () => {+ setup(503);+ render(<PartnerConfigure partner={partner} onToast={vi.fn()} onUpdated={vi.fn()} />);+ await screen.findByText("Persona storage unavailable");+ setup(200);+ fireEvent.click(soulSection().getByRole("button", { name: "Retry" }));+ await waitFor(() => expect(soulSection().getByRole("textbox")).toHaveValue("Existing persona"));+ expect(soulSection().getByRole("button", { name: "Save" })).not.toBeDisabled();+});