Skip to content

DeepTutor: Lifelong Personalized Tutoring. https://deeptutor.info/.

fix(mermaid): retry rendering after corrected source

dajiaohuang7ea697f74c63
diff --git a/web/components/Mermaid.tsx b/web/components/Mermaid.tsx
index 68565af98..6c158265b 100644
--- a/web/components/Mermaid.tsx
+++ b/web/components/Mermaid.tsx
@@ -109,7 +109,9 @@ export const Mermaid: React.FC<MermaidProps> = ({ chart, className = "" }) => {
let cancelled = false;
const renderChart = async () => {
- if (!chart.trim() || !containerRef.current) return;
+ // The error view has no SVG container. A corrected chart must still
+ // reach the renderer so success can mount that container again.
+ if (!chart.trim()) return;
try {
const mermaid = await loadMermaid();
diff --git a/web/tests/mermaid-error-recovery.spec.tsx b/web/tests/mermaid-error-recovery.spec.tsx
new file mode 100644
index 000000000..3b6f6a872
--- /dev/null
+++ b/web/tests/mermaid-error-recovery.spec.tsx
@@ -0,0 +1,21 @@
+import { render, screen, waitFor } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+import { Mermaid } from "@/components/Mermaid";
+
+const renderer = vi.hoisted(() => ({ render: vi.fn(), initialize: vi.fn() }));
+vi.mock("mermaid", () => ({ default: renderer }));
+vi.mock("react-i18next", () => ({ useTranslation: () => ({ t: (value: string) => value }) }));
+
+describe("Mermaid rendering recovery", () => {
+ it("renders a corrected chart after a renderer error", async () => {
+ renderer.render.mockReset()
+ .mockRejectedValueOnce(new Error("Parse error"))
+ .mockResolvedValueOnce({ svg: '<svg aria-label="corrected diagram"></svg>' });
+ const { rerender } = render(<Mermaid chart="flowchart TD; A[" />);
+ await screen.findByText("Diagram rendering error", {}, { timeout: 2500 });
+ rerender(<Mermaid chart="flowchart TD; A-->B" />);
+ await waitFor(() => expect(renderer.render).toHaveBeenCalledTimes(2), { timeout: 2500 });
+ expect(screen.getByLabelText("corrected diagram")).toBeInTheDocument();
+ expect(screen.queryByText("Diagram rendering error")).not.toBeInTheDocument();
+ });
+});